[PATCH] power: supply: ucs1002: fix error code in ucs1002_get_property()

[PATCH] power: supply: ucs1002: fix error code in ucs1002_get_property()

[Dan Carpenter]

This function is supposed to return 0 for success instead of returning
the val->intval.  This makes it the same as the other case statements
in this function.

Fixes: 81196e2e57fc ("power: supply: ucs1002: fix some health status issues")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
From code review.  Untested.

 drivers/power/supply/ucs1002_power.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
index 954feba6600b..7970843a4f48 100644
--- a/drivers/power/supply/ucs1002_power.c
+++ b/drivers/power/supply/ucs1002_power.c
@@ -384,7 +384,8 @@ static int ucs1002_get_property(struct power_supply *psy,
 	case POWER_SUPPLY_PROP_USB_TYPE:
 		return ucs1002_get_usb_type(info, val);
 	case POWER_SUPPLY_PROP_HEALTH:
-		return val->intval = info->health;
+		val->intval = info->health;
+		return 0;
 	case POWER_SUPPLY_PROP_PRESENT:
 		val->intval = info->present;
 		return 0;
-- 
2.39.2

Re: [PATCH] power: supply: ucs1002: fix error code in ucs1002_get_property()

[Sebastian Reichel]

On Mon, 19 Jun 2023 12:44:17 +0300, Dan Carpenter wrote:
> This function is supposed to return 0 for success instead of returning
> the val->intval.  This makes it the same as the other case statements
> in this function.
> 
> 

Applied, thanks!

[1/1] power: supply: ucs1002: fix error code in ucs1002_get_property()
      commit: e35059949daa83f8dadf710d0f829ab3c3a72fe2

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>