From: Segher Boessenkool <segher@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Steven Rostedt <srostedt@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER
Date: Sat, 2 May 2009 21:48:08 +0200 [thread overview]
Message-ID: <68B2EF73-0FD2-41F9-966B-9A54965AFBA6@kernel.crashing.org> (raw)
In-Reply-To: <20090502001421.GA9342@oksana.dev.rtsoft.ru>
> This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
> defined, the top level Makefile won't add -fno-omit-frame-pointer
> cflag (the flag is useless for PowerPC kernels, and also makes gcc
> generate wrong code).
> +++ b/arch/powerpc/Kconfig
> + select HAVE_NORMAL_FRAME_POINTER
> +config HAVE_NORMAL_FRAME_POINTER
> + bool
> + help
> + Architectures should select this symbol if their ABI implies
> + having a frame pointer.
I am totally confused what you call a frame pointer here.
None of the relevant PowerPC ABIs have a frame pointer
separate from the stack pointer; the compiler can create
one, of course. A better config symbol name and help text
would help understand this patch :-)
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Steven Rostedt <srostedt@redhat.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER
Date: Sat, 2 May 2009 21:48:08 +0200 [thread overview]
Message-ID: <68B2EF73-0FD2-41F9-966B-9A54965AFBA6@kernel.crashing.org> (raw)
In-Reply-To: <20090502001421.GA9342@oksana.dev.rtsoft.ru>
> This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
> defined, the top level Makefile won't add -fno-omit-frame-pointer
> cflag (the flag is useless for PowerPC kernels, and also makes gcc
> generate wrong code).
> +++ b/arch/powerpc/Kconfig
> + select HAVE_NORMAL_FRAME_POINTER
> +config HAVE_NORMAL_FRAME_POINTER
> + bool
> + help
> + Architectures should select this symbol if their ABI implies
> + having a frame pointer.
I am totally confused what you call a frame pointer here.
None of the relevant PowerPC ABIs have a frame pointer
separate from the stack pointer; the compiler can create
one, of course. A better config symbol name and help text
would help understand this patch :-)
Segher
next prev parent reply other threads:[~2009-05-02 19:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 0:13 [PATCH v5 0/3] Tracers vs. CALLER_ADDR on PowerPC Anton Vorontsov
2009-05-02 0:13 ` Anton Vorontsov
2009-05-02 0:14 ` [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER Anton Vorontsov
2009-05-02 0:14 ` Anton Vorontsov
2009-05-02 19:48 ` Segher Boessenkool [this message]
2009-05-02 19:48 ` Segher Boessenkool
2009-05-03 2:04 ` Steven Rostedt
2009-05-03 2:04 ` Steven Rostedt
2009-05-05 7:56 ` Segher Boessenkool
2009-05-05 7:56 ` Segher Boessenkool
2009-05-05 13:33 ` Steven Rostedt
2009-05-05 13:33 ` Steven Rostedt
2009-05-05 13:51 ` Segher Boessenkool
2009-05-05 13:51 ` Segher Boessenkool
2009-05-05 23:11 ` Steven Rostedt
2009-05-05 23:11 ` Steven Rostedt
2009-05-18 4:14 ` Benjamin Herrenschmidt
2009-05-18 4:14 ` Benjamin Herrenschmidt
2009-05-18 19:55 ` Segher Boessenkool
2009-05-18 19:55 ` Segher Boessenkool
2009-05-02 0:14 ` [PATCH 2/3] powerpc: Remove -fno-omit-frame-pointer workarounds Anton Vorontsov
2009-05-02 0:14 ` Anton Vorontsov
2009-05-02 0:14 ` [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER Anton Vorontsov
2009-05-02 0:14 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2009-03-20 16:44 [PATCH v4 0/3] Tracers vs. CALLER_ADDR on PowerPC Anton Vorontsov
2009-03-20 16:44 ` [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER Anton Vorontsov
2009-03-20 16:44 ` Anton Vorontsov
2009-03-21 3:49 ` Steven Rostedt
2009-03-21 3:49 ` Steven Rostedt
2009-03-28 10:48 ` Anton Vorontsov
2009-03-28 10:48 ` Anton Vorontsov
2009-03-29 22:54 ` Benjamin Herrenschmidt
2009-03-29 22:54 ` Benjamin Herrenschmidt
2009-03-30 4:36 ` Sam Ravnborg
2009-03-30 4:36 ` Sam Ravnborg
2009-04-05 21:07 ` Sam Ravnborg
2009-04-05 21:07 ` Sam Ravnborg
2009-04-13 15:51 ` Steven Rostedt
2009-04-13 15:51 ` Steven Rostedt
2009-05-02 0:14 ` Anton Vorontsov
2009-05-02 0:14 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68B2EF73-0FD2-41F9-966B-9A54965AFBA6@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=sam@ravnborg.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.