From: Ray Jui <ray.jui@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
andrew@lunn.ch, rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH v3 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr
Date: Tue, 4 Sep 2018 13:39:30 -0700 [thread overview]
Message-ID: <68b987de-9229-4606-a972-650b3f486e19@broadcom.com> (raw)
In-Reply-To: <20180831192039.11842-2-f.fainelli@gmail.com>
On 8/31/2018 12:20 PM, Florian Fainelli wrote:
> Enable the SFP connected to port 5 of the switch and wire up all GPIOs
> to the SFP cage. Because of a hardware limitation of the i2c controller
> on the iProc SoCs which prevents large i2c (> 63 bytes) transactions to
> work, we use the i2c-gpio interface instead, which does not have that
> limitation. This allows us to read the SFP module EEPROM, which would
> not be possible otherwise since it exceeds that size during a single
> read transfer.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm958625hr.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
> index ea3fc194f8f3..a53a2f629d74 100644
> --- a/arch/arm/boot/dts/bcm958625hr.dts
> +++ b/arch/arm/boot/dts/bcm958625hr.dts
> @@ -58,6 +58,24 @@
> open-source;
> priority = <200>;
> };
> +
> + /* Hardware I2C block cannot do more than 63 bytes per transfer,
> + * which would prevent reading from a SFP's EEPROM (256 byte).
> + */
> + i2c1: i2c {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpioa 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + };
> +
> + sfp: sfp {
> + compatible = "sff,sfp";
> + i2c-bus = <&i2c1>;
> + mod-def0-gpios = <&gpioa 28 GPIO_ACTIVE_LOW>;
> + los-gpios = <&gpioa 24 GPIO_ACTIVE_HIGH>;
> + tx-fault-gpios = <&gpioa 30 GPIO_ACTIVE_HIGH>;
> + tx-disable-gpios = <&gpioa 26 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &amac0 {
> @@ -210,6 +228,14 @@
> reg = <4>;
> };
>
> + port@5 {
> + label = "sfp";
> + phy-mode = "sgmii";
> + reg = <5>;
> + sfp = <&sfp>;
> + managed = "in-band-status";
> + };
> +
> port@8 {
> ethernet = <&amac2>;
> label = "cpu";
>
Looks good to me. Thanks!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
WARNING: multiple messages have this Message-ID (diff)
From: ray.jui@broadcom.com (Ray Jui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr
Date: Tue, 4 Sep 2018 13:39:30 -0700 [thread overview]
Message-ID: <68b987de-9229-4606-a972-650b3f486e19@broadcom.com> (raw)
In-Reply-To: <20180831192039.11842-2-f.fainelli@gmail.com>
On 8/31/2018 12:20 PM, Florian Fainelli wrote:
> Enable the SFP connected to port 5 of the switch and wire up all GPIOs
> to the SFP cage. Because of a hardware limitation of the i2c controller
> on the iProc SoCs which prevents large i2c (> 63 bytes) transactions to
> work, we use the i2c-gpio interface instead, which does not have that
> limitation. This allows us to read the SFP module EEPROM, which would
> not be possible otherwise since it exceeds that size during a single
> read transfer.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm958625hr.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts
> index ea3fc194f8f3..a53a2f629d74 100644
> --- a/arch/arm/boot/dts/bcm958625hr.dts
> +++ b/arch/arm/boot/dts/bcm958625hr.dts
> @@ -58,6 +58,24 @@
> open-source;
> priority = <200>;
> };
> +
> + /* Hardware I2C block cannot do more than 63 bytes per transfer,
> + * which would prevent reading from a SFP's EEPROM (256 byte).
> + */
> + i2c1: i2c {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpioa 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + };
> +
> + sfp: sfp {
> + compatible = "sff,sfp";
> + i2c-bus = <&i2c1>;
> + mod-def0-gpios = <&gpioa 28 GPIO_ACTIVE_LOW>;
> + los-gpios = <&gpioa 24 GPIO_ACTIVE_HIGH>;
> + tx-fault-gpios = <&gpioa 30 GPIO_ACTIVE_HIGH>;
> + tx-disable-gpios = <&gpioa 26 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &amac0 {
> @@ -210,6 +228,14 @@
> reg = <4>;
> };
>
> + port at 5 {
> + label = "sfp";
> + phy-mode = "sgmii";
> + reg = <5>;
> + sfp = <&sfp>;
> + managed = "in-band-status";
> + };
> +
> port at 8 {
> ethernet = <&amac2>;
> label = "cpu";
>
Looks good to me. Thanks!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
next prev parent reply other threads:[~2018-09-04 20:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 19:20 [PATCH v3 0/3] ARM: NSP updates to support switch interrupts/SFP Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-08-31 19:20 ` [PATCH v3 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-09-04 20:39 ` Ray Jui [this message]
2018-09-04 20:39 ` Ray Jui
2018-09-04 20:39 ` Ray Jui
2018-08-31 19:20 ` [PATCH v3 2/3] dt-bindings: net: dsa: Document B53 SRAB interrupts and registers Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-09-10 19:57 ` Rob Herring
2018-09-10 19:57 ` Rob Herring
2018-09-10 19:57 ` Rob Herring
2018-08-31 19:20 ` [PATCH v3 3/3] ARM: dts: NSP: Wire up switch interrupts Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-08-31 19:20 ` Florian Fainelli
2018-09-13 18:10 ` [PATCH v3 0/3] ARM: NSP updates to support switch interrupts/SFP Florian Fainelli
2018-09-13 18:10 ` Florian Fainelli
2018-09-13 18:10 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b987de-9229-4606-a972-650b3f486e19@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.