All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
To: Oak Zeng <Oak.Zeng-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Jay.Cornwall-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: Apply noretry setting for mmhub9.4
Date: Fri, 22 Nov 2019 18:21:17 -0500	[thread overview]
Message-ID: <68bce28c-6b9d-8626-b2e0-09d6f4b3bb05@amd.com> (raw)
In-Reply-To: <1574463347-27961-1-git-send-email-Oak.Zeng-5C7GfCeVMHo@public.gmane.org>

On 2019-11-22 5:55 p.m., Oak Zeng wrote:
> Config the translation retry behavior according to noretry
> kernel parameter
>
> Change-Id: I5b91ea77715137cf8cb84e258ccdfbb19c7a4ed1
> Signed-off-by: Oak Zeng <Oak.Zeng@amd.com>
> Suggested-by: Jay Cornwall <Jay.Cornwall@amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> index 753eea2..8599bfd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> @@ -314,7 +314,8 @@ static void mmhub_v9_4_setup_vmid_config(struct amdgpu_device *adev, int hubid)
>   				    adev->vm_manager.block_size - 9);
>   		/* Send no-retry XNACK on fault to suppress VM fault storm. */
>   		tmp = REG_SET_FIELD(tmp, VML2VC0_VM_CONTEXT1_CNTL,
> -				    RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, 0);
> +				    RETRY_PERMISSION_OR_INVALID_PAGE_FAULT,
> +				    !amdgpu_noretry);
>   		WREG32_SOC15_OFFSET(MMHUB, 0, mmVML2VC0_VM_CONTEXT1_CNTL,
>   				    hubid * MMHUB_INSTANCE_REGISTER_OFFSET + i,
>   				    tmp);
> @@ -905,4 +906,4 @@ static void mmhub_v9_4_query_ras_error_count(struct amdgpu_device *adev,
>   const struct amdgpu_mmhub_funcs mmhub_v9_4_funcs = {
>   	.ras_late_init = amdgpu_mmhub_ras_late_init,
>   	.query_ras_error_count = mmhub_v9_4_query_ras_error_count,
> -};
> \ No newline at end of file
> +};
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Felix Kuehling <felix.kuehling@amd.com>
To: Oak Zeng <Oak.Zeng@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Jay.Cornwall@amd.com
Subject: Re: [PATCH] drm/amdgpu: Apply noretry setting for mmhub9.4
Date: Fri, 22 Nov 2019 18:21:17 -0500	[thread overview]
Message-ID: <68bce28c-6b9d-8626-b2e0-09d6f4b3bb05@amd.com> (raw)
Message-ID: <20191122232117.c3o5spnS2SwN_IQKfUvRHYYWHOvZWBM3WyrBQ2SUSUc@z> (raw)
In-Reply-To: <1574463347-27961-1-git-send-email-Oak.Zeng@amd.com>

On 2019-11-22 5:55 p.m., Oak Zeng wrote:
> Config the translation retry behavior according to noretry
> kernel parameter
>
> Change-Id: I5b91ea77715137cf8cb84e258ccdfbb19c7a4ed1
> Signed-off-by: Oak Zeng <Oak.Zeng@amd.com>
> Suggested-by: Jay Cornwall <Jay.Cornwall@amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> index 753eea2..8599bfd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c
> @@ -314,7 +314,8 @@ static void mmhub_v9_4_setup_vmid_config(struct amdgpu_device *adev, int hubid)
>   				    adev->vm_manager.block_size - 9);
>   		/* Send no-retry XNACK on fault to suppress VM fault storm. */
>   		tmp = REG_SET_FIELD(tmp, VML2VC0_VM_CONTEXT1_CNTL,
> -				    RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, 0);
> +				    RETRY_PERMISSION_OR_INVALID_PAGE_FAULT,
> +				    !amdgpu_noretry);
>   		WREG32_SOC15_OFFSET(MMHUB, 0, mmVML2VC0_VM_CONTEXT1_CNTL,
>   				    hubid * MMHUB_INSTANCE_REGISTER_OFFSET + i,
>   				    tmp);
> @@ -905,4 +906,4 @@ static void mmhub_v9_4_query_ras_error_count(struct amdgpu_device *adev,
>   const struct amdgpu_mmhub_funcs mmhub_v9_4_funcs = {
>   	.ras_late_init = amdgpu_mmhub_ras_late_init,
>   	.query_ras_error_count = mmhub_v9_4_query_ras_error_count,
> -};
> \ No newline at end of file
> +};
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-11-22 23:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 22:55 [PATCH] drm/amdgpu: Apply noretry setting for mmhub9.4 Oak Zeng
2019-11-22 22:55 ` Oak Zeng
     [not found] ` <1574463347-27961-1-git-send-email-Oak.Zeng-5C7GfCeVMHo@public.gmane.org>
2019-11-22 23:21   ` Felix Kuehling [this message]
2019-11-22 23:21     ` Felix Kuehling
     [not found]     ` <68bce28c-6b9d-8626-b2e0-09d6f4b3bb05-5C7GfCeVMHo@public.gmane.org>
2019-11-26 12:07       ` Christian König
2019-11-26 12:07         ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68bce28c-6b9d-8626-b2e0-09d6f4b3bb05@amd.com \
    --to=felix.kuehling-5c7gfcevmho@public.gmane.org \
    --cc=Jay.Cornwall-5C7GfCeVMHo@public.gmane.org \
    --cc=Oak.Zeng-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.