From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
mikey@neuling.org, vaibhav@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, malat@debian.org,
felix@linux.vnet.ibm.com, pombredanne@nexb.com,
sukadev@linux.vnet.ibm.com, npiggin@gmail.com,
gregkh@linuxfoundation.org, arnd@arndb.de,
fbarrat@linux.vnet.ibm.com, corbet@lwn.net,
"Alastair D'Silva" <alastair@d-silva.org>
Subject: Re: [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9
Date: Tue, 17 Apr 2018 14:09:41 +1000 [thread overview]
Message-ID: <68ec9aff-b523-dd30-cd73-42dc8c792ba1@au1.ibm.com> (raw)
In-Reply-To: <20180417020950.21446-2-alastair@au1.ibm.com>
On 17/04/18 12:09, Alastair D'Silva wrote:
> diff --git a/arch/powerpc/include/asm/switch_to.h b/arch/powerpc/include/asm/switch_to.h
> index be8c9fa23983..5b03d8a82409 100644
> --- a/arch/powerpc/include/asm/switch_to.h
> +++ b/arch/powerpc/include/asm/switch_to.h
> @@ -94,6 +94,5 @@ static inline void clear_task_ebb(struct task_struct *t)
> extern int set_thread_uses_vas(void);
>
> extern int set_thread_tidr(struct task_struct *t);
> -extern void clear_thread_tidr(struct task_struct *t);
This hunk looks like it really belongs in patch 3.
Apart from that, I'm not really familiar with the CPU features code but
nothing seems overly wrong...
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: "Alastair D'Silva" <alastair@au1.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
mikey@neuling.org, vaibhav@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, malat@debian.org,
felix@linux.vnet.ibm.com, pombredanne@nexb.com,
sukadev@linux.vnet.ibm.com, npiggin@gmail.com,
gregkh@linuxfoundation.org, arnd@arndb.de,
fbarrat@linux.vnet.ibm.com, corbet@lwn.net,
"Alastair D'Silva" <alastair@d-silva.org>
Subject: Re: [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9
Date: Tue, 17 Apr 2018 14:09:41 +1000 [thread overview]
Message-ID: <68ec9aff-b523-dd30-cd73-42dc8c792ba1@au1.ibm.com> (raw)
In-Reply-To: <20180417020950.21446-2-alastair@au1.ibm.com>
On 17/04/18 12:09, Alastair D'Silva wrote:
> diff --git a/arch/powerpc/include/asm/switch_to.h b/arch/powerpc/include/asm/switch_to.h
> index be8c9fa23983..5b03d8a82409 100644
> --- a/arch/powerpc/include/asm/switch_to.h
> +++ b/arch/powerpc/include/asm/switch_to.h
> @@ -94,6 +94,5 @@ static inline void clear_task_ebb(struct task_struct *t)
> extern int set_thread_uses_vas(void);
>
> extern int set_thread_tidr(struct task_struct *t);
> -extern void clear_thread_tidr(struct task_struct *t);
This hunk looks like it really belongs in patch 3.
Apart from that, I'm not really familiar with the CPU features code but
nothing seems overly wrong...
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-17 4:09 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 2:09 [PATCH 0/7] ocxl: Implement Power9 as_notify/wait for OpenCAPI Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 2:09 ` [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9 Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 4:09 ` Andrew Donnellan [this message]
2018-04-17 4:09 ` Andrew Donnellan
2018-04-17 2:09 ` [PATCH 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 4:21 ` Andrew Donnellan
2018-04-17 4:21 ` Andrew Donnellan
2018-04-17 5:31 ` Alastair D'Silva
2018-04-17 5:31 ` Alastair D'Silva
2018-04-17 2:09 ` [PATCH 3/7] powerpc: use task_pid_nr() for TID allocation Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 2:09 ` [PATCH 4/7] ocxl: Rename pnv_ocxl_spa_remove_pe to clarify it's action Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 5:37 ` Andrew Donnellan
2018-04-17 5:37 ` Andrew Donnellan
2018-04-17 2:09 ` [PATCH 5/7] ocxl: Expose the thread_id needed for wait on p9 Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 2:09 ` [PATCH 6/7] ocxl: Add an IOCTL so userspace knows which platform the kernel requires Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 2:09 ` [PATCH 7/7] ocxl: Document new OCXL IOCTLs Alastair D'Silva
2018-04-17 2:09 ` Alastair D'Silva
2018-04-17 3:45 ` Andrew Donnellan
2018-04-17 3:45 ` Andrew Donnellan
2018-04-18 1:08 ` [PATCH v2 0/7] ocxl: Implement Power9 as_notify/wait for OpenCAPI Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-18 1:08 ` [PATCH v2 1/7] powerpc: Add TIDR CPU feature for Power9 Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-18 7:03 ` Andrew Donnellan
2018-04-18 7:03 ` Andrew Donnellan
2018-05-07 17:17 ` Frederic Barrat
2018-05-07 17:17 ` Frederic Barrat
2018-05-08 3:13 ` Alastair D'Silva
2018-05-08 3:13 ` Alastair D'Silva
2018-04-18 1:08 ` [PATCH v2 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-18 7:13 ` Andrew Donnellan
2018-04-18 7:13 ` Andrew Donnellan
2018-05-07 17:19 ` Frederic Barrat
2018-05-07 17:19 ` Frederic Barrat
2018-04-18 1:08 ` [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-20 8:43 ` Andrew Donnellan
2018-04-20 8:43 ` Andrew Donnellan
2018-04-24 21:12 ` Sukadev Bhattiprolu
2018-04-24 21:12 ` Sukadev Bhattiprolu
2018-04-26 9:25 ` Andrew Donnellan
2018-04-26 9:25 ` Andrew Donnellan
2018-05-07 17:37 ` Frederic Barrat
2018-05-07 17:37 ` Frederic Barrat
2018-05-08 0:40 ` Alastair D'Silva
2018-05-08 0:40 ` Alastair D'Silva
2018-04-18 1:08 ` [PATCH v2 4/7] ocxl: Rename pnv_ocxl_spa_remove_pe to clarify it's action Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-05-07 17:38 ` Frederic Barrat
2018-05-07 17:38 ` Frederic Barrat
2018-04-18 1:08 ` [PATCH v2 5/7] ocxl: Expose the thread_id needed for wait on p9 Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-23 7:16 ` Andrew Donnellan
2018-04-23 7:16 ` Andrew Donnellan
2018-05-07 18:08 ` Frederic Barrat
2018-05-07 18:08 ` Frederic Barrat
2018-04-18 1:08 ` [PATCH v2 6/7] ocxl: Add an IOCTL so userspace knows what CPU features are available Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-20 7:25 ` Andrew Donnellan
2018-04-20 7:25 ` Andrew Donnellan
2018-05-07 18:14 ` Frederic Barrat
2018-05-07 18:14 ` Frederic Barrat
2018-05-08 0:41 ` Alastair D'Silva
2018-05-08 0:41 ` Alastair D'Silva
2018-05-08 3:50 ` Nicholas Piggin
2018-05-08 3:50 ` Nicholas Piggin
2018-05-08 3:54 ` Alastair D'Silva
2018-05-08 3:54 ` Alastair D'Silva
2018-04-18 1:08 ` [PATCH v2 7/7] ocxl: Document new OCXL IOCTLs Alastair D'Silva
2018-04-18 1:08 ` Alastair D'Silva
2018-04-18 7:29 ` Andrew Donnellan
2018-04-18 7:29 ` Andrew Donnellan
2018-05-07 18:15 ` Frederic Barrat
2018-05-07 18:15 ` Frederic Barrat
2018-05-09 0:42 ` [PATCH v3 0/7] ocxl: Implement Power9 as_notify/wait for OpenCAPI Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 0:42 ` [PATCH v3 1/7] powerpc: Add TIDR CPU feature for POWER9 Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 0:42 ` [PATCH v3 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 0:42 ` [PATCH v3 3/7] powerpc: use task_pid_nr() for TID allocation Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 0:42 ` [PATCH v3 4/7] ocxl: Rename pnv_ocxl_spa_remove_pe to clarify it's action Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 0:42 ` [PATCH v3 5/7] ocxl: Expose the thread_id needed for wait on POWER9 Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-11 5:01 ` Michael Ellerman
2018-05-11 5:01 ` Michael Ellerman
2018-05-09 0:42 ` [PATCH v3 6/7] ocxl: Add an IOCTL so userspace knows what OCXL features are available Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 0:42 ` [PATCH v3 7/7] ocxl: Document new OCXL IOCTLs Alastair D'Silva
2018-05-09 0:42 ` Alastair D'Silva
2018-05-09 5:34 ` [PATCH v4 0/7] ocxl: Implement Power9 as_notify/wait for OpenCAPI Alastair D'Silva
2018-05-09 5:34 ` Alastair D'Silva
2018-05-09 5:35 ` [PATCH v4 1/7] powerpc: Add TIDR CPU feature for POWER9 Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
2018-05-09 5:35 ` [PATCH v4 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
2018-05-09 5:35 ` [PATCH v4 3/7] powerpc: use task_pid_nr() for TID allocation Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
2018-05-09 5:35 ` [PATCH v4 4/7] ocxl: Rename pnv_ocxl_spa_remove_pe to clarify it's action Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
2018-05-09 5:35 ` [PATCH v4 5/7] ocxl: Expose the thread_id needed for wait on POWER9 Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
2018-05-09 5:35 ` [PATCH v4 6/7] ocxl: Add an IOCTL so userspace knows what OCXL features are available Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
2018-05-11 5:20 ` Michael Ellerman
2018-05-11 5:20 ` Michael Ellerman
2018-05-11 5:20 ` Michael Ellerman
2018-05-09 5:35 ` [PATCH v4 7/7] ocxl: Document new OCXL IOCTLs Alastair D'Silva
2018-05-09 5:35 ` Alastair D'Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ec9aff-b523-dd30-cd73-42dc8c792ba1@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=alastair@au1.ibm.com \
--cc=alastair@d-silva.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=felix@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
--cc=mikey@neuling.org \
--cc=npiggin@gmail.com \
--cc=pombredanne@nexb.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.