All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/i915_blt: Equalize pitch and aux-ccs for full resolve
@ 2022-10-20  6:53 Zbigniew Kempczyński
  2022-10-20  7:53 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/i915_blt: Equalize pitch and aux-ccs for full resolve (rev2) Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Zbigniew Kempczyński @ 2022-10-20  6:53 UTC (permalink / raw)
  To: igt-dev

According to documentation and hw team suggestion use source pitch
and aux-ccs in destination object when inplace decompression is
performed (full-resolve operation).

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Karolina Drobnik <karolina.drobnik@intel.com>

---
v2: group assignments in if/else
---
 lib/i915/i915_blt.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 8d46e51fb7..a886c1d72d 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -317,8 +317,14 @@ static void fill_data(struct gen12_block_copy_data *data,
 	data->dw00.special_mode = __special_mode(blt);
 	data->dw00.length = extended_command ? 20 : 10;
 
-	data->dw01.dst_pitch = blt->dst.pitch - 1;
-	data->dw01.dst_aux_mode = __aux_mode(&blt->dst);
+	if (__special_mode(blt) == SM_FULL_RESOLVE) {
+		data->dw01.dst_pitch = blt->src.pitch - 1;
+		data->dw01.dst_aux_mode = __aux_mode(&blt->src);
+	} else {
+		data->dw01.dst_pitch = blt->dst.pitch - 1;
+		data->dw01.dst_aux_mode = __aux_mode(&blt->dst);
+	}
+
 	data->dw01.dst_mocs = blt->dst.mocs;
 	data->dw01.dst_compression = blt->dst.compression;
 	data->dw01.dst_tiling = __block_tiling(blt->dst.tiling);
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/i915_blt: Equalize pitch and aux-ccs for full resolve
@ 2022-10-20  6:47 Zbigniew Kempczyński
  0 siblings, 0 replies; 11+ messages in thread
From: Zbigniew Kempczyński @ 2022-10-20  6:47 UTC (permalink / raw)
  To: igt-dev

According to documentation and hw team suggestion use source pitch
and aux-ccs in destination object when inplace decompression is
performed (full-resolve operation).

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Karolina Drobnik <karolina.drobnik@intel.com>
---
 lib/i915/i915_blt.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 8d46e51fb7..a8615f0a1d 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -317,8 +317,15 @@ static void fill_data(struct gen12_block_copy_data *data,
 	data->dw00.special_mode = __special_mode(blt);
 	data->dw00.length = extended_command ? 20 : 10;
 
-	data->dw01.dst_pitch = blt->dst.pitch - 1;
-	data->dw01.dst_aux_mode = __aux_mode(&blt->dst);
+	if (__special_mode(blt) == SM_FULL_RESOLVE)
+		data->dw01.dst_pitch = blt->src.pitch - 1;
+	else
+		data->dw01.dst_pitch = blt->dst.pitch - 1;
+
+	if (__special_mode(blt) == SM_FULL_RESOLVE)
+		data->dw01.dst_aux_mode = __aux_mode(&blt->src);
+	else
+		data->dw01.dst_aux_mode = __aux_mode(&blt->dst);
 	data->dw01.dst_mocs = blt->dst.mocs;
 	data->dw01.dst_compression = blt->dst.compression;
 	data->dw01.dst_tiling = __block_tiling(blt->dst.tiling);
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-10-24  5:41 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20  6:53 [igt-dev] [PATCH i-g-t] lib/i915_blt: Equalize pitch and aux-ccs for full resolve Zbigniew Kempczyński
2022-10-20  7:53 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/i915_blt: Equalize pitch and aux-ccs for full resolve (rev2) Patchwork
2022-10-20  9:14 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/i915_blt: Equalize pitch and aux-ccs for full resolve (rev3) Patchwork
2022-10-20 11:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-20 11:26   ` Zbigniew Kempczyński
2022-10-20 18:42     ` Vudum, Lakshminarayana
2022-10-20 16:40 ` Patchwork
2022-10-20 18:38 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2022-10-21  9:28 ` [igt-dev] [PATCH i-g-t] lib/i915_blt: Equalize pitch and aux-ccs for full resolve Karolina Drobnik
2022-10-24  5:41   ` Zbigniew Kempczyński
  -- strict thread matches above, loose matches on Subject: below --
2022-10-20  6:47 Zbigniew Kempczyński

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.