All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>,
	"Singh, Aman Deep" <aman.deep.singh@intel.com>,
	"'dev@dpdk.org'" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Li, Xiaoyun" <xiaoyun.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process
Date: Thu, 29 Apr 2021 12:25:01 +0100	[thread overview]
Message-ID: <6936cb8f-baae-0554-7cd1-af448f8269bd@intel.com> (raw)
In-Reply-To: <63ae4695-9ffd-e854-b9d4-d6257b24768a@huawei.com>

On 4/29/2021 11:57 AM, Min Hu (Connor) wrote:
> Thanks Aman.
> 
> Hi, Thomas, Ferruh, any other comments about this patch?
> 

Hi Connor,

There is no outstanding comments, also the patch has review/test tags in place.

But the multi-process support may affect many operations, and assuming it is not
critical for this release, to prevent any unexpected side affects I am for
getting this patch early next release instead of this release.

This gives more time in next release to address any unexpected issue.

Thanks,
ferruh

> 在 2021/4/28 20:10, Singh, Aman Deep 写道:
>> This patch adds multi-process support for testpmd.
>>
>> The test cmd example as follows:
>>
>> the primary cmd:
>>
>> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \
>>
>> --rxq=4 --txq=4 --num-procs=2 --proc-id=0
>>
>> the secondary cmd:
>>
>> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \
>>
>> --rxq=4 --txq=4 --num-procs=2 --proc-id=1
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com <mailto:humin29@huawei.com>>
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com <mailto:oulijun@huawei.com>>
>>
>> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com <mailto:xiaoyun.li@intel.com>>
>>
>> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com
>> <mailto:ajit.khaparde@broadcom.com>>
>>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com
>> <mailto:ferruh.yigit@intel.com>>
>>
>> <snip>
>>
>> Acked-by: Aman Deep Singh <aman.deep.singh@intel.com
>> <mailto:aman.deep.singh@intel.com>>
>>
>> Tested-by: Aman Deep Singh <aman.deep.singh@intel.com
>> <mailto:aman.deep.singh@intel.com>>
>>


  reply	other threads:[~2021-04-29 11:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 12:10 [dpdk-dev] [PATCH v13] app/testpmd: support multi-process Singh, Aman Deep
2021-04-29 10:57 ` Min Hu (Connor)
2021-04-29 11:25   ` Ferruh Yigit [this message]
2021-04-29 11:34     ` Min Hu (Connor)
  -- strict thread matches above, loose matches on Subject: below --
2021-03-05  1:04 [dpdk-dev] [PATCH] " Lijun Ou
2021-04-22  1:18 ` [dpdk-dev] [PATCH v13] " Min Hu (Connor)
2021-06-08  8:42   ` Andrew Rybchenko
2021-06-08 10:22     ` Thomas Monjalon
2021-06-08 10:39       ` Andrew Rybchenko
2021-06-08 12:02         ` Thomas Monjalon
2021-06-08 12:36         ` Ferruh Yigit
2021-06-15 12:04     ` Min Hu (Connor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6936cb8f-baae-0554-7cd1-af448f8269bd@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=thomas@monjalon.net \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.