* [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE @ 2023-05-27 20:46 Bert Karwatzki 2023-05-30 5:10 ` Jakub Kicinski 2023-05-30 7:09 ` Simon Horman 0 siblings, 2 replies; 14+ messages in thread From: Bert Karwatzki @ 2023-05-27 20:46 UTC (permalink / raw) To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni Cc: elder, netdev, linux-arm-msm, linux-kernel commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE. From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001 From: Bert Karwatzki <spasswolf@web.de> Date: Sat, 27 May 2023 22:16:52 +0200 Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a replacment for the size of the removed struct ipa_status which had size = sizeof(__le32[8]). Signed-off-by: Bert Karwatzki <spasswolf@web.de> --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 2ee80ed140b7..afa1d56d9095 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -119,7 +119,7 @@ enum ipa_status_field_id { }; /* Size in bytes of an IPA packet status structure */ -#define IPA_STATUS_SIZE sizeof(__le32[4]) +#define IPA_STATUS_SIZE sizeof(__le32[8]) /* IPA status structure decoder; looks up field values for a structure */ static u32 ipa_status_extract(struct ipa *ipa, const void *data, -- 2.40.1 Bert Karwatzki ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-27 20:46 [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE Bert Karwatzki @ 2023-05-30 5:10 ` Jakub Kicinski 2023-05-30 7:09 ` Simon Horman 1 sibling, 0 replies; 14+ messages in thread From: Jakub Kicinski @ 2023-05-30 5:10 UTC (permalink / raw) To: Bert Karwatzki Cc: David S. Miller, Eric Dumazet, Paolo Abeni, elder, netdev, linux-arm-msm, linux-kernel On Sat, 27 May 2023 22:46:25 +0200 Bert Karwatzki wrote: > commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced > IPA_STATUS_SIZE as a replacement for the size of the removed struct > ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this > as IPA_STATUS_SIZE. > > From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki <spasswolf@web.de> > Date: Sat, 27 May 2023 22:16:52 +0200 > Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. > IPA_STATUS_SIZE > was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a > replacment for the size of the removed struct ipa_status which had > size = > sizeof(__le32[8]). The posting looks damage, could you try sending again (with git send-email maybe?) Before you do: - please make sure the change applies to: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ - add a correct fixes tag - fix issues pointed out by checkpatch --strict -- pw-bot: cr ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-27 20:46 [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE Bert Karwatzki 2023-05-30 5:10 ` Jakub Kicinski @ 2023-05-30 7:09 ` Simon Horman 2023-05-30 9:10 ` Bert Karwatzki 1 sibling, 1 reply; 14+ messages in thread From: Simon Horman @ 2023-05-30 7:09 UTC (permalink / raw) To: Bert Karwatzki Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, elder, netdev, linux-arm-msm, linux-kernel On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote: > commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced > IPA_STATUS_SIZE as a replacement for the size of the removed struct > ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this > as IPA_STATUS_SIZE. > > >From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki <spasswolf@web.de> > Date: Sat, 27 May 2023 22:16:52 +0200 > Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. > IPA_STATUS_SIZE > was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a > replacment for the size of the removed struct ipa_status which had > size = > sizeof(__le32[8]). > > Signed-off-by: Bert Karwatzki <spasswolf@web.de> Hi Bert, As well as the feedback provided by Jakub elsewhere in this thread I think it would be useful to CC the author of the above mentioned commit, Alex Elder <elder@linaro.org>. I have CCed him on this email. Please consider doing likewise when you post v2. FWIIW, I did take a look. And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long. > --- > drivers/net/ipa/ipa_endpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_endpoint.c > b/drivers/net/ipa/ipa_endpoint.c > index 2ee80ed140b7..afa1d56d9095 100644 > --- a/drivers/net/ipa/ipa_endpoint.c > +++ b/drivers/net/ipa/ipa_endpoint.c > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > }; > > /* Size in bytes of an IPA packet status structure */ > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > /* IPA status structure decoder; looks up field values for a structure > */ > static u32 ipa_status_extract(struct ipa *ipa, const void *data, > -- > 2.40.1 > > Bert Karwatzki ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 7:09 ` Simon Horman @ 2023-05-30 9:10 ` Bert Karwatzki 2023-05-30 12:29 ` Alex Elder 0 siblings, 1 reply; 14+ messages in thread From: Bert Karwatzki @ 2023-05-30 9:10 UTC (permalink / raw) To: Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, elder, netdev, linux-arm-msm, linux-kernel Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman: > On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote: > > commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced > > IPA_STATUS_SIZE as a replacement for the size of the removed struct > > ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this > > as IPA_STATUS_SIZE. > > > > > From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001 > > From: Bert Karwatzki <spasswolf@web.de> > > Date: Sat, 27 May 2023 22:16:52 +0200 > > Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. > > IPA_STATUS_SIZE > > was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a > > replacment for the size of the removed struct ipa_status which had > > size = > > sizeof(__le32[8]). > > > > Signed-off-by: Bert Karwatzki <spasswolf@web.de> > > Hi Bert, > > As well as the feedback provided by Jakub elsewhere in this > thread I think it would be useful to CC the author of the above mentioned > commit, Alex Elder <elder@linaro.org>. I have CCed him on this email. > Please consider doing likewise when you post v2. > > FWIIW, I did take a look. > And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long. > > > --- > > drivers/net/ipa/ipa_endpoint.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ipa/ipa_endpoint.c > > b/drivers/net/ipa/ipa_endpoint.c > > index 2ee80ed140b7..afa1d56d9095 100644 > > --- a/drivers/net/ipa/ipa_endpoint.c > > +++ b/drivers/net/ipa/ipa_endpoint.c > > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > > }; > > > > /* Size in bytes of an IPA packet status structure */ > > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > > > /* IPA status structure decoder; looks up field values for a structure > > */ > > static u32 ipa_status_extract(struct ipa *ipa, const void *data, > > -- > > 2.40.1 > > > > Bert Karwatzki Here is v2 of the patch, the first one was garbled by the linebreak setting of evolution. From: Bert Karwatzki <spasswolf@web.de> Date: Tue, 30 May 2023 10:55:55 +0200 Subject: [PATCH] IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status of size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. Signed-off-by: Bert Karwatzki <spasswolf@web.de> --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 2ee80ed140b7..afa1d56d9095 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -119,7 +119,7 @@ enum ipa_status_field_id { }; /* Size in bytes of an IPA packet status structure */ -#define IPA_STATUS_SIZE sizeof(__le32[4]) +#define IPA_STATUS_SIZE sizeof(__le32[8]) /* IPA status structure decoder; looks up field values for a structure */ static u32 ipa_status_extract(struct ipa *ipa, const void *data, -- 2.40.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 9:10 ` Bert Karwatzki @ 2023-05-30 12:29 ` Alex Elder 2023-05-30 18:36 ` Bert Karwatzki 0 siblings, 1 reply; 14+ messages in thread From: Alex Elder @ 2023-05-30 12:29 UTC (permalink / raw) To: Bert Karwatzki, Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-arm-msm, linux-kernel On 5/30/23 4:10 AM, Bert Karwatzki wrote: > Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman: >> On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote: >>> commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced >>> IPA_STATUS_SIZE as a replacement for the size of the removed struct >>> ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this >>> as IPA_STATUS_SIZE. This is better, however it really isn't done in a way that's appropriate for a Linux kernel patch. I will gladly help you get it right if you have the patience for that. But I'm not going to say anything yet--until you say you want me to help you do this. If you prefer, I can submit the patch for you. The reason this is important is your commit is permanent, and just like code, commit messages are best if kept consistent and readable. I also am offering to help you understand so you avoid any trouble next time you want to send a kernel patch. Let me know what you prefer. -Alex >>> >>>> From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001 >>> From: Bert Karwatzki <spasswolf@web.de> >>> Date: Sat, 27 May 2023 22:16:52 +0200 >>> Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. >>> IPA_STATUS_SIZE >>> was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a >>> replacment for the size of the removed struct ipa_status which had >>> size = >>> sizeof(__le32[8]). >>> >>> Signed-off-by: Bert Karwatzki <spasswolf@web.de> >> >> Hi Bert, >> >> As well as the feedback provided by Jakub elsewhere in this >> thread I think it would be useful to CC the author of the above mentioned >> commit, Alex Elder <elder@linaro.org>. I have CCed him on this email. >> Please consider doing likewise when you post v2. >> >> FWIIW, I did take a look. >> And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long. >> >>> --- >>> drivers/net/ipa/ipa_endpoint.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ipa/ipa_endpoint.c >>> b/drivers/net/ipa/ipa_endpoint.c >>> index 2ee80ed140b7..afa1d56d9095 100644 >>> --- a/drivers/net/ipa/ipa_endpoint.c >>> +++ b/drivers/net/ipa/ipa_endpoint.c >>> @@ -119,7 +119,7 @@ enum ipa_status_field_id { >>> }; >>> >>> /* Size in bytes of an IPA packet status structure */ >>> -#define IPA_STATUS_SIZE sizeof(__le32[4]) >>> +#define IPA_STATUS_SIZE sizeof(__le32[8]) >>> >>> /* IPA status structure decoder; looks up field values for a structure >>> */ >>> static u32 ipa_status_extract(struct ipa *ipa, const void *data, >>> -- >>> 2.40.1 >>> >>> Bert Karwatzki > > Here is v2 of the patch, the first one was garbled by the linebreak setting of > evolution. > > From: Bert Karwatzki <spasswolf@web.de> > Date: Tue, 30 May 2023 10:55:55 +0200 > Subject: [PATCH] IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a > replacement for the size of the removed struct ipa_status of size > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. > > Signed-off-by: Bert Karwatzki <spasswolf@web.de> > --- > drivers/net/ipa/ipa_endpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c > index 2ee80ed140b7..afa1d56d9095 100644 > --- a/drivers/net/ipa/ipa_endpoint.c > +++ b/drivers/net/ipa/ipa_endpoint.c > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > }; > > /* Size in bytes of an IPA packet status structure */ > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > /* IPA status structure decoder; looks up field values for a structure */ > static u32 ipa_status_extract(struct ipa *ipa, const void *data, ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 12:29 ` Alex Elder @ 2023-05-30 18:36 ` Bert Karwatzki 2023-05-30 19:04 ` Alex Elder 0 siblings, 1 reply; 14+ messages in thread From: Bert Karwatzki @ 2023-05-30 18:36 UTC (permalink / raw) To: Alex Elder, Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-arm-msm, linux-kernel Am Dienstag, dem 30.05.2023 um 07:29 -0500 schrieb Alex Elder: > On 5/30/23 4:10 AM, Bert Karwatzki wrote: > > Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman: > > > On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote: > > > > commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced > > > > IPA_STATUS_SIZE as a replacement for the size of the removed struct > > > > ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this > > > > as IPA_STATUS_SIZE. > > This is better, however it really isn't done in a way that's > appropriate for a Linux kernel patch. I will gladly help you > get it right if you have the patience for that. But I'm not > going to say anything yet--until you say you want me to help > you do this. If you prefer, I can submit the patch for you. > > The reason this is important is your commit is permanent, and > just like code, commit messages are best if kept consistent > and readable. I also am offering to help you understand so > you avoid any trouble next time you want to send a kernel patch. > > Let me know what you prefer. > > -Alex > > > > So here's v3 of the patch, done (I hope) in a way that is more standard conforming. From e0dc802b5f6f41c0a388c7281aabe077a4e3c5a2 Mon Sep 17 00:00:00 2001 From: Bert Karwatzki <spasswolf@web.de> Date: Tue, 30 May 2023 20:23:29 +0200 Subject: [PATCH] net/ipa: Use correct value for IPA_STATUS_SIZE IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. Signed-off-by: Bert Karwatzki <spasswolf@web.de> --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 2ee80ed140b7..afa1d56d9095 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -119,7 +119,7 @@ enum ipa_status_field_id { }; /* Size in bytes of an IPA packet status structure */ -#define IPA_STATUS_SIZE sizeof(__le32[4]) +#define IPA_STATUS_SIZE sizeof(__le32[8]) /* IPA status structure decoder; looks up field values for a structure */ static u32 ipa_status_extract(struct ipa *ipa, const void *data, -- 2.40.1 Bert Karwatzki ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 18:36 ` Bert Karwatzki @ 2023-05-30 19:04 ` Alex Elder 2023-05-30 23:25 ` [PATCH net v2] " Bert Karwatzki 0 siblings, 1 reply; 14+ messages in thread From: Alex Elder @ 2023-05-30 19:04 UTC (permalink / raw) To: Bert Karwatzki, Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-arm-msm, linux-kernel On 5/30/23 1:36 PM, Bert Karwatzki wrote: > Am Dienstag, dem 30.05.2023 um 07:29 -0500 schrieb Alex Elder: >> On 5/30/23 4:10 AM, Bert Karwatzki wrote: >>> Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman: >>>> On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote: >>>>> commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced >>>>> IPA_STATUS_SIZE as a replacement for the size of the removed struct >>>>> ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this >>>>> as IPA_STATUS_SIZE. >> >> This is better, however it really isn't done in a way that's >> appropriate for a Linux kernel patch. I will gladly help you >> get it right if you have the patience for that. But I'm not >> going to say anything yet--until you say you want me to help >> you do this. If you prefer, I can submit the patch for you. >> >> The reason this is important is your commit is permanent, and >> just like code, commit messages are best if kept consistent >> and readable. I also am offering to help you understand so >> you avoid any trouble next time you want to send a kernel patch. >> >> Let me know what you prefer. >> >> -Alex >> >>>> > > So here's v3 of the patch, done (I hope) in a way that is more standard > conforming. > > From e0dc802b5f6f41c0a388c7281aabe077a4e3c5a2 Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki <spasswolf@web.de> > Date: Tue, 30 May 2023 20:23:29 +0200 > Subject: [PATCH] net/ipa: Use correct value for IPA_STATUS_SIZE > > IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement > for the size of the removed struct ipa_status which had size > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. > > Signed-off-by: Bert Karwatzki <spasswolf@web.de> This is better, but there are a few more things to do differently. - When re-submitting a patch, please indicate a (new) version in the subject line. Since you haven't been doing that, it should be sufficient to just use "version 2", something like this: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE - Add a "Fixes" tag above your "Signed-off-by:" line: Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") - Do not send information above the patch in the e-mail. An easy way to get it right is to use "git send-email". For example: - git format-patch -1 - Edit 0001-*.patch, adding lines like this below the "From:" line: To: davem@davemloft.net To: edumazet@google.com To: kuba@kernel.org To: pabeni@redhat.com Cc: elder@kernel.org Cc: netdev@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org - Run this: git send-email --dry-run 0001-*.patch to try to catch any errors - Finally, run this: git send-email 0001-*.patch to actually send the patch. This will require a password. Even if you don't use "git send-email", just let the e-mail itself indicate the "From:" and "Subject:" lines. And have the content of the e-mail be the patch itself. I hope this helps. -Alex > --- > drivers/net/ipa/ipa_endpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c > index 2ee80ed140b7..afa1d56d9095 100644 > --- a/drivers/net/ipa/ipa_endpoint.c > +++ b/drivers/net/ipa/ipa_endpoint.c > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > }; > > /* Size in bytes of an IPA packet status structure */ > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > /* IPA status structure decoder; looks up field values for a structure */ > static u32 ipa_status_extract(struct ipa *ipa, const void *data, ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 19:04 ` Alex Elder @ 2023-05-30 23:25 ` Bert Karwatzki 2023-05-30 23:43 ` Alex Elder 0 siblings, 1 reply; 14+ messages in thread From: Bert Karwatzki @ 2023-05-30 23:25 UTC (permalink / raw) To: Alex Elder, Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-arm-msm, linux-kernel From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001 From: Bert Karwatzki <spasswolf@web.de> To: davem@davemloft.net To: edumazet@google.com To: kuba@kernel.org To: pabeni@redhat.com Cc: elder@kernel.org Cc: netdev@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Date: Wed, 31 May 2023 00:16:33 +0200 Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") Signed-off-by: Bert Karwatzki <spasswolf@web.de> --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 2ee80ed140b7..afa1d56d9095 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -119,7 +119,7 @@ enum ipa_status_field_id { }; /* Size in bytes of an IPA packet status structure */ -#define IPA_STATUS_SIZE sizeof(__le32[4]) +#define IPA_STATUS_SIZE sizeof(__le32[8]) /* IPA status structure decoder; looks up field values for a structure */ static u32 ipa_status_extract(struct ipa *ipa, const void *data, -- 2.40.1 As I'm sure that git send-email didn't work (probably due to sendmail/exim configuration issues), I'm sending this from evolution again. Bert Karwatzki ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 23:25 ` [PATCH net v2] " Bert Karwatzki @ 2023-05-30 23:43 ` Alex Elder 2023-05-31 0:33 ` Jakub Kicinski 2023-05-31 1:57 ` Alex Elder 0 siblings, 2 replies; 14+ messages in thread From: Alex Elder @ 2023-05-30 23:43 UTC (permalink / raw) To: Bert Karwatzki, Alex Elder, Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-arm-msm, linux-kernel On 5/30/23 6:25 PM, Bert Karwatzki wrote: > From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki <spasswolf@web.de> > To: davem@davemloft.net > To: edumazet@google.com > To: kuba@kernel.org > To: pabeni@redhat.com > Cc: elder@kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Date: Wed, 31 May 2023 00:16:33 +0200 > Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE > > IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement > for the size of the removed struct ipa_status which had size > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. If the network maintainers can deal with your patch, I'm OK with it. David et al if you want something else, please say so. Reviewed-by: Alex Elder <elder@linaro.org> > Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") > Signed-off-by: Bert Karwatzki <spasswolf@web.de> > --- > drivers/net/ipa/ipa_endpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c > index 2ee80ed140b7..afa1d56d9095 100644 > --- a/drivers/net/ipa/ipa_endpoint.c > +++ b/drivers/net/ipa/ipa_endpoint.c > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > }; > > /* Size in bytes of an IPA packet status structure */ > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > /* IPA status structure decoder; looks up field values for a structure */ > static u32 ipa_status_extract(struct ipa *ipa, const void *data, ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 23:43 ` Alex Elder @ 2023-05-31 0:33 ` Jakub Kicinski 2023-05-31 1:57 ` Alex Elder 1 sibling, 0 replies; 14+ messages in thread From: Jakub Kicinski @ 2023-05-31 0:33 UTC (permalink / raw) To: Alex Elder Cc: Bert Karwatzki, Alex Elder, Simon Horman, David S. Miller, Eric Dumazet, Paolo Abeni, netdev, linux-arm-msm, linux-kernel On Tue, 30 May 2023 18:43:54 -0500 Alex Elder wrote: > > IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement > > for the size of the removed struct ipa_status which had size > > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. > > If the network maintainers can deal with your patch, I'm > OK with it. David et al if you want something else, please > say so. It's not correctly formatted. There are headers in the email body. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE 2023-05-30 23:43 ` Alex Elder 2023-05-31 0:33 ` Jakub Kicinski @ 2023-05-31 1:57 ` Alex Elder 2023-05-31 10:36 ` [PATCH net v3] net: ipa: Use " Bert Karwatzki 1 sibling, 1 reply; 14+ messages in thread From: Alex Elder @ 2023-05-31 1:57 UTC (permalink / raw) To: Alex Elder, Bert Karwatzki, Simon Horman Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-arm-msm, linux-kernel On 5/30/23 6:43 PM, Alex Elder wrote: > On 5/30/23 6:25 PM, Bert Karwatzki wrote: >> From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001 >> From: Bert Karwatzki <spasswolf@web.de> >> To: davem@davemloft.net >> To: edumazet@google.com >> To: kuba@kernel.org >> To: pabeni@redhat.com >> Cc: elder@kernel.org >> Cc: netdev@vger.kernel.org >> Cc: linux-arm-msm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Date: Wed, 31 May 2023 00:16:33 +0200 >> Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE >> >> IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement >> for the size of the removed struct ipa_status which had size >> sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. > > If the network maintainers can deal with your patch, I'm > OK with it. David et al if you want something else, please > say so. OK, Jakub has spoken... Bert, I tried before to explain what you needed to do, but it's still not quite right. Please contact me privately and we'll work out how to get this submitted in the proper format. -Alex > Reviewed-by: Alex Elder <elder@linaro.org> > >> Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") >> Signed-off-by: Bert Karwatzki <spasswolf@web.de> >> --- >> drivers/net/ipa/ipa_endpoint.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ipa/ipa_endpoint.c >> b/drivers/net/ipa/ipa_endpoint.c >> index 2ee80ed140b7..afa1d56d9095 100644 >> --- a/drivers/net/ipa/ipa_endpoint.c >> +++ b/drivers/net/ipa/ipa_endpoint.c >> @@ -119,7 +119,7 @@ enum ipa_status_field_id { >> }; >> /* Size in bytes of an IPA packet status structure */ >> -#define IPA_STATUS_SIZE sizeof(__le32[4]) >> +#define IPA_STATUS_SIZE sizeof(__le32[8]) >> /* IPA status structure decoder; looks up field values for a >> structure */ >> static u32 ipa_status_extract(struct ipa *ipa, const void *data, > ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE 2023-05-31 1:57 ` Alex Elder @ 2023-05-31 10:36 ` Bert Karwatzki 2023-05-31 22:07 ` Simon Horman 2023-06-01 11:40 ` patchwork-bot+netdevbpf 0 siblings, 2 replies; 14+ messages in thread From: Bert Karwatzki @ 2023-05-31 10:36 UTC (permalink / raw) To: davem, edumazet, kuba, pabeni Cc: Bert Karwatzki, elder, netdev, linux-arm-msm, linux-kernel IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") Signed-off-by: Bert Karwatzki <spasswolf@web.de> --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 2ee80ed140b7..afa1d56d9095 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -119,7 +119,7 @@ enum ipa_status_field_id { }; /* Size in bytes of an IPA packet status structure */ -#define IPA_STATUS_SIZE sizeof(__le32[4]) +#define IPA_STATUS_SIZE sizeof(__le32[8]) /* IPA status structure decoder; looks up field values for a structure */ static u32 ipa_status_extract(struct ipa *ipa, const void *data, -- 2.40.1 As none of you seem to be in Europe, I'll do another attempt, this time with git send-email. Bert Karwatzki ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE 2023-05-31 10:36 ` [PATCH net v3] net: ipa: Use " Bert Karwatzki @ 2023-05-31 22:07 ` Simon Horman 2023-06-01 11:40 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 14+ messages in thread From: Simon Horman @ 2023-05-31 22:07 UTC (permalink / raw) To: Bert Karwatzki Cc: davem, edumazet, kuba, pabeni, elder, netdev, linux-arm-msm, linux-kernel On Wed, May 31, 2023 at 12:36:19PM +0200, Bert Karwatzki wrote: > IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement > for the size of the removed struct ipa_status which had size > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. > > Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") > Signed-off-by: Bert Karwatzki <spasswolf@web.de> > --- > drivers/net/ipa/ipa_endpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c > index 2ee80ed140b7..afa1d56d9095 100644 > --- a/drivers/net/ipa/ipa_endpoint.c > +++ b/drivers/net/ipa/ipa_endpoint.c > @@ -119,7 +119,7 @@ enum ipa_status_field_id { > }; > > /* Size in bytes of an IPA packet status structure */ > -#define IPA_STATUS_SIZE sizeof(__le32[4]) > +#define IPA_STATUS_SIZE sizeof(__le32[8]) > > /* IPA status structure decoder; looks up field values for a structure */ > static u32 ipa_status_extract(struct ipa *ipa, const void *data, > -- > 2.40.1 > > As none of you seem to be in Europe, I'll do another attempt, this time > with git send-email. This looks good to me. Reviewed-by: Simon Horman <simon.horman@corigine.com> (somewhere in Europe) ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE 2023-05-31 10:36 ` [PATCH net v3] net: ipa: Use " Bert Karwatzki 2023-05-31 22:07 ` Simon Horman @ 2023-06-01 11:40 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 14+ messages in thread From: patchwork-bot+netdevbpf @ 2023-06-01 11:40 UTC (permalink / raw) To: Bert Karwatzki Cc: davem, edumazet, kuba, pabeni, elder, netdev, linux-arm-msm, linux-kernel Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Wed, 31 May 2023 12:36:19 +0200 you wrote: > IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement > for the size of the removed struct ipa_status which had size > sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE. > > Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)") > Signed-off-by: Bert Karwatzki <spasswolf@web.de> > > [...] Here is the summary with links: - [net,v3] net: ipa: Use correct value for IPA_STATUS_SIZE https://git.kernel.org/netdev/net/c/be7f8012a513 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-06-01 11:40 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-27 20:46 [PATCH net] net: ipa: Use the correct value for IPA_STATUS_SIZE Bert Karwatzki 2023-05-30 5:10 ` Jakub Kicinski 2023-05-30 7:09 ` Simon Horman 2023-05-30 9:10 ` Bert Karwatzki 2023-05-30 12:29 ` Alex Elder 2023-05-30 18:36 ` Bert Karwatzki 2023-05-30 19:04 ` Alex Elder 2023-05-30 23:25 ` [PATCH net v2] " Bert Karwatzki 2023-05-30 23:43 ` Alex Elder 2023-05-31 0:33 ` Jakub Kicinski 2023-05-31 1:57 ` Alex Elder 2023-05-31 10:36 ` [PATCH net v3] net: ipa: Use " Bert Karwatzki 2023-05-31 22:07 ` Simon Horman 2023-06-01 11:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.