From: David Ahern <dsahern@gmail.com>
To: Christian Brauner <christian@brauner.io>,
David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jbenc@redhat.com,
stephen@networkplumber.org
Subject: Re: [PATCH net-next 12/20] rtnetlink: Update ipmr_rtm_dumplink for strict data checking
Date: Sun, 7 Oct 2018 19:32:49 -0600 [thread overview]
Message-ID: <69539a4e-be1e-5222-a022-771783acd100@gmail.com> (raw)
In-Reply-To: <20181007104010.pb5qaatg2ydbutjl@brauner.io>
On 10/7/18 4:40 AM, Christian Brauner wrote:
>> @@ -2718,6 +2743,13 @@ static int ipmr_rtm_dumplink(struct sk_buff *skb, struct netlink_callback *cb)
>> unsigned int e = 0, s_e;
>> struct mr_table *mrt;
>>
>> + if (cb->strict_check) {
>> + int err = ipmr_valid_dumplink(cb->nlh, cb->extack);
>> +
>> + if (err)
>> + return err;
>
> Nit: can we remove the unnecessary \n, please.
Coding standards dictate a newline between declarations and code. And
that is my preference too.
next prev parent reply other threads:[~2018-10-08 8:42 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 21:33 [PATCH net-next 00/20] rtnetlink: Add support for rigid checking of data in dump request David Ahern
2018-10-04 21:33 ` [PATCH net-next 01/20] netlink: Pass extack to dump handlers David Ahern
2018-10-05 17:41 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 02/20] netlink: Add extack message to nlmsg_parse for invalid header length David Ahern
2018-10-05 17:41 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 03/20] net: Add extack to nlmsg_parse David Ahern
2018-10-05 17:39 ` Christian Brauner
2018-10-05 18:42 ` David Ahern
2018-10-04 21:33 ` [PATCH net-next 04/20] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs David Ahern
2018-10-04 21:33 ` [PATCH net-next 05/20] netlink: Add new socket option to enable strict checking on dumps David Ahern
2018-10-05 17:36 ` Christian Brauner
2018-10-05 18:43 ` David Ahern
2018-10-05 18:45 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 06/20] net/ipv4: Update inet_dump_ifaddr for strict data checking David Ahern
2018-10-05 18:02 ` Christian Brauner
2018-10-05 18:48 ` David Ahern
2018-10-04 21:33 ` [PATCH net-next 07/20] net/ipv6: Update inet6_dump_addr " David Ahern
2018-10-05 17:53 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 08/20] rtnetlink: Update rtnl_dump_ifinfo " David Ahern
2018-10-05 17:59 ` Christian Brauner
2018-10-05 19:22 ` David Ahern
2018-10-07 10:29 ` Christian Brauner
2018-10-08 1:29 ` David Ahern
2018-10-08 9:47 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 09/20] rtnetlink: Update rtnl_bridge_getlink " David Ahern
2018-10-07 10:36 ` Christian Brauner
2018-10-08 1:31 ` David Ahern
2018-10-04 21:33 ` [PATCH net-next 10/20] rtnetlink: Update rtnl_stats_dump " David Ahern
2018-10-07 10:38 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 11/20] rtnetlink: Update inet6_dump_ifinfo " David Ahern
2018-10-05 17:48 ` Christian Brauner
2018-10-05 17:49 ` Christian Brauner
2018-10-05 19:25 ` David Ahern
2018-10-07 10:25 ` Christian Brauner
2018-10-05 17:54 ` Christian Brauner
2018-10-05 19:26 ` David Ahern
2018-10-07 10:23 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 12/20] rtnetlink: Update ipmr_rtm_dumplink " David Ahern
2018-10-07 10:40 ` Christian Brauner
2018-10-08 1:32 ` David Ahern [this message]
2018-10-04 21:33 ` [PATCH net-next 13/20] rtnetlink: Update fib dumps " David Ahern
2018-10-07 10:43 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 14/20] net/neighbor: Update neigh_dump_info " David Ahern
2018-10-07 10:46 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 15/20] net/neighbor: Update neightbl_dump_info " David Ahern
2018-10-07 10:48 ` Christian Brauner
2018-10-08 1:34 ` David Ahern
2018-10-04 21:33 ` [PATCH net-next 16/20] net/namespace: Update rtnl_net_dumpid " David Ahern
2018-10-05 17:45 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 17/20] net/fib_rules: Update fib_nl_dumprule " David Ahern
2018-10-07 10:55 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 18/20] net/ipv6: Update ip6addrlbl_dump " David Ahern
2018-10-07 10:54 ` Christian Brauner
2018-10-04 21:33 ` [PATCH net-next 19/20] net: Update netconf dump handlers " David Ahern
2018-10-07 10:53 ` Christian Brauner
2018-10-08 1:38 ` David Ahern
2018-10-04 21:33 ` [PATCH net-next 20/20] net/bridge: Update br_mdb_dump " David Ahern
2018-10-05 7:34 ` David Miller
2018-10-05 15:49 ` David Ahern
2018-10-05 17:28 ` Christian Brauner
2018-10-05 21:18 ` [PATCH net-next 00/20] rtnetlink: Add support for rigid checking of data in dump request David Ahern
2018-10-05 21:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69539a4e-be1e-5222-a022-771783acd100@gmail.com \
--to=dsahern@gmail.com \
--cc=christian@brauner.io \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.