* [PATCH] c-ares: Fix configure script
@ 2010-10-13 20:12 Sean Cross
2010-10-13 23:39 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Sean Cross @ 2010-10-13 20:12 UTC (permalink / raw)
To: Openembedded-devel
The syntax of one of the AC_CHECK_FUNCS is incorrect. Removing the
lines in question allows the package to configure and build.
---
.../0001-remove-broken-configure.ac-commands.patch | 32 ++++++++++++++++++++
recipes/c-ares/c-ares_1.5.3.bb | 4 ++-
2 files changed, 35 insertions(+), 1 deletions(-)
create mode 100644 recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
diff --git a/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch b/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
new file mode 100644
index 0000000..799332a
--- /dev/null
+++ b/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
@@ -0,0 +1,32 @@
+diff -ur c-ares-1.5.3-stock/configure.ac c-ares-1.5.3/configure.ac
+--- c-ares-1.5.3-stock/configure.ac 2010-10-13 19:12:51.792124107 +0000
++++ c-ares-1.5.3/configure.ac 2010-10-13 19:25:12.932123380 +0000
+@@ -796,28 +796,6 @@
+ )
+
+
+-AC_CHECK_FUNCS([bitncmp \
+- gettimeofday \
+- if_indextoname
+-],[
+-],[
+- func="$ac_func"
+- AC_MSG_CHECKING([deeper for $func])
+- AC_LINK_IFELSE([
+- AC_LANG_PROGRAM([[
+- ]],[[
+- $func ();
+- ]])
+- ],[
+- AC_MSG_RESULT([yes])
+- eval "ac_cv_func_$func=yes"
+- AC_DEFINE_UNQUOTED([AS_TR_CPP([HAVE_$func])], [1],
+- [Define to 1 if you have the $func function.])
+- ],[
+- AC_MSG_RESULT([but still no])
+- ])
+-])
+-
+
+ dnl check for inet_pton
+ AC_CHECK_FUNCS(inet_pton)
diff --git a/recipes/c-ares/c-ares_1.5.3.bb b/recipes/c-ares/c-ares_1.5.3.bb
index 0def152..fa75f3f 100644
--- a/recipes/c-ares/c-ares_1.5.3.bb
+++ b/recipes/c-ares/c-ares_1.5.3.bb
@@ -1,7 +1,9 @@
DESCRIPTION = "c-ares is a C library that resolves names asynchronously."
HOMEPAGE = "http://daniel.haxx.se/projects/c-ares/"
SECTION = "libs"
-SRC_URI = "http://daniel.haxx.se/projects/c-ares/c-ares-${PV}.tar.gz"
+SRC_URI = "http://daniel.haxx.se/projects/c-ares/c-ares-${PV}.tar.gz \
+ file://0001-remove-broken-configure.ac-commands.patch \
+"
LICENSE = "MIT"
S = "${WORKDIR}/c-ares-${PV}"
PR = "r1"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] c-ares: Fix configure script
2010-10-13 20:12 [PATCH] c-ares: Fix configure script Sean Cross
@ 2010-10-13 23:39 ` Khem Raj
2010-10-14 7:34 ` Sean Cross
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2010-10-13 23:39 UTC (permalink / raw)
To: openembedded-devel
On Wed, Oct 13, 2010 at 1:12 PM, Sean Cross <sean@chumby.com> wrote:
>
> The syntax of one of the AC_CHECK_FUNCS is incorrect. Removing the
> lines in question allows the package to configure and build.
instead of removing the check completely it would be better if we fixed it.
you can also cache the result and not run autoreconf on it but thats a fall
back.
> ---
> .../0001-remove-broken-configure.ac-commands.patch | 32 ++++++++++++++++++++
> recipes/c-ares/c-ares_1.5.3.bb | 4 ++-
> 2 files changed, 35 insertions(+), 1 deletions(-)
> create mode 100644 recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
>
> diff --git a/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch b/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
> new file mode 100644
> index 0000000..799332a
> --- /dev/null
> +++ b/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
> @@ -0,0 +1,32 @@
> +diff -ur c-ares-1.5.3-stock/configure.ac c-ares-1.5.3/configure.ac
> +--- c-ares-1.5.3-stock/configure.ac 2010-10-13 19:12:51.792124107 +0000
> ++++ c-ares-1.5.3/configure.ac 2010-10-13 19:25:12.932123380 +0000
> +@@ -796,28 +796,6 @@
> + )
> +
> +
> +-AC_CHECK_FUNCS([bitncmp \
> +- gettimeofday \
> +- if_indextoname
> +-],[
> +-],[
> +- func="$ac_func"
> +- AC_MSG_CHECKING([deeper for $func])
> +- AC_LINK_IFELSE([
> +- AC_LANG_PROGRAM([[
> +- ]],[[
> +- $func ();
> +- ]])
> +- ],[
> +- AC_MSG_RESULT([yes])
> +- eval "ac_cv_func_$func=yes"
> +- AC_DEFINE_UNQUOTED([AS_TR_CPP([HAVE_$func])], [1],
> +- [Define to 1 if you have the $func function.])
> +- ],[
> +- AC_MSG_RESULT([but still no])
> +- ])
> +-])
> +-
> +
> + dnl check for inet_pton
> + AC_CHECK_FUNCS(inet_pton)
> diff --git a/recipes/c-ares/c-ares_1.5.3.bb b/recipes/c-ares/c-ares_1.5.3.bb
> index 0def152..fa75f3f 100644
> --- a/recipes/c-ares/c-ares_1.5.3.bb
> +++ b/recipes/c-ares/c-ares_1.5.3.bb
> @@ -1,7 +1,9 @@
> DESCRIPTION = "c-ares is a C library that resolves names asynchronously."
> HOMEPAGE = "http://daniel.haxx.se/projects/c-ares/"
> SECTION = "libs"
> -SRC_URI = "http://daniel.haxx.se/projects/c-ares/c-ares-${PV}.tar.gz"
> +SRC_URI = "http://daniel.haxx.se/projects/c-ares/c-ares-${PV}.tar.gz \
> + file://0001-remove-broken-configure.ac-commands.patch \
> +"
> LICENSE = "MIT"
> S = "${WORKDIR}/c-ares-${PV}"
> PR = "r1"
> --
> 1.7.0.4
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] c-ares: Fix configure script
2010-10-13 23:39 ` Khem Raj
@ 2010-10-14 7:34 ` Sean Cross
0 siblings, 0 replies; 3+ messages in thread
From: Sean Cross @ 2010-10-14 7:34 UTC (permalink / raw)
To: openembedded-devel
On 14-Oct-2010, at 7:39 AM, Khem Raj wrote:
> On Wed, Oct 13, 2010 at 1:12 PM, Sean Cross <sean@chumby.com> wrote:
>>
>> The syntax of one of the AC_CHECK_FUNCS is incorrect. Removing the
>> lines in question allows the package to configure and build.
>
>
> instead of removing the check completely it would be better if we fixed it.
> you can also cache the result and not run autoreconf on it but thats a fall
> back.
>
Alright. I'm not very familiar with m4 hacking, so I'd like some feedback to make sure the patch I'm sending is sane.
>> ---
>> .../0001-remove-broken-configure.ac-commands.patch | 32 ++++++++++++++++++++
>> recipes/c-ares/c-ares_1.5.3.bb | 4 ++-
>> 2 files changed, 35 insertions(+), 1 deletions(-)
>> create mode 100644 recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
>>
>> diff --git a/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch b/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
>> new file mode 100644
>> index 0000000..799332a
>> --- /dev/null
>> +++ b/recipes/c-ares/0001-remove-broken-configure.ac-commands.patch
>> @@ -0,0 +1,32 @@
>> +diff -ur c-ares-1.5.3-stock/configure.ac c-ares-1.5.3/configure.ac
>> +--- c-ares-1.5.3-stock/configure.ac 2010-10-13 19:12:51.792124107 +0000
>> ++++ c-ares-1.5.3/configure.ac 2010-10-13 19:25:12.932123380 +0000
>> +@@ -796,28 +796,6 @@
>> + )
>> +
>> +
>> +-AC_CHECK_FUNCS([bitncmp \
>> +- gettimeofday \
>> +- if_indextoname
>> +-],[
>> +-],[
>> +- func="$ac_func"
>> +- AC_MSG_CHECKING([deeper for $func])
>> +- AC_LINK_IFELSE([
>> +- AC_LANG_PROGRAM([[
>> +- ]],[[
>> +- $func ();
>> +- ]])
>> +- ],[
>> +- AC_MSG_RESULT([yes])
>> +- eval "ac_cv_func_$func=yes"
>> +- AC_DEFINE_UNQUOTED([AS_TR_CPP([HAVE_$func])], [1],
>> +- [Define to 1 if you have the $func function.])
>> +- ],[
>> +- AC_MSG_RESULT([but still no])
>> +- ])
>> +-])
>> +-
>> +
>> + dnl check for inet_pton
>> + AC_CHECK_FUNCS(inet_pton)
>> diff --git a/recipes/c-ares/c-ares_1.5.3.bb b/recipes/c-ares/c-ares_1.5.3.bb
>> index 0def152..fa75f3f 100644
>> --- a/recipes/c-ares/c-ares_1.5.3.bb
>> +++ b/recipes/c-ares/c-ares_1.5.3.bb
>> @@ -1,7 +1,9 @@
>> DESCRIPTION = "c-ares is a C library that resolves names asynchronously."
>> HOMEPAGE = "http://daniel.haxx.se/projects/c-ares/"
>> SECTION = "libs"
>> -SRC_URI = "http://daniel.haxx.se/projects/c-ares/c-ares-${PV}.tar.gz"
>> +SRC_URI = "http://daniel.haxx.se/projects/c-ares/c-ares-${PV}.tar.gz \
>> + file://0001-remove-broken-configure.ac-commands.patch \
>> +"
>> LICENSE = "MIT"
>> S = "${WORKDIR}/c-ares-${PV}"
>> PR = "r1"
>> --
>> 1.7.0.4
>>
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-14 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-13 20:12 [PATCH] c-ares: Fix configure script Sean Cross
2010-10-13 23:39 ` Khem Raj
2010-10-14 7:34 ` Sean Cross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.