* [PATCH 5/5] tests: avoid passing chunk size to raid1.
@ 2021-07-22 18:29 Sudhakar Panneerselvam
2021-08-02 15:49 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Sudhakar Panneerselvam @ 2021-07-22 18:29 UTC (permalink / raw)
To: jes; +Cc: linux-raid
'04update-metadata' test fails with error, "specifying chunk size is
forbidden for this level" added by commit, 5b30a34aa4b5e. Hence,
correcting the test to ignore passing chunk size to raid1.
Signed-off-by: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
---
tests/04update-metadata | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/04update-metadata b/tests/04update-metadata
index 08c14af7ed29..591009d2797e 100644
--- a/tests/04update-metadata
+++ b/tests/04update-metadata
@@ -11,7 +11,12 @@ dlist="$dev0 $dev1 $dev2 $dev3"
for ls in linear/4 raid1/1 raid5/3 raid6/2
do
s=${ls#*/} l=${ls%/*}
- mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
+ if [[ $l == 'raid1' ]]
+ then
+ mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 $dlist
+ else
+ mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
+ fi
testdev $md0 $s 19904 64
mdadm -S $md0
mdadm -A $md0 --update=metadata $dlist
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/5] tests: avoid passing chunk size to raid1.
2021-07-22 18:29 [PATCH 5/5] tests: avoid passing chunk size to raid1 Sudhakar Panneerselvam
@ 2021-08-02 15:49 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2021-08-02 15:49 UTC (permalink / raw)
To: Sudhakar Panneerselvam; +Cc: linux-raid
On 7/22/21 2:29 PM, Sudhakar Panneerselvam wrote:
> '04update-metadata' test fails with error, "specifying chunk size is
> forbidden for this level" added by commit, 5b30a34aa4b5e. Hence,
> correcting the test to ignore passing chunk size to raid1.
>
> Signed-off-by: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
> ---
> tests/04update-metadata | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/04update-metadata b/tests/04update-metadata
> index 08c14af7ed29..591009d2797e 100644
> --- a/tests/04update-metadata
> +++ b/tests/04update-metadata
> @@ -11,7 +11,12 @@ dlist="$dev0 $dev1 $dev2 $dev3"
> for ls in linear/4 raid1/1 raid5/3 raid6/2
> do
> s=${ls#*/} l=${ls%/*}
> - mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
> + if [[ $l == 'raid1' ]]
> + then
> + mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 $dlist
> + else
> + mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
> + fi
> testdev $md0 $s 19904 64
> mdadm -S $md0
> mdadm -A $md0 --update=metadata $dlist
>
I took a patch from Mateusz that fixed this in a more generic way. If
it's still a problem, please let me know.
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-02 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 18:29 [PATCH 5/5] tests: avoid passing chunk size to raid1 Sudhakar Panneerselvam
2021-08-02 15:49 ` Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.