From: Jia Zhang <zhang.jia@linux.alibaba.com> To: Petr Vorel <pvorel@suse.cz>, zohar@linux.ibm.com Cc: linux-integrity@vger.kernel.org, ltp@lists.linux.it Subject: Re: [PATCH 6/6] ima/ima_violations: Temporarily remove the printk rate limit Date: Wed, 16 Jan 2019 00:42:13 +0800 [thread overview] Message-ID: <698e6865-d0af-f71e-d51e-c4791ef1a096@linux.alibaba.com> (raw) In-Reply-To: <20190115150759.GA2954@dell5510> On 2019/1/15 下午11:07, Petr Vorel wrote: > Hi Jia, Mimi, > > ... >> +reset_printk_ratelimit() >> +{ >> + [ "$PRINTK_RATE_LIMIT" != "0" ] && \ >> + sysctl -wq kernel.printk_ratelimit=$PRINTK_RATE_LIMIT >> +} > ... >> @@ -151,6 +163,8 @@ test3() > >> validate $num_violations $count $search > >> + reset_printk_ratelimit > This should be called in cleanup function. > Actually as it's called only once I'd put it into cleanup function. I recognized that ima_setup.sh already defines a cleanup() so I cannot define another cleanup function in ima_violations.sh. Do you mean moving reset_printk_ratelimit into cleanup() defined in ima_setup.sh? Thanks, Jia > No need to resent the patchset, if it's the only change, I change it before > merge. > > @Mimi: do you agree with this change? > I've seen some issues on some distros when not using auditd daemon, > but now cannot reproduce them any more. > > Kind regards, > Petr >
WARNING: multiple messages have this Message-ID (diff)
From: Jia Zhang <zhang.jia@linux.alibaba.com> To: ltp@lists.linux.it Subject: [LTP] [PATCH 6/6] ima/ima_violations: Temporarily remove the printk rate limit Date: Wed, 16 Jan 2019 00:42:13 +0800 [thread overview] Message-ID: <698e6865-d0af-f71e-d51e-c4791ef1a096@linux.alibaba.com> (raw) In-Reply-To: <20190115150759.GA2954@dell5510> On 2019/1/15 下午11:07, Petr Vorel wrote: > Hi Jia, Mimi, > > ... >> +reset_printk_ratelimit() >> +{ >> + [ "$PRINTK_RATE_LIMIT" != "0" ] && \ >> + sysctl -wq kernel.printk_ratelimit=$PRINTK_RATE_LIMIT >> +} > ... >> @@ -151,6 +163,8 @@ test3() > >> validate $num_violations $count $search > >> + reset_printk_ratelimit > This should be called in cleanup function. > Actually as it's called only once I'd put it into cleanup function. I recognized that ima_setup.sh already defines a cleanup() so I cannot define another cleanup function in ima_violations.sh. Do you mean moving reset_printk_ratelimit into cleanup() defined in ima_setup.sh? Thanks, Jia > No need to resent the patchset, if it's the only change, I change it before > merge. > > @Mimi: do you agree with this change? > I've seen some issues on some distros when not using auditd daemon, > but now cannot reproduce them any more. > > Kind regards, > Petr >
next prev parent reply other threads:[~2019-01-15 16:52 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-15 2:14 [PATCH v2 0/6] LTP IMA fix bundle Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 2:14 ` [PATCH 1/6] ima/ima_boot_aggregate: Fix the definition of event log Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 2:14 ` [PATCH 2/6] ima/ima_boot_aggregate: Don't hard code the length of sha1 hash Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 2:14 ` [PATCH 3/6] ima/ima_boot_aggregate: Fix extending PCRs beyond PCR 0-7 Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 2:14 ` [PATCH 4/6] ima: Code cleanup Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 2:14 ` [PATCH 5/6] ima: Rename the folder name for policy files to datafiles Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 2:14 ` [PATCH 6/6] ima/ima_violations: Temporarily remove the printk rate limit Jia Zhang 2019-01-15 2:14 ` [LTP] " Jia Zhang 2019-01-15 15:07 ` Petr Vorel 2019-01-15 15:07 ` [LTP] " Petr Vorel 2019-01-15 16:42 ` Jia Zhang [this message] 2019-01-15 16:42 ` Jia Zhang 2019-01-15 17:24 ` Petr Vorel 2019-01-15 17:24 ` [LTP] " Petr Vorel 2019-01-16 2:53 ` Jia Zhang 2019-01-16 2:53 ` [LTP] " Jia Zhang 2019-01-15 18:34 ` [LTP] [PATCH v2 0/6] LTP IMA fix bundle Petr Vorel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=698e6865-d0af-f71e-d51e-c4791ef1a096@linux.alibaba.com \ --to=zhang.jia@linux.alibaba.com \ --cc=linux-integrity@vger.kernel.org \ --cc=ltp@lists.linux.it \ --cc=pvorel@suse.cz \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.