* [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040
@ 2020-05-08 22:54 Raul E Rangel
2020-05-09 11:26 ` Andy Shevchenko
2020-05-10 11:33 ` Adrian Hunter
0 siblings, 2 replies; 3+ messages in thread
From: Raul E Rangel @ 2020-05-08 22:54 UTC (permalink / raw)
To: Nehal-bakulchandra Shah, linux-mmc
Cc: evgreen, Joerg Roedel, Andy Shevchenko, Daniel Kurtz, dianders,
Ulf Hansson, Adrian Hunter, Raul E Rangel, linux-kernel
The AMD eMMC 5.0 controller does not support 64 bit DMA.
See the discussion here: https://marc.info/?l=linux-mmc&m=158879884514552&w=2
Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD Controller with HS400")
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
---
drivers/mmc/host/sdhci-acpi.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index faba53cf139b..d8b76cb8698a 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -605,10 +605,12 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
}
static const struct sdhci_acpi_slot sdhci_acpi_slot_amd_emmc = {
- .chip = &sdhci_acpi_chip_amd,
- .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
- .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR | SDHCI_QUIRK_32BIT_DMA_SIZE |
- SDHCI_QUIRK_32BIT_ADMA_SIZE,
+ .chip = &sdhci_acpi_chip_amd,
+ .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+ .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR |
+ SDHCI_QUIRK_32BIT_DMA_SIZE |
+ SDHCI_QUIRK_32BIT_ADMA_SIZE,
+ .quirks2 = SDHCI_QUIRK2_BROKEN_64_BIT_DMA,
.probe_slot = sdhci_acpi_emmc_amd_probe_slot,
};
--
2.26.2.645.ge9eca65c58-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040
2020-05-08 22:54 [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040 Raul E Rangel
@ 2020-05-09 11:26 ` Andy Shevchenko
2020-05-10 11:33 ` Adrian Hunter
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-05-09 11:26 UTC (permalink / raw)
To: Raul E Rangel
Cc: Nehal-bakulchandra Shah, linux-mmc, evgreen, Joerg Roedel,
Daniel Kurtz, dianders, Ulf Hansson, Adrian Hunter, linux-kernel
On Fri, May 08, 2020 at 04:54:21PM -0600, Raul E Rangel wrote:
> The AMD eMMC 5.0 controller does not support 64 bit DMA.
>
> See the discussion here: https://marc.info/?l=linux-mmc&m=158879884514552&w=2
Link: ...
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD Controller with HS400")
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> ---
>
> drivers/mmc/host/sdhci-acpi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index faba53cf139b..d8b76cb8698a 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -605,10 +605,12 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
> }
>
> static const struct sdhci_acpi_slot sdhci_acpi_slot_amd_emmc = {
> - .chip = &sdhci_acpi_chip_amd,
> - .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> - .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR | SDHCI_QUIRK_32BIT_DMA_SIZE |
> - SDHCI_QUIRK_32BIT_ADMA_SIZE,
> + .chip = &sdhci_acpi_chip_amd,
> + .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> + .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR |
> + SDHCI_QUIRK_32BIT_DMA_SIZE |
> + SDHCI_QUIRK_32BIT_ADMA_SIZE,
> + .quirks2 = SDHCI_QUIRK2_BROKEN_64_BIT_DMA,
> .probe_slot = sdhci_acpi_emmc_amd_probe_slot,
> };
>
> --
> 2.26.2.645.ge9eca65c58-goog
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040
2020-05-08 22:54 [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040 Raul E Rangel
2020-05-09 11:26 ` Andy Shevchenko
@ 2020-05-10 11:33 ` Adrian Hunter
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2020-05-10 11:33 UTC (permalink / raw)
To: Raul E Rangel, Nehal-bakulchandra Shah, linux-mmc
Cc: evgreen, Joerg Roedel, Andy Shevchenko, Daniel Kurtz, dianders,
Ulf Hansson, linux-kernel
On 9/05/20 1:54 am, Raul E Rangel wrote:
> The AMD eMMC 5.0 controller does not support 64 bit DMA.
>
> See the discussion here: https://marc.info/?l=linux-mmc&m=158879884514552&w=2
>
> Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD Controller with HS400")
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-acpi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index faba53cf139b..d8b76cb8698a 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -605,10 +605,12 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
> }
>
> static const struct sdhci_acpi_slot sdhci_acpi_slot_amd_emmc = {
> - .chip = &sdhci_acpi_chip_amd,
> - .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> - .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR | SDHCI_QUIRK_32BIT_DMA_SIZE |
> - SDHCI_QUIRK_32BIT_ADMA_SIZE,
> + .chip = &sdhci_acpi_chip_amd,
> + .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> + .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR |
> + SDHCI_QUIRK_32BIT_DMA_SIZE |
> + SDHCI_QUIRK_32BIT_ADMA_SIZE,
> + .quirks2 = SDHCI_QUIRK2_BROKEN_64_BIT_DMA,
> .probe_slot = sdhci_acpi_emmc_amd_probe_slot,
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-10 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 22:54 [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040 Raul E Rangel
2020-05-09 11:26 ` Andy Shevchenko
2020-05-10 11:33 ` Adrian Hunter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.