Re: [yocto] [meta-rockchip][PATCH] kernel: linux-yocto: fix broken Ethernet MAC controller on RK3399 on 5.14 >= version <= 5.14.11

[Quentin Schulz <foss@0leil.net>]

On November 16, 2021 6:45:05 PM GMT+01:00, Khem Raj <raj.khem@gmail.com> wrote:
>On Tue, Nov 16, 2021 at 9:12 AM Quentin Schulz <
>quentin.schulz@theobroma-systems.com> wrote:
>
>> On Tue, Nov 16, 2021 at 09:08:41AM -0800, Khem Raj wrote:
>> > On Tue, Nov 16, 2021 at 9:04 AM Quentin Schulz
>> > <quentin.schulz@theobroma-systems.com> wrote:
>> > >
>> > > On Tue, Nov 16, 2021 at 09:00:42AM -0800, Khem Raj wrote:
>> > > > On Tue, Nov 16, 2021 at 7:52 AM Quentin Schulz
>> > > > <quentin.schulz@theobroma-systems.com> wrote:
>> > > > >
>> > > > > From Linux kernel v5.14 to v5.14.11 (both included), the Ethernet
>> MAC
>> > > > > controller found on RK3399 is not working.
>> > > > >
>> > > > > A fix is available in v5.14.12 and later (available also in v5.15)
>> > > > > which is provided here and applied to linux-yocto source tree if
>> > > > > linux-yocto version is of the impacted ones.
>> > > > >
>> > > > > The conditional patching is unfortunately required because
>> Honister 3.4
>> > > > > has linux-yocto v5.14.9 and Honister 3.4.1 will have at least
>> > > > > linux-yocto v5.14.14.
>> > > >
>> > > > Patching piece below looks quite a bit.
>> > > > lets just fix v5.14.14 and dont worry about 3.4
>> > > >
>> > >
>> > > v5.14.14 is already fixed. The only release currently is 3.4 and I hit
>> > > that issue, hence the patch.
>> > > I assume not everybody is updating to 3.4.1 when it's out, I've seen
>> > > people running behind dot releases.
>> > > What's bothering you?
>> >
>> > once dot release is out then thats whats maintained not the original
>> > release since they are incremental.
>> > the anon python to apply a patch. Can you explain why we want to patch
>> > applied this way ?
>> >
>>
>> I could define a python function and use it like this:
>> SRC_URI:append:rk3399 = "${@rk3399_fix_mac(d)}"
>>
>> Would that work better for you?
>
>
>I am not yet convinced why should we have such version specific patch
>

If you could explain what's *really* bothering you, I could try to find a proper explanation or agree with you but it's a bit too vague to me right now. Anyway, I'll do some guesses in the next paragraphs.

Because Ethernet does not work for all RK3399-based boards in the latest and only release of Honister?

meta-rockchip is the BSP layer for Rockchip based devices, if not there, where should I put this patch?

Or are we just going to say "Ethernet does not work, we know" to people asking instead of having this patch in? Obviously you could tell them to upgrade their oe-core/poky git repo to rolling honister or 3.4.1 once it's out but having this patch in avoid those questions.

I understand we're talking about policy here. I am not fond of this patch either but Ethernet is quite critical on boards which don't have WiFi for example. I don't have anything better to suggest to fix this in the *latest* release.

Cheers
Quentin
>>
>>
>> Cheers,
>> Quentin
>>