* [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
@ 2019-04-09 10:07 Chiou, Cooper
2019-04-09 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Chiou, Cooper @ 2019-04-09 10:07 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Chiou, Cooper, Chiou
VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps
is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map
correct values
Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data
rate 000=Default, 001=2.97Gbps, 010=1.65Gbps, so HDMI_MAX_DATA_RATE_297
should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
TEST: Validated PASS on GLK RVP platform
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Chiou, Cooper <cooper.chiou@intel.com>
---
drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
index bf3662ad5fed..e2b8d042912b 100644
--- a/drivers/gpu/drm/i915/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
@@ -307,8 +307,8 @@ struct bdb_general_features {
#define DVO_PORT_MIPID 24 /* 171 */
#define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
-#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
-#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
+#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
+#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
#define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-09 10:07 [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT Chiou, Cooper
@ 2019-04-09 11:19 ` Patchwork
2019-04-09 12:44 ` [PATCH] " Ville Syrjälä
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-04-09 11:19 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Update HDMI max TMDS data rate definition for VBT
URL : https://patchwork.freedesktop.org/series/59220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5895 -> Patchwork_12736
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59220/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12736 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@basic-bsd2:
- fi-kbl-7500u: NOTRUN -> SKIP [fdo#109271] +9
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: NOTRUN -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#103841]
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_psr@primary_page_flip:
- fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +50
* igt@runner@aborted:
- fi-kbl-7500u: NOTRUN -> FAIL [fdo#103841]
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_hangcheck:
- {fi-icl-u2}: INCOMPLETE [fdo#108569] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: FAIL [fdo#103167] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (46 -> 44)
------------------------------
Additional (2): fi-apl-guc fi-kbl-7500u
Missing (4): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5895 -> Patchwork_12736
CI_DRM_5895: c9427b529bd9df1ce91fe3755f4f03512d36ade7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4933: fef5706e11dcfc72cc759242842d36e7c8dc5e31 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12736: e1e333e0501443f3e5d9507f84760b467d8d50c2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e1e333e05014 drm/i915: Update HDMI max TMDS data rate definition for VBT
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12736/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-09 10:07 [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT Chiou, Cooper
2019-04-09 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-09 12:44 ` Ville Syrjälä
2019-04-09 15:46 ` Chiou, Cooper
2019-04-09 15:34 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-04-09 17:10 ` ✗ Fi.CI.BAT: failure for drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2) Patchwork
3 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2019-04-09 12:44 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: jani.nikula, Chiou, intel-gfx
On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
> VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps
> is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map
> correct values
Eh what? Did someone just change the interpretation of these bits?
> Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data
> rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
Here you're quoting the values we already use...
> so HDMI_MAX_DATA_RATE_297
> should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
...but here you're using different values again? Which way is it?
>
> TEST: Validated PASS on GLK RVP platform
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Chiou, Cooper <cooper.chiou@intel.com>
> ---
> drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index bf3662ad5fed..e2b8d042912b 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -307,8 +307,8 @@ struct bdb_general_features {
> #define DVO_PORT_MIPID 24 /* 171 */
>
> #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
> -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
> -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
> +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
> +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
>
> #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
>
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-09 10:07 [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT Chiou, Cooper
2019-04-09 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-09 12:44 ` [PATCH] " Ville Syrjälä
@ 2019-04-09 15:34 ` Patchwork
2019-04-09 17:10 ` ✗ Fi.CI.BAT: failure for drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2) Patchwork
3 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-04-09 15:34 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Update HDMI max TMDS data rate definition for VBT
URL : https://patchwork.freedesktop.org/series/59220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5895_full -> Patchwork_12736_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12736_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@extended-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +8
* igt@gem_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-iclb: PASS -> INCOMPLETE [fdo#109801]
* igt@gem_pwrite@huge-cpu-backwards:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_suspend@forcewake:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
- shard-kbl: PASS -> DMESG-WARN [fdo#108566]
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +3
* igt@kms_busy@extended-modeset-hang-oldfb-render-f:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +7
* igt@kms_chamelium@hdmi-hpd-after-suspend:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +1
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336]
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-apl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-skl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-iclb: PASS -> FAIL [fdo#103355]
* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#103833]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +156
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +6
* igt@kms_force_connector_basic@prune-stale-modes:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]
* igt@kms_frontbuffer_tracking@basic:
- shard-iclb: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#109247] +7
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-onoff:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +12
* igt@kms_lease@atomic_implicit_crtc:
- shard-kbl: NOTRUN -> FAIL [fdo#110279]
* igt@kms_lease@setcrtc_implicit_plane:
- shard-kbl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +13
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +2
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: PASS -> SKIP [fdo#109642]
* igt@kms_psr@primary_mmap_cpu:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +2
* igt@kms_psr@psr2_dpms:
- shard-iclb: NOTRUN -> SKIP [fdo#109441]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +12
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-iclb: PASS -> FAIL [fdo#104894]
* igt@perf_pmu@busy-accuracy-50-vcs1:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +104
* igt@tools_test@sysfs_l3_parity:
- shard-iclb: NOTRUN -> SKIP [fdo#109307]
* igt@v3d_get_param@get-bad-param:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
* igt@v3d_mmap@mmap-bad-handle:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +119
#### Possible fixes ####
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP [fdo#109271] -> PASS
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-iclb: FAIL [fdo#103355] -> PASS
* igt@kms_fbcon_fbt@fbc:
- shard-iclb: DMESG-WARN [fdo#109593] -> PASS
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-glk: FAIL [fdo#100368] -> PASS
* igt@kms_flip@flip-vs-absolute-wf_vblank:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +2
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-skl: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-iclb: FAIL [fdo#109247] -> PASS +20
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_psr@no_drrs:
- shard-iclb: FAIL [fdo#108341] -> PASS
* igt@kms_psr@sprite_mmap_gtt:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +2
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110279]: https://bugs.freedesktop.org/show_bug.cgi?id=110279
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-hsw
Build changes
-------------
* Linux: CI_DRM_5895 -> Patchwork_12736
CI_DRM_5895: c9427b529bd9df1ce91fe3755f4f03512d36ade7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4933: fef5706e11dcfc72cc759242842d36e7c8dc5e31 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12736: e1e333e0501443f3e5d9507f84760b467d8d50c2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12736/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-09 12:44 ` [PATCH] " Ville Syrjälä
@ 2019-04-09 15:46 ` Chiou, Cooper
2019-04-09 15:57 ` Ville Syrjälä
0 siblings, 1 reply; 12+ messages in thread
From: Chiou, Cooper @ 2019-04-09 15:46 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Nikula, Jani, Chiou, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2394 bytes --]
Hi Ville,
The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.
So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297.
And HDMI_MAX_DATA_RATE_165 is 4 not 2.
I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI 2.0 then found this error. And I run CrOS on GLK with changed VBT to validate it. Thanks,
Best Regards,
Cooper
On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>> wrote:
On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps
is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map
correct values
Eh what? Did someone just change the interpretation of these bits?
Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data
rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
Here you're quoting the values we already use...
so HDMI_MAX_DATA_RATE_297
should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
...but here you're using different values again? Which way is it?
TEST: Validated PASS on GLK RVP platform
Cc: Jani Nikula <jani.nikula@intel.com<mailto:jani.nikula@intel.com>>
Signed-off-by: Chiou, Cooper <cooper.chiou@intel.com<mailto:cooper.chiou@intel.com>>
---
drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
index bf3662ad5fed..e2b8d042912b 100644
--- a/drivers/gpu/drm/i915/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
@@ -307,8 +307,8 @@ struct bdb_general_features {
#define DVO_PORT_MIPID 24 /* 171 */
#define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
-#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
-#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
+#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
+#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
#define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
[-- Attachment #1.2: Type: text/html, Size: 5967 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-09 15:46 ` Chiou, Cooper
@ 2019-04-09 15:57 ` Ville Syrjälä
2019-04-10 10:08 ` Chiou, Cooper
0 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2019-04-09 15:57 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: Nikula, Jani, Chiou, intel-gfx
On Tue, Apr 09, 2019 at 03:46:20PM +0000, Chiou, Cooper wrote:
> Hi Ville,
>
> The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.
> So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297.
No. The bitfield is defined as something:3.
> And HDMI_MAX_DATA_RATE_165 is 4 not 2.
>
> I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI 2.0 then found this error. And I run CrOS on GLK with changed VBT to validate it. Thanks,
>
> Best Regards,
> Cooper
>
> On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>> wrote:
>
> On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
> VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps
> is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map
> correct values
>
> Eh what? Did someone just change the interpretation of these bits?
>
> Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data
> rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
>
> Here you're quoting the values we already use...
>
> so HDMI_MAX_DATA_RATE_297
> should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
>
> ...but here you're using different values again? Which way is it?
>
>
> TEST: Validated PASS on GLK RVP platform
>
> Cc: Jani Nikula <jani.nikula@intel.com<mailto:jani.nikula@intel.com>>
> Signed-off-by: Chiou, Cooper <cooper.chiou@intel.com<mailto:cooper.chiou@intel.com>>
> ---
> drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index bf3662ad5fed..e2b8d042912b 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -307,8 +307,8 @@ struct bdb_general_features {
> #define DVO_PORT_MIPID 24 /* 171 */
>
> #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
> -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
> -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
> +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
> +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
>
> #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
>
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org>
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2)
2019-04-09 10:07 [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT Chiou, Cooper
` (2 preceding siblings ...)
2019-04-09 15:34 ` ✓ Fi.CI.IGT: success for " Patchwork
@ 2019-04-09 17:10 ` Patchwork
3 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-04-09 17:10 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2)
URL : https://patchwork.freedesktop.org/series/59220/
State : failure
== Summary ==
Applying: drm/i915: Update HDMI max TMDS data rate definition for VBT
error: corrupt patch at line 13
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 drm/i915: Update HDMI max TMDS data rate definition for VBT
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-09 15:57 ` Ville Syrjälä
@ 2019-04-10 10:08 ` Chiou, Cooper
2019-04-10 10:50 ` Ville Syrjälä
0 siblings, 1 reply; 12+ messages in thread
From: Chiou, Cooper @ 2019-04-10 10:08 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Nikula, Jani, intel-gfx
[-- Attachment #1.1.1: Type: text/plain, Size: 5652 bytes --]
Hi Ville,
From Intel BSpec, this is HDMI max data rate bits field definition as the following, and please find my experiment/log below. And as I knew, all platforms are using Default 000 for max data rate. (No any platform used 2.97/1.65 definition in VBT so far). That’s why I correct HDMI max. data rate definition to be right value in 2.97 & 1.65Gbps. Thanks,
“HDMI max data rate and level shifter value” defined in BSpec:
Bits 7 – 5 = HDMI Maximum Data Rate
000 = Default (Software should choose the maximum data rate as supported by platform BSpec)
001 = 2.97 GT/s
010 = 1.65 GT/s
Bit 4 - 0 = HDMI Level shifter value selection
Values differ from platform to platform
1. When I set HDMI TMDS = 2.97Gbps in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “hdmi_max_data_rate=2”.
[cid:image003.jpg@01D4EFC8.6DB4F360]
DEBUG kernel: [ 0.172359] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
DEBUG kernel: [ 0.172360] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
DEBUG kernel: [ 0.172362] [drm:intel_bios_init] [Cooper] bdb_version=212
DEBUG kernel: [ 0.172363] [drm:intel_bios_init] [Cooper] hdmi_max_data_rate=2
DEBUG kernel: [ 0.172364] [drm:intel_bios_init] [Cooper] max_tmds_clock=165000
DEBUG kernel: [ 0.172365] [drm:intel_bios_init] VBT HDMI max TMDS clock for port B: 165000 kHz
2. When I set HDMI TMDS = 1,65Gbps in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “hdmi_max_data_rate=4”.
DEBUG kernel: [ 0.172363] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
DEBUG kernel: [ 0.172364] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
DEBUG kernel: [ 0.172365] [drm:intel_bios_init] [Cooper] bdb_version=212
DEBUG kernel: [ 0.172366] [drm:intel_bios_init] [Cooper] hdmi_max_data_rate=4
WARNING kernel: [ 0.172367] ------------[ cut here ]------------
WARNING kernel: [ 0.172369] Missing switch case (4) in parse_ddi_port
Best Regards,
Cooper
+886-2-6622-1166
-----Original Message-----
From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
Sent: Tuesday, April 9, 2019 23:57 PM
To: Chiou, Cooper <cooper.chiou@intel.com>
Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com>; Chiou@freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
On Tue, Apr 09, 2019 at 03:46:20PM +0000, Chiou, Cooper wrote:
> Hi Ville,
>
> The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.
> So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297.
No. The bitfield is defined as something:3.
> And HDMI_MAX_DATA_RATE_165 is 4 not 2.
>
> I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI
> 2.0 then found this error. And I run CrOS on GLK with changed VBT to
> validate it. Thanks,
>
> Best Regards,
> Cooper
>
> On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com>>> wrote:
>
> On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
> VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and
> 1.65Gbps is 0x04, so changed
> HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values
>
> Eh what? Did someone just change the interpretation of these bits?
>
> Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max.
> data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
>
> Here you're quoting the values we already use...
>
> so HDMI_MAX_DATA_RATE_297
> should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
>
> ...but here you're using different values again? Which way is it?
>
>
> TEST: Validated PASS on GLK RVP platform
>
> Cc: Jani Nikula <jani.nikula@intel.com<mailto:jani.nikula@intel.com<mailto:jani.nikula@intel.com%3cmailto:jani.nikula@intel.com>>>
> Signed-off-by: Chiou, Cooper
> <cooper.chiou@intel.com<mailto:cooper.chiou@intel.com<mailto:cooper.chiou@intel.com%3cmailto:cooper.chiou@intel.com>>>
> ---
> drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h
> b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index bf3662ad5fed..e2b8d042912b 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -307,8 +307,8 @@ struct bdb_general_features {
> #define DVO_PORT_MIPID 24 /* 171 */
>
> #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
> -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
> -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
> +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
> +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
>
> #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
>
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org%3cmailto:Intel-gfx@lists.freedesktop.org>
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel
--
Ville Syrjälä
Intel
[-- Attachment #1.1.2: Type: text/html, Size: 14675 bytes --]
[-- Attachment #1.2: image003.jpg --]
[-- Type: image/jpeg, Size: 9344 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-10 10:08 ` Chiou, Cooper
@ 2019-04-10 10:50 ` Ville Syrjälä
2019-04-10 11:32 ` Chiou, Cooper
0 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2019-04-10 10:50 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: Nikula, Jani, intel-gfx
On Wed, Apr 10, 2019 at 10:08:43AM +0000, Chiou, Cooper wrote:
> Hi Ville,
>
>
>
> From Intel BSpec, this is HDMI max data rate bits field definition as the following, and please find my experiment/log below. And as I knew, all platforms are using Default 000 for max data rate. (No any platform used 2.97/1.65 definition in VBT so far). That’s why I correct HDMI max. data rate definition to be right value in 2.97 & 1.65Gbps. Thanks,
>
>
>
> “HDMI max data rate and level shifter value” defined in BSpec:
>
> Bits 7 – 5 = HDMI Maximum Data Rate
>
> 000 = Default (Software should choose the maximum data rate as supported by platform BSpec)
>
> 001 = 2.97 GT/s
>
> 010 = 1.65 GT/s
>
>
>
> Bit 4 - 0 = HDMI Level shifter value selection
>
> Values differ from platform to platform
>
>
>
> 1. When I set HDMI TMDS = 2.97Gbps in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “hdmi_max_data_rate=2”.
That would suggest that the tool you use to generate the VBT doesn't
follow the spec. So either the tool is broken or the spec is wrong,
or both. Or we have a weird compiler bug on our hands (this can be
confirmed/ruled out by checking the hexdump of the VBT).
>
> [cid:image003.jpg@01D4EFC8.6DB4F360]
>
> DEBUG kernel: [ 0.172359] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
>
> DEBUG kernel: [ 0.172360] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
>
> DEBUG kernel: [ 0.172362] [drm:intel_bios_init] [Cooper] bdb_version=212
>
> DEBUG kernel: [ 0.172363] [drm:intel_bios_init] [Cooper] hdmi_max_data_rate=2
>
> DEBUG kernel: [ 0.172364] [drm:intel_bios_init] [Cooper] max_tmds_clock=165000
>
> DEBUG kernel: [ 0.172365] [drm:intel_bios_init] VBT HDMI max TMDS clock for port B: 165000 kHz
>
>
>
> 2. When I set HDMI TMDS = 1,65Gbps in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “hdmi_max_data_rate=4”.
>
>
>
> DEBUG kernel: [ 0.172363] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
>
> DEBUG kernel: [ 0.172364] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
>
> DEBUG kernel: [ 0.172365] [drm:intel_bios_init] [Cooper] bdb_version=212
>
> DEBUG kernel: [ 0.172366] [drm:intel_bios_init] [Cooper] hdmi_max_data_rate=4
>
> WARNING kernel: [ 0.172367] ------------[ cut here ]------------
>
> WARNING kernel: [ 0.172369] Missing switch case (4) in parse_ddi_port
>
>
>
> Best Regards,
>
> Cooper
>
> +886-2-6622-1166
>
>
>
>
>
> -----Original Message-----
> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> Sent: Tuesday, April 9, 2019 23:57 PM
> To: Chiou, Cooper <cooper.chiou@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com>; Chiou@freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
>
>
>
> On Tue, Apr 09, 2019 at 03:46:20PM +0000, Chiou, Cooper wrote:
>
> > Hi Ville,
>
> >
>
> > The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.
>
> > So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297.
>
>
>
> No. The bitfield is defined as something:3.
>
>
>
> > And HDMI_MAX_DATA_RATE_165 is 4 not 2.
>
> >
>
> > I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI
>
> > 2.0 then found this error. And I run CrOS on GLK with changed VBT to
>
> > validate it. Thanks,
>
> >
>
> > Best Regards,
>
> > Cooper
>
> >
>
> > On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com>>> wrote:
>
> >
>
> > On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
>
> > VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and
>
> > 1.65Gbps is 0x04, so changed
>
> > HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values
>
> >
>
> > Eh what? Did someone just change the interpretation of these bits?
>
> >
>
> > Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max.
>
> > data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
>
> >
>
> > Here you're quoting the values we already use...
>
> >
>
> > so HDMI_MAX_DATA_RATE_297
>
> > should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
>
> >
>
> > ...but here you're using different values again? Which way is it?
>
> >
>
> >
>
> > TEST: Validated PASS on GLK RVP platform
>
> >
>
> > Cc: Jani Nikula <jani.nikula@intel.com<mailto:jani.nikula@intel.com<mailto:jani.nikula@intel.com%3cmailto:jani.nikula@intel.com>>>
>
> > Signed-off-by: Chiou, Cooper
>
> > <cooper.chiou@intel.com<mailto:cooper.chiou@intel.com<mailto:cooper.chiou@intel.com%3cmailto:cooper.chiou@intel.com>>>
>
> > ---
>
> > drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
>
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> >
>
> > diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > b/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > index bf3662ad5fed..e2b8d042912b 100644
>
> > --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > @@ -307,8 +307,8 @@ struct bdb_general_features {
>
> > #define DVO_PORT_MIPID 24 /* 171 */
>
> >
>
> > #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
>
> > -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
>
> > -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
>
> > +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
>
> > +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
>
> >
>
> > #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
>
> >
>
> > --
>
> > 2.7.4
>
> >
>
> > _______________________________________________
>
> > Intel-gfx mailing list
>
> > Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org%3cmailto:Intel-gfx@lists.freedesktop.org>
>
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> >
>
> > --
>
> > Ville Syrjälä
>
> > Intel
>
>
>
> --
>
> Ville Syrjälä
>
> Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-10 10:50 ` Ville Syrjälä
@ 2019-04-10 11:32 ` Chiou, Cooper
2019-04-10 12:23 ` Ville Syrjälä
0 siblings, 1 reply; 12+ messages in thread
From: Chiou, Cooper @ 2019-04-10 11:32 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Nikula, Jani, intel-gfx
[-- Attachment #1.1.1: Type: text/plain, Size: 9568 bytes --]
Hi Ville,
From BSpec define, HDMI max data rate is “Bits 5-7” not Bits 4-7. And the following image is what I captured by latest VBT BMP v2.67 tool to load GLK VBT bin file and changed HDMI_MAX_TMDS_Bit_Rate field in 5.94/2.97/1.65Gbps different bit-rate.
A. 5.94Gbps(HDMI_MAX_DATA_RATE_PLATFORM) = 0 is correct, the “HDMI max data rate and level shift” value is 0x08 in following highlight block.
B. 2.97Gbps (HDMI_MAX_DATA_RATE_297) was 1 is wrong, it should be 001x xxxx. In this case, “HDMI max data rate and level shift value” is “0x28” in vbt.bin, so intel_vbt_defs.h HDMI_MAX_DATA_RATE_297=1 is wrong, so it should be 2
C. 1.65Gbps (HDMI_MAX_DATA_RATE_165) was 2 is wrong, it should be 010x xxxx. In this case, “HDMI max data rate and level shift value” is “0x48” in vbt.bin, so intel_vbt_defs.h HDMI_MAX_DATA_RATE_297=2 is wrong, so it should be 4
BSpec:
HDMI Maximum Data Rate
000 = Default (Software should choose the maximum data rate as supported by platform BSpec)
001 = 2.97 GT/s
010 = 1.65 GT/s
intel_vbt_defs.h
#define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
Should change to
#define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
#define HDMI_MAX_DATA_RATE_297 2 /* 204 */
#define HDMI_MAX_DATA_RATE_165 4 /* 204 */
[cid:image002.jpg@01D4EFD4.2BA8E060]
Best Regards,
Cooper
+886-2-6622-1166
-----Original Message-----
From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
Sent: Wednesday, April 10, 2019 18:50 PM
To: Chiou, Cooper <cooper.chiou@intel.com>
Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
On Wed, Apr 10, 2019 at 10:08:43AM +0000, Chiou, Cooper wrote:
> Hi Ville,
>
>
>
> From Intel BSpec, this is HDMI max data rate bits field definition as
> the following, and please find my experiment/log below. And as I knew,
> all platforms are using Default 000 for max data rate. (No any
> platform used 2.97/1.65 definition in VBT so far). That’s why I
> correct HDMI max. data rate definition to be right value in 2.97 &
> 1.65Gbps. Thanks,
>
>
>
> “HDMI max data rate and level shifter value” defined in BSpec:
>
> Bits 7 – 5 = HDMI Maximum Data Rate
>
> 000 = Default (Software should choose the maximum data
> rate as supported by platform BSpec)
>
> 001 = 2.97 GT/s
>
> 010 = 1.65 GT/s
>
>
>
> Bit 4 - 0 = HDMI Level shifter value selection
>
> Values differ from platform to platform
>
>
>
> 1. When I set HDMI TMDS = 2.97Gbps in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “hdmi_max_data_rate=2”.
That would suggest that the tool you use to generate the VBT doesn't follow the spec. So either the tool is broken or the spec is wrong, or both. Or we have a weird compiler bug on our hands (this can be confirmed/ruled out by checking the hexdump of the VBT).
>
> [cid:image003.jpg@01D4EFC8.6DB4F360]
>
> DEBUG kernel: [ 0.172359] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
>
> DEBUG kernel: [ 0.172360] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
>
> DEBUG kernel: [ 0.172362] [drm:intel_bios_init] [Cooper] bdb_version=212
>
> DEBUG kernel: [ 0.172363] [drm:intel_bios_init] [Cooper] hdmi_max_data_rate=2
>
> DEBUG kernel: [ 0.172364] [drm:intel_bios_init] [Cooper] max_tmds_clock=165000
>
> DEBUG kernel: [ 0.172365] [drm:intel_bios_init] VBT HDMI max TMDS clock for port B: 165000 kHz
>
>
>
> 2. When I set HDMI TMDS = 1,65Gbps in GLK VBT, then i915 intel_bios.c parse_ddi_port() function got “hdmi_max_data_rate=4”.
>
>
>
> DEBUG kernel: [ 0.172363] [drm:intel_bios_init] Port B VBT info: DP:0 HDMI:1 DVI:1 EDP:0 CRT:0
>
> DEBUG kernel: [ 0.172364] [drm:intel_bios_init] VBT HDMI level shift for port B: 8
>
> DEBUG kernel: [ 0.172365] [drm:intel_bios_init] [Cooper] bdb_version=212
>
> DEBUG kernel: [ 0.172366] [drm:intel_bios_init] [Cooper] hdmi_max_data_rate=4
>
> WARNING kernel: [ 0.172367] ------------[ cut here ]------------
>
> WARNING kernel: [ 0.172369] Missing switch case (4) in parse_ddi_port
>
>
>
> Best Regards,
>
> Cooper
>
> +886-2-6622-1166
>
>
>
>
>
> -----Original Message-----
> From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com]
> Sent: Tuesday, April 9, 2019 23:57 PM
> To: Chiou, Cooper <cooper.chiou@intel.com<mailto:cooper.chiou@intel.com>>
> Cc: intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org>; Nikula, Jani
> <jani.nikula@intel.com<mailto:jani.nikula@intel.com>>; Chiou@freedesktop.org<mailto:Chiou@freedesktop.org>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data
> rate definition for VBT
>
>
>
> On Tue, Apr 09, 2019 at 03:46:20PM +0000, Chiou, Cooper wrote:
>
> > Hi Ville,
>
> >
>
> > The bits is 5-7 means it’s 001x xxxx for 2.97Gbps, and 010x xxxx for 1.65Gbps.
>
> > So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297.
>
>
>
> No. The bitfield is defined as something:3.
>
>
>
> > And HDMI_MAX_DATA_RATE_165 is 4 not 2.
>
> >
>
> > I checked kernel i915 log and modified VBT to limit HDMI 1.4 from
> > HDMI
>
> > 2.0 then found this error. And I run CrOS on GLK with changed VBT to
>
> > validate it. Thanks,
>
> >
>
> > Best Regards,
>
> > Cooper
>
> >
>
> > On Apr 9, 2019, at 8:45 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com%3cmailto:ville.syrjala@linux.intel.com>>>> wrote:
>
> >
>
> > On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
>
> > VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and
>
> > 1.65Gbps is 0x04, so changed
>
> > HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values
>
> >
>
> > Eh what? Did someone just change the interpretation of these bits?
>
> >
>
> > Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max.
>
> > data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
>
> >
>
> > Here you're quoting the values we already use...
>
> >
>
> > so HDMI_MAX_DATA_RATE_297
>
> > should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
>
> >
>
> > ...but here you're using different values again? Which way is it?
>
> >
>
> >
>
> > TEST: Validated PASS on GLK RVP platform
>
> >
>
> > Cc: Jani Nikula
> > <jani.nikula@intel.com<mailto:jani.nikula@intel.com<mailto:jani.niku
> > la@intel.com%3cmailto:jani.nikula@intel.com<mailto:la@intel.com%3cmailto:jani.nikula@intel.com>>>>
>
> > Signed-off-by: Chiou, Cooper
>
> > <cooper.chiou@intel.com<mailto:cooper.chiou@intel.com<mailto:cooper.
> > chiou@intel.com%3cmailto:cooper.chiou@intel.com<mailto:chiou@intel.com%3cmailto:cooper.chiou@intel.com>>>>
>
> > ---
>
> > drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
>
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> >
>
> > diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > b/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > index bf3662ad5fed..e2b8d042912b 100644
>
> > --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
>
> > @@ -307,8 +307,8 @@ struct bdb_general_features {
>
> > #define DVO_PORT_MIPID 24 /* 171 */
>
> >
>
> > #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
>
> > -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
>
> > -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
>
> > +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
>
> > +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
>
> >
>
> > #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
>
> >
>
> > --
>
> > 2.7.4
>
> >
>
> > _______________________________________________
>
> > Intel-gfx mailing list
>
> > Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.o<mailto:Intel-gfx@lists.freedesktop.org%3cmailto:Intel-gfx@lists.freedesktop.o>
> > rg<mailto:Intel-gfx@lists.freedesktop.org%3cmailto:Intel-gfx@lists.f
> > reedesktop.org>
>
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> >
>
> > --
>
> > Ville Syrjälä
>
> > Intel
>
>
>
> --
>
> Ville Syrjälä
>
> Intel
--
Ville Syrjälä
Intel
[-- Attachment #1.1.2: Type: text/html, Size: 28396 bytes --]
[-- Attachment #1.2: image002.jpg --]
[-- Type: image/jpeg, Size: 118537 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-10 11:32 ` Chiou, Cooper
@ 2019-04-10 12:23 ` Ville Syrjälä
2019-04-11 3:08 ` Chiou, Cooper
0 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2019-04-10 12:23 UTC (permalink / raw)
To: Chiou, Cooper; +Cc: Nikula, Jani, intel-gfx
On Wed, Apr 10, 2019 at 11:32:47AM +0000, Chiou, Cooper wrote:
> Hi Ville,
>
>
>
> From BSpec define, HDMI max data rate is “Bits 5-7” not Bits 4-7. And the following image is what I captured by latest VBT BMP v2.67 tool to load GLK VBT bin file and changed HDMI_MAX_TMDS_Bit_Rate field in 5.94/2.97/1.65Gbps different bit-rate.
>
>
>
> A. 5.94Gbps(HDMI_MAX_DATA_RATE_PLATFORM) = 0 is correct, the “HDMI max data rate and level shift” value is 0x08 in following highlight block.
>
>
>
> B. 2.97Gbps (HDMI_MAX_DATA_RATE_297) was 1 is wrong, it should be 001x xxxx. In this case, “HDMI max data rate and level shift value” is “0x28” in vbt.bin, so intel_vbt_defs.h HDMI_MAX_DATA_RATE_297=1 is wrong, so it should be 2
No. Read the struct definition:
struct child_device_config {
u16 handle;
u16 device_type; /* See DEVICE_TYPE_* above */
union {
u8 device_id[10]; /* ascii string */
struct {
u8 i2c_speed;
u8 dp_onboard_redriver; /* 158 */
u8 dp_ondock_redriver; /* 158 */
u8 hdmi_level_shifter_value:5; /* 169 */
u8 hdmi_max_data_rate:3; /* 204 */
That bitfield matches the spec.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
2019-04-10 12:23 ` Ville Syrjälä
@ 2019-04-11 3:08 ` Chiou, Cooper
0 siblings, 0 replies; 12+ messages in thread
From: Chiou, Cooper @ 2019-04-11 3:08 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Nikula, Jani, intel-gfx
Thanks Ville,
I'll backport your patch (drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes) to CrOS kernel for resolving this issue. Please abandon my patch.
Best Regards,
Cooper
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-04-11 3:08 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 10:07 [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT Chiou, Cooper
2019-04-09 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-09 12:44 ` [PATCH] " Ville Syrjälä
2019-04-09 15:46 ` Chiou, Cooper
2019-04-09 15:57 ` Ville Syrjälä
2019-04-10 10:08 ` Chiou, Cooper
2019-04-10 10:50 ` Ville Syrjälä
2019-04-10 11:32 ` Chiou, Cooper
2019-04-10 12:23 ` Ville Syrjälä
2019-04-11 3:08 ` Chiou, Cooper
2019-04-09 15:34 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-04-09 17:10 ` ✗ Fi.CI.BAT: failure for drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.