* [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver
@ 2019-01-15 20:11 Heiner Kallweit
2019-01-15 22:30 ` Florian Fainelli
2019-01-17 4:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2019-01-15 20:11 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev
This workaround attempt helped for some but not all affected users.
With commit 11287b693d03 ("r8169: load Realtek PHY driver module
before r8169") we have a better workaround now, so we an remove
the first attempt.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/phy_device.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 51990002d..a2423cbb2 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -2250,14 +2250,6 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner)
new_driver->mdiodrv.driver.remove = phy_remove;
new_driver->mdiodrv.driver.owner = owner;
- /* The following works around an issue where the PHY driver doesn't bind
- * to the device, resulting in the genphy driver being used instead of
- * the dedicated driver. The root cause of the issue isn't known yet
- * and seems to be in the base driver core. Once this is fixed we may
- * remove this workaround.
- */
- new_driver->mdiodrv.driver.probe_type = PROBE_FORCE_SYNCHRONOUS;
-
retval = driver_register(&new_driver->mdiodrv.driver);
if (retval) {
pr_err("%s: Error %d in registering driver\n",
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver
2019-01-15 20:11 [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver Heiner Kallweit
@ 2019-01-15 22:30 ` Florian Fainelli
2019-01-17 4:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-01-15 22:30 UTC (permalink / raw)
To: Heiner Kallweit, Andrew Lunn, David Miller; +Cc: netdev
On 1/15/19 12:11 PM, Heiner Kallweit wrote:
> This workaround attempt helped for some but not all affected users.
> With commit 11287b693d03 ("r8169: load Realtek PHY driver module
> before r8169") we have a better workaround now, so we an remove
> the first attempt.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver
2019-01-15 20:11 [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver Heiner Kallweit
2019-01-15 22:30 ` Florian Fainelli
@ 2019-01-17 4:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-17 4:57 UTC (permalink / raw)
To: hkallweit1; +Cc: andrew, f.fainelli, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 15 Jan 2019 21:11:14 +0100
> This workaround attempt helped for some but not all affected users.
> With commit 11287b693d03 ("r8169: load Realtek PHY driver module
> before r8169") we have a better workaround now, so we an remove
> the first attempt.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-17 4:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 20:11 [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver Heiner Kallweit
2019-01-15 22:30 ` Florian Fainelli
2019-01-17 4:57 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.