* [PATCH rt-tests v1 0/2] Fix printf format specifier @ 2021-02-19 16:33 Daniel Wagner 2021-02-19 16:33 ` [PATCH rt-tests v1 1/2] cyclictest: " Daniel Wagner 2021-02-19 16:33 ` [PATCH rt-tests v1 2/2] cyclicdeadline.c: " Daniel Wagner 0 siblings, 2 replies; 5+ messages in thread From: Daniel Wagner @ 2021-02-19 16:33 UTC (permalink / raw) To: Clark Williams, John Kacur; +Cc: linux-rt-users, Daniel Wagner A couple of fallouts from the JSON patches. Daniel Wagner (2): cyclictest: Fix printf format specifier cyclicdeadline.c: Fix printf format specifier src/cyclictest/cyclictest.c | 8 ++++---- src/sched_deadline/cyclicdeadline.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) -- 2.30.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH rt-tests v1 1/2] cyclictest: Fix printf format specifier 2021-02-19 16:33 [PATCH rt-tests v1 0/2] Fix printf format specifier Daniel Wagner @ 2021-02-19 16:33 ` Daniel Wagner 2021-03-03 23:29 ` John Kacur 2021-02-19 16:33 ` [PATCH rt-tests v1 2/2] cyclicdeadline.c: " Daniel Wagner 1 sibling, 1 reply; 5+ messages in thread From: Daniel Wagner @ 2021-02-19 16:33 UTC (permalink / raw) To: Clark Williams, John Kacur; +Cc: linux-rt-users, Daniel Wagner The fields are not uint64 just longs, update the printf format specifiers. Signed-off-by: Daniel Wagner <dwagner@suse.de> --- src/cyclictest/cyclictest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c index c3d45f3ae31b..da502d426a8c 100644 --- a/src/cyclictest/cyclictest.c +++ b/src/cyclictest/cyclictest.c @@ -1732,15 +1732,15 @@ static void write_stats(FILE *f, void *data) if (s->hist_array[j] == 0) continue; fprintf(f, "%s", comma ? ",\n" : "\n"); - fprintf(f, " \"%u\": %" PRIu64, j, s->hist_array[j]); + fprintf(f, " \"%u\": %ld", j, s->hist_array[j]); comma = 1; } if (comma) fprintf(f, "\n"); fprintf(f, " },\n"); - fprintf(f, " \"cycles\": %" PRIu64 ",\n", s->cycles); - fprintf(f, " \"min\": %" PRIu64 ",\n", s->min); - fprintf(f, " \"max\": %" PRIu64 ",\n", s->max); + fprintf(f, " \"cycles\": %ld,\n", s->cycles); + fprintf(f, " \"min\": %ld,\n", s->min); + fprintf(f, " \"max\": %ld,\n", s->max); fprintf(f, " \"avg\": %.2f,\n", s->avg/s->cycles); fprintf(f, " \"cpu\": %d,\n", par[i]->cpu); fprintf(f, " \"node\": %d\n", par[i]->node); -- 2.30.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH rt-tests v1 1/2] cyclictest: Fix printf format specifier 2021-02-19 16:33 ` [PATCH rt-tests v1 1/2] cyclictest: " Daniel Wagner @ 2021-03-03 23:29 ` John Kacur 0 siblings, 0 replies; 5+ messages in thread From: John Kacur @ 2021-03-03 23:29 UTC (permalink / raw) To: Daniel Wagner; +Cc: Clark Williams, linux-rt-users On Fri, 19 Feb 2021, Daniel Wagner wrote: > The fields are not uint64 just longs, update the printf format > specifiers. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > src/cyclictest/cyclictest.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c > index c3d45f3ae31b..da502d426a8c 100644 > --- a/src/cyclictest/cyclictest.c > +++ b/src/cyclictest/cyclictest.c > @@ -1732,15 +1732,15 @@ static void write_stats(FILE *f, void *data) > if (s->hist_array[j] == 0) > continue; > fprintf(f, "%s", comma ? ",\n" : "\n"); > - fprintf(f, " \"%u\": %" PRIu64, j, s->hist_array[j]); > + fprintf(f, " \"%u\": %ld", j, s->hist_array[j]); > comma = 1; > } > if (comma) > fprintf(f, "\n"); > fprintf(f, " },\n"); > - fprintf(f, " \"cycles\": %" PRIu64 ",\n", s->cycles); > - fprintf(f, " \"min\": %" PRIu64 ",\n", s->min); > - fprintf(f, " \"max\": %" PRIu64 ",\n", s->max); > + fprintf(f, " \"cycles\": %ld,\n", s->cycles); > + fprintf(f, " \"min\": %ld,\n", s->min); > + fprintf(f, " \"max\": %ld,\n", s->max); > fprintf(f, " \"avg\": %.2f,\n", s->avg/s->cycles); > fprintf(f, " \"cpu\": %d,\n", par[i]->cpu); > fprintf(f, " \"node\": %d\n", par[i]->node); > -- > 2.30.0 > > Also Reported-by: Signed-off-by: Christian Eggers <ceggers@arri.de> Signed-off-by: John Kacur <jkacur@redhat.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH rt-tests v1 2/2] cyclicdeadline.c: Fix printf format specifier 2021-02-19 16:33 [PATCH rt-tests v1 0/2] Fix printf format specifier Daniel Wagner 2021-02-19 16:33 ` [PATCH rt-tests v1 1/2] cyclictest: " Daniel Wagner @ 2021-02-19 16:33 ` Daniel Wagner 2021-03-03 23:29 ` John Kacur 1 sibling, 1 reply; 5+ messages in thread From: Daniel Wagner @ 2021-02-19 16:33 UTC (permalink / raw) To: Clark Williams, John Kacur; +Cc: linux-rt-users, Daniel Wagner The fields are not uint64 just longs, update the printf format specifiers. Signed-off-by: Daniel Wagner <dwagner@suse.de> --- src/sched_deadline/cyclicdeadline.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c index ed3c960d9916..bb8ffc3642bc 100644 --- a/src/sched_deadline/cyclicdeadline.c +++ b/src/sched_deadline/cyclicdeadline.c @@ -978,9 +978,9 @@ static void write_stats(FILE *f, void *data) for (i = 0; i < nr_threads; i++) { s = &sd[i].stat; fprintf(f, " \"%u\": {\n", i); - fprintf(f, " \"cycles\": %" PRIu64 ",\n", s->cycles); - fprintf(f, " \"min\": %" PRIu64 ",\n", s->min); - fprintf(f, " \"max\": %" PRIu64 ",\n", s->max); + fprintf(f, " \"cycles\": %ld,\n", s->cycles); + fprintf(f, " \"min\": %ld,\n", s->min); + fprintf(f, " \"max\": %ld\n", s->max); fprintf(f, " \"avg\": %.2f\n", s->avg/s->cycles); fprintf(f, " }%s\n", i == nr_threads - 1 ? "" : ","); } -- 2.30.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH rt-tests v1 2/2] cyclicdeadline.c: Fix printf format specifier 2021-02-19 16:33 ` [PATCH rt-tests v1 2/2] cyclicdeadline.c: " Daniel Wagner @ 2021-03-03 23:29 ` John Kacur 0 siblings, 0 replies; 5+ messages in thread From: John Kacur @ 2021-03-03 23:29 UTC (permalink / raw) To: Daniel Wagner; +Cc: Clark Williams, linux-rt-users On Fri, 19 Feb 2021, Daniel Wagner wrote: > The fields are not uint64 just longs, update the printf format > specifiers. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > src/sched_deadline/cyclicdeadline.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c > index ed3c960d9916..bb8ffc3642bc 100644 > --- a/src/sched_deadline/cyclicdeadline.c > +++ b/src/sched_deadline/cyclicdeadline.c > @@ -978,9 +978,9 @@ static void write_stats(FILE *f, void *data) > for (i = 0; i < nr_threads; i++) { > s = &sd[i].stat; > fprintf(f, " \"%u\": {\n", i); > - fprintf(f, " \"cycles\": %" PRIu64 ",\n", s->cycles); > - fprintf(f, " \"min\": %" PRIu64 ",\n", s->min); > - fprintf(f, " \"max\": %" PRIu64 ",\n", s->max); > + fprintf(f, " \"cycles\": %ld,\n", s->cycles); > + fprintf(f, " \"min\": %ld,\n", s->min); > + fprintf(f, " \"max\": %ld\n", s->max); > fprintf(f, " \"avg\": %.2f\n", s->avg/s->cycles); > fprintf(f, " }%s\n", i == nr_threads - 1 ? "" : ","); > } > -- > 2.30.0 > > Also Reported-by: Signed-off-by: Christian Eggers <ceggers@arri.de> Signed-off-by: John Kacur <jkacur@redhat.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-04 0:22 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-19 16:33 [PATCH rt-tests v1 0/2] Fix printf format specifier Daniel Wagner 2021-02-19 16:33 ` [PATCH rt-tests v1 1/2] cyclictest: " Daniel Wagner 2021-03-03 23:29 ` John Kacur 2021-02-19 16:33 ` [PATCH rt-tests v1 2/2] cyclicdeadline.c: " Daniel Wagner 2021-03-03 23:29 ` John Kacur
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.