* [PATCH 1/1] test/py: use actual core count for parallel builds
@ 2020-05-30 22:44 Heinrich Schuchardt
2020-05-31 14:08 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2020-05-30 22:44 UTC (permalink / raw)
To: u-boot
When building U-Boot we should not blindly use make -j8 but consider the
actual core count given by os.cpu_count().
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
test/py/conftest.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/py/conftest.py b/test/py/conftest.py
index e3392ff6bc..30920474b3 100644
--- a/test/py/conftest.py
+++ b/test/py/conftest.py
@@ -156,7 +156,7 @@ def pytest_configure(config):
o_opt = ''
cmds = (
['make', o_opt, '-s', board_type + '_defconfig'],
- ['make', o_opt, '-s', '-j8'],
+ ['make', o_opt, '-s', '-j{}'.format(os.cpu_count())],
)
name = 'make'
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] test/py: use actual core count for parallel builds
2020-05-30 22:44 [PATCH 1/1] test/py: use actual core count for parallel builds Heinrich Schuchardt
@ 2020-05-31 14:08 ` Simon Glass
2020-05-31 19:14 ` Stephen Warren
2020-06-03 16:27 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2020-05-31 14:08 UTC (permalink / raw)
To: u-boot
On Sat, 30 May 2020 at 16:44, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> When building U-Boot we should not blindly use make -j8 but consider the
> actual core count given by os.cpu_count().
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> test/py/conftest.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
I did send a patch to make this use buildman, but people were not keen
on the extra dependency.
> diff --git a/test/py/conftest.py b/test/py/conftest.py
> index e3392ff6bc..30920474b3 100644
> --- a/test/py/conftest.py
> +++ b/test/py/conftest.py
> @@ -156,7 +156,7 @@ def pytest_configure(config):
> o_opt = ''
> cmds = (
> ['make', o_opt, '-s', board_type + '_defconfig'],
> - ['make', o_opt, '-s', '-j8'],
> + ['make', o_opt, '-s', '-j{}'.format(os.cpu_count())],
> )
> name = 'make'
>
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] test/py: use actual core count for parallel builds
2020-05-30 22:44 [PATCH 1/1] test/py: use actual core count for parallel builds Heinrich Schuchardt
2020-05-31 14:08 ` Simon Glass
@ 2020-05-31 19:14 ` Stephen Warren
2020-06-03 16:27 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2020-05-31 19:14 UTC (permalink / raw)
To: u-boot
On 5/30/20 4:44 PM, Heinrich Schuchardt wrote:
> When building U-Boot we should not blindly use make -j8 but consider the
> actual core count given by os.cpu_count().
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] test/py: use actual core count for parallel builds
2020-05-30 22:44 [PATCH 1/1] test/py: use actual core count for parallel builds Heinrich Schuchardt
2020-05-31 14:08 ` Simon Glass
2020-05-31 19:14 ` Stephen Warren
@ 2020-06-03 16:27 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-06-03 16:27 UTC (permalink / raw)
To: u-boot
On Sun, May 31, 2020 at 12:44:24AM +0200, Heinrich Schuchardt wrote:
> When building U-Boot we should not blindly use make -j8 but consider the
> actual core count given by os.cpu_count().
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Acked-by: Stephen Warren <swarren@nvidia.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200603/eec2c2df/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-03 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30 22:44 [PATCH 1/1] test/py: use actual core count for parallel builds Heinrich Schuchardt
2020-05-31 14:08 ` Simon Glass
2020-05-31 19:14 ` Stephen Warren
2020-06-03 16:27 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.