All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Rakesh Pillai <pillair@codeaurora.org>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: Skip wait for delete response if firmware is down
Date: Fri, 26 Jun 2020 11:27:11 -0700	[thread overview]
Message-ID: <69ea745d-8d7c-6220-ad0e-f70ffa3e242a@candelatech.com> (raw)
In-Reply-To: <1593195100-24654-3-git-send-email-pillair@codeaurora.org>



On 06/26/2020 11:11 AM, Rakesh Pillai wrote:
> Currently the driver waits for response from the
> firmware for all the delete cmds, eg: vdev_delete,
> peer delete. If the firmware is down, these wait
> will always timeout and return an error.
>
> Also during subsytems recovery, any attempt to
> send a WMI cmd to the FW will return the -ESHUTDOWN
> status, which when returned to mac80211, can cause
> unnecessary warnings to be printed on to the console,
> as shown below
>
> [ 2559.529565] Call trace:
> [ 2559.532214]  __sta_info_destroy_part2+0x160/0x168 [mac80211]
> [ 2559.538157]  __sta_info_flush+0x124/0x180 [mac80211]
> [ 2559.543402]  ieee80211_set_disassoc+0x130/0x2c0 [mac80211]
> [ 2559.549172]  ieee80211_mgd_deauth+0x238/0x25c [mac80211]
> [ 2559.554764]  ieee80211_deauth+0x24/0x30 [mac80211]
> [ 2559.559860]  cfg80211_mlme_deauth+0x258/0x2b0 [cfg80211]
> [ 2559.565446]  nl80211_deauthenticate+0xe4/0x110 [cfg80211]
> [ 2559.571064]  genl_rcv_msg+0x3a0/0x440
> [ 2559.574888]  netlink_rcv_skb+0xb4/0x11c
> [ 2559.578877]  genl_rcv+0x34/0x48
> [ 2559.582162]  netlink_unicast+0x14c/0x1e4
> [ 2559.586235]  netlink_sendmsg+0x2f0/0x360
> [ 2559.590317]  sock_sendmsg+0x44/0x5c
> [ 2559.593951]  ____sys_sendmsg+0x1c8/0x290
> [ 2559.598029]  ___sys_sendmsg+0xa8/0xfc
> [ 2559.601840]  __sys_sendmsg+0x8c/0xd0
> [ 2559.605572]  __arm64_compat_sys_sendmsg+0x2c/0x38
> [ 2559.610468]  el0_svc_common+0xa8/0x160
> [ 2559.614372]  el0_svc_compat_handler+0x2c/0x38
> [ 2559.618905]  el0_svc_compat+0x8/0x10
>
> Skip the wait for delete response from the
> firmware if the firmware is down. Also return
> success to the mac80211 calls when the peer delete
> cmd fails with return status -ESHUTDOWN.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath10k/mac.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index dc7befc..7ac6549 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -701,7 +701,8 @@ static void ath10k_wait_for_peer_delete_done(struct ath10k *ar, u32 vdev_id,
>  	unsigned long time_left;
>  	int ret;
>
> -	if (test_bit(WMI_SERVICE_SYNC_DELETE_CMDS, ar->wmi.svc_map)) {
> +	if (test_bit(WMI_SERVICE_SYNC_DELETE_CMDS, ar->wmi.svc_map) &&
> +	    test_bit(ATH10K_FLAG_CRASH_FLUSH, &ar->dev_flags)) {

Don't you mean !test_bit(ATH10K_FLAG_CRASH_FLUSH, &ar->dev_flags))  ???

Or maybe I'm just mis-reading your patch?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

WARNING: multiple messages have this Message-ID
From: Ben Greear <greearb@candelatech.com>
To: Rakesh Pillai <pillair@codeaurora.org>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: Skip wait for delete response if firmware is down
Date: Fri, 26 Jun 2020 11:27:11 -0700	[thread overview]
Message-ID: <69ea745d-8d7c-6220-ad0e-f70ffa3e242a@candelatech.com> (raw)
In-Reply-To: <1593195100-24654-3-git-send-email-pillair@codeaurora.org>



On 06/26/2020 11:11 AM, Rakesh Pillai wrote:
> Currently the driver waits for response from the
> firmware for all the delete cmds, eg: vdev_delete,
> peer delete. If the firmware is down, these wait
> will always timeout and return an error.
>
> Also during subsytems recovery, any attempt to
> send a WMI cmd to the FW will return the -ESHUTDOWN
> status, which when returned to mac80211, can cause
> unnecessary warnings to be printed on to the console,
> as shown below
>
> [ 2559.529565] Call trace:
> [ 2559.532214]  __sta_info_destroy_part2+0x160/0x168 [mac80211]
> [ 2559.538157]  __sta_info_flush+0x124/0x180 [mac80211]
> [ 2559.543402]  ieee80211_set_disassoc+0x130/0x2c0 [mac80211]
> [ 2559.549172]  ieee80211_mgd_deauth+0x238/0x25c [mac80211]
> [ 2559.554764]  ieee80211_deauth+0x24/0x30 [mac80211]
> [ 2559.559860]  cfg80211_mlme_deauth+0x258/0x2b0 [cfg80211]
> [ 2559.565446]  nl80211_deauthenticate+0xe4/0x110 [cfg80211]
> [ 2559.571064]  genl_rcv_msg+0x3a0/0x440
> [ 2559.574888]  netlink_rcv_skb+0xb4/0x11c
> [ 2559.578877]  genl_rcv+0x34/0x48
> [ 2559.582162]  netlink_unicast+0x14c/0x1e4
> [ 2559.586235]  netlink_sendmsg+0x2f0/0x360
> [ 2559.590317]  sock_sendmsg+0x44/0x5c
> [ 2559.593951]  ____sys_sendmsg+0x1c8/0x290
> [ 2559.598029]  ___sys_sendmsg+0xa8/0xfc
> [ 2559.601840]  __sys_sendmsg+0x8c/0xd0
> [ 2559.605572]  __arm64_compat_sys_sendmsg+0x2c/0x38
> [ 2559.610468]  el0_svc_common+0xa8/0x160
> [ 2559.614372]  el0_svc_compat_handler+0x2c/0x38
> [ 2559.618905]  el0_svc_compat+0x8/0x10
>
> Skip the wait for delete response from the
> firmware if the firmware is down. Also return
> success to the mac80211 calls when the peer delete
> cmd fails with return status -ESHUTDOWN.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath10k/mac.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index dc7befc..7ac6549 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -701,7 +701,8 @@ static void ath10k_wait_for_peer_delete_done(struct ath10k *ar, u32 vdev_id,
>  	unsigned long time_left;
>  	int ret;
>
> -	if (test_bit(WMI_SERVICE_SYNC_DELETE_CMDS, ar->wmi.svc_map)) {
> +	if (test_bit(WMI_SERVICE_SYNC_DELETE_CMDS, ar->wmi.svc_map) &&
> +	    test_bit(ATH10K_FLAG_CRASH_FLUSH, &ar->dev_flags)) {

Don't you mean !test_bit(ATH10K_FLAG_CRASH_FLUSH, &ar->dev_flags))  ???

Or maybe I'm just mis-reading your patch?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2020-06-26 18:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 18:11 [PATCH 0/2] ath10k: Fixes during subsystem recovery Rakesh Pillai
2020-06-26 18:11 ` Rakesh Pillai
2020-06-26 18:11 ` [PATCH 1/2] ath10k: Pause the tx queues when firmware is down Rakesh Pillai
2020-06-26 18:11   ` Rakesh Pillai
2020-06-26 18:11 ` [PATCH 2/2] ath10k: Skip wait for delete response if " Rakesh Pillai
2020-06-26 18:11   ` Rakesh Pillai
2020-06-26 18:27   ` Ben Greear [this message]
2020-06-26 18:27     ` Ben Greear
2020-06-26 18:49     ` Rakesh Pillai
2020-06-26 18:49       ` Rakesh Pillai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69ea745d-8d7c-6220-ad0e-f70ffa3e242a@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pillair@codeaurora.org \
    --subject='Re: [PATCH 2/2] ath10k: Skip wait for delete response if firmware is down' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.