[PATCH] test-runner: Fix verbose check for processes in namespaces

[PATCH] test-runner: Fix verbose check for processes in namespaces

[Andrew Zaborowski]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Check whether verbose output is enabled for process name arg[0] before
prepending the "ip netns exec" part to arg since arg[0] is going to be
"ip" after that.
---
 tools/test-runner | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/test-runner b/tools/test-runner
index 8b244e99..42f140bf 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -176,12 +176,12 @@ class Process(subprocess.Popen):
 			global config
 			self.ctx = config.ctx
 
-		if namespace:
-			args = ['ip', 'netns', 'exec', namespace] + args
-
 		if self.ctx.is_verbose(args[0], log=False):
 			self.verbose = True
 
+		if namespace:
+			args = ['ip', 'netns', 'exec', namespace] + args
+
 		if outfile:
 			self._append_outfile(outfile)
 
-- 
2.30.2

Re: [PATCH] test-runner: Fix verbose check for processes in namespaces

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi Andrew,

On 8/27/21 10:10 PM, Andrew Zaborowski wrote:
> Check whether verbose output is enabled for process name arg[0] before
> prepending the "ip netns exec" part to arg since arg[0] is going to be
> "ip" after that.
> ---
>   tools/test-runner | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Regards,
-Denis