* [PATCH mptcp-next] Squash-to: "selftests: mptcp: turn rp_filter off on each NIC"
@ 2021-06-16 13:20 Paolo Abeni
2021-06-16 13:57 ` Matthieu Baerts
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2021-06-16 13:20 UTC (permalink / raw)
To: mptcp; +Cc: Yonglong Li
"$1" is undefined in the setup loop context, $i should be used
instead, otherwise setup (and tests) will fail.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
tools/testing/selftests/net/mptcp/simult_flows.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index 6b6336d1c39d..fd63ebfe9a2b 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -60,8 +60,8 @@ setup()
for i in "$ns1" "$ns2" "$ns3";do
ip netns add $i || exit $ksft_skip
ip -net $i link set lo up
- ip netns exec $1 sysctl -q net.ipv4.conf.all.rp_filter=0
- ip netns exec $1 sysctl -q net.ipv4.conf.default.rp_filter=0
+ ip netns exec $i sysctl -q net.ipv4.conf.all.rp_filter=0
+ ip netns exec $i sysctl -q net.ipv4.conf.default.rp_filter=0
done
ip link add ns1eth1 netns "$ns1" type veth peer name ns2eth1 netns "$ns2"
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH mptcp-next] Squash-to: "selftests: mptcp: turn rp_filter off on each NIC"
2021-06-16 13:20 [PATCH mptcp-next] Squash-to: "selftests: mptcp: turn rp_filter off on each NIC" Paolo Abeni
@ 2021-06-16 13:57 ` Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2021-06-16 13:57 UTC (permalink / raw)
To: Paolo Abeni, mptcp; +Cc: Yonglong Li
Hi Paolo,
On 16/06/2021 15:20, Paolo Abeni wrote:
> "$1" is undefined in the setup loop context, $i should be used
> instead, otherwise setup (and tests) will fail.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Good catch!
- 94e9d2854eaa: "squashed" in "selftests: mptcp: turn rp_filter off on
each NIC"
- 7c34dfc3461b: "Signed-off-by" + "Co-developed-by"
- Results: bddebf30244a..2f591d25eeec
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210616T135631
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210616T135631
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 13:20 [PATCH mptcp-next] Squash-to: "selftests: mptcp: turn rp_filter off on each NIC" Paolo Abeni
2021-06-16 13:57 ` Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.