All of lore.kernel.org
 help / color / mirror / Atom feed
From: B, Ravi <ravibabu@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu
Date: Tue, 2 May 2017 13:02:24 +0000	[thread overview]
Message-ID: <6C6B28D4DC342643927BEAFCE8707BF6C0B749F3@DBDE04.ent.ti.com> (raw)
In-Reply-To: <20170502125747.GK12511@bill-the-cat>

Tom

>> >> 
>> >> I observed around 7K reduced. 
>> 
>> >I don't just mean dropping out CLI, I mean after dropping out CLI but leaving in the reset logic.  That's _still_ 7k?
>> 
>> Without this fix, with cli_simple_run_command(), size of MLO with default dra7xx_evm_defconfig is 130K.
>> With this fix, compile out cli.c, the MLO size is 126K.
>> Around 4K is space saved.

>OK.  And dropping out CLI and leaving in reset, unconditionally vs dropping out CLI and also dropping reset via DFU, what is the savings there?  Is that 3K?

7K provided earlier was wrong calculation. Sorry for confusion.

If unconditionally dropping CLI and use do_reset instead of run_command, I will save around 4K. (with this patch v2 series)
If unconditionally dropping CLI and dropping do_reset in SPL-DFU, I will save around 5K. (with this patch series + drop do_reset in SPL-DFU unconditionally)

Regards
Ravi  

  reply	other threads:[~2017-05-02 13:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 12:15 [U-Boot] [PATCH v2 0/3] spl: dfu: misc fixes and reduce MLO foot print Ravi Babu
2017-04-27 12:15 ` [U-Boot] [PATCH v2 1/3] spl: Kconfig: dfu: spl-dfu depends on SPL_RAM_SUPPORT Ravi Babu
2017-04-27 12:15 ` [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu Ravi Babu
2017-04-27 12:32   ` Tom Rini
2017-04-27 17:24     ` B, Ravi
2017-04-27 18:13       ` Tom Rini
2017-05-02 12:41         ` B, Ravi
2017-05-02 12:57           ` Tom Rini
2017-05-02 13:02             ` B, Ravi [this message]
2017-05-02 13:19               ` Tom Rini
2017-05-02 13:25                 ` B, Ravi
2017-05-02 13:56                 ` B, Ravi
2017-05-02 14:54                   ` Tom Rini
2017-05-02 14:54                     ` B, Ravi
2017-05-02 12:48         ` B, Ravi
2017-04-27 12:15 ` [U-Boot] [PATCH v2 3/3] spl: dfu: reduce spl-dfu MLO size Ravi Babu
2017-05-04 10:15 [U-Boot] [PATCH v3 0/3] spl: dfu: misc fixes and reduce MLO foot print Ravi Babu
2017-05-04 10:15 ` [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu Ravi Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6C6B28D4DC342643927BEAFCE8707BF6C0B749F3@DBDE04.ent.ti.com \
    --to=ravibabu@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.