From: B, Ravi <ravibabu@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu
Date: Tue, 2 May 2017 14:54:50 +0000 [thread overview]
Message-ID: <6C6B28D4DC342643927BEAFCE8707BF6C0B74C50@DBDE04.ent.ti.com> (raw)
In-Reply-To: <20170502145418.GM12511@bill-the-cat>
>-----Original Message-----
>From: Tom Rini [mailto:trini at konsulko.com]
>Sent: Tuesday, May 02, 2017 8:24 PM
>To: B, Ravi
>Cc: u-boot at lists.denx.de
>Subject: Re: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu
>On Tue, May 02, 2017 at 01:56:45PM +0000, B, Ravi wrote:
>> Tom
>>
>> >>Can you give the exact bytes saved in each case, with your specific compiler? I ask since I'm surprised it's more than a function being dropped by the linker in this case. diff'ing the u-boot-spl.map files would also say what is dropped and I'd be interested in that. >> (And >yes, I'm asking for more details to justify adding a Kconfig option here).
>> >>Thanks
>>
>> >Compiler : arm-linu-gnueabihif-gcc, version: 6.2-2016.11)
>>
>> >1) default dra7xx_evm_defconfig and use cli_simple_runcommand - MLO
>> >size is 129998
>> This is with no patches.
>>
>> >2) default dra7xx_evm_defconfig and dropping CLI and use do_reset - MLO size is 126130, saving is ~4K (129998-126130 = 3878 bytes).
>> This 4K saving is based on this V2 patches series (excludes only CONFIG_DFU_MMC in SPL-DFU).
>>
>> >3) default dra7xx_evm_defconfig and dropping CLI and dropping do_reset - MLO size is 125298, saving is ~5K (129998-125298 = 4708 bytes).
>> (My bad, I changed to V1 initial series in between while taking this
>> data) This 5K saving is based on this V1 patches (basically, which
>> excludes all CONFIG_DFU_<MMC/NAND/SF/TFTP> in SPL-DFU) Dropping do_reset in SPL does not reduce the MLO size. I observe do_reset is always included in spl-uboot.map whether exclude and include.
>So in other words, we don't save any space by making DFU-reset be conditionally included? Thanks!
Yes, you are correct Tom.
Thanks & Regards
Ravi
next prev parent reply other threads:[~2017-05-02 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 12:15 [U-Boot] [PATCH v2 0/3] spl: dfu: misc fixes and reduce MLO foot print Ravi Babu
2017-04-27 12:15 ` [U-Boot] [PATCH v2 1/3] spl: Kconfig: dfu: spl-dfu depends on SPL_RAM_SUPPORT Ravi Babu
2017-04-27 12:15 ` [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu Ravi Babu
2017-04-27 12:32 ` Tom Rini
2017-04-27 17:24 ` B, Ravi
2017-04-27 18:13 ` Tom Rini
2017-05-02 12:41 ` B, Ravi
2017-05-02 12:57 ` Tom Rini
2017-05-02 13:02 ` B, Ravi
2017-05-02 13:19 ` Tom Rini
2017-05-02 13:25 ` B, Ravi
2017-05-02 13:56 ` B, Ravi
2017-05-02 14:54 ` Tom Rini
2017-05-02 14:54 ` B, Ravi [this message]
2017-05-02 12:48 ` B, Ravi
2017-04-27 12:15 ` [U-Boot] [PATCH v2 3/3] spl: dfu: reduce spl-dfu MLO size Ravi Babu
2017-05-04 10:15 [U-Boot] [PATCH v3 0/3] spl: dfu: misc fixes and reduce MLO foot print Ravi Babu
2017-05-04 10:15 ` [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu Ravi Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6C6B28D4DC342643927BEAFCE8707BF6C0B74C50@DBDE04.ent.ti.com \
--to=ravibabu@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.