All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 19:24 [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe Franklin S. Cooper Jr
@ 2012-10-05 19:01 ` Gary Thomas
  2012-10-05 19:09   ` Enrico
  2012-10-05 22:08 ` Denys Dmytriyenko
  1 sibling, 1 reply; 10+ messages in thread
From: Gary Thomas @ 2012-10-05 19:01 UTC (permalink / raw)
  To: meta-ti

On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
> * Port wl12xx-firmware recipe from arago. This recipe was originally
>    named linux-firmware in arago.
> * Wl12xx-firmware provides the firmware files for use with the TI
>    Wi-Fi + Bluetooth module.
>
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>

Why not just keep the main linux-firmware recipe up to date instead of duplicate
functionality?

> ---
>   recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb |   28 ++++++++++++++++++++
>   1 files changed, 28 insertions(+), 0 deletions(-)
>   create mode 100644 recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
>
> diff --git a/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb b/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
> new file mode 100644
> index 0000000..3fa9dbb
> --- /dev/null
> +++ b/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
> @@ -0,0 +1,28 @@
> +DESCRIPTION = "Firmware files for use with TI wl12xx"
> +LICENSE = "TI-TSPA"
> +LIC_FILES_CHKSUM = "file://LICENCE;md5=ba590e1d103f891d0151609046aef9e8"
> +
> +PACKAGE_ARCH = "all"
> +
> +PR = "r0+gitr${SRCREV}"
> +
> +# This recipe provides the latest firmware files for wl12xx.
> +# Therefore, use the contents of this recipe instead of the contents
> +# of linux-firmware-wl12xx.
> +RCONFLICTS_${PN} = "linux-firmware-wl12xx"
> +RREPLACES_${PN}  = "linux-firmware-wl12xx"
> +
> +SRCREV = "38e0dd7999b9087e00d1a59306a7c22fd23246cf"
> +SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"
> +
> +S = "${WORKDIR}/git/hw/firmware"
> +
> +do_compile() {
> +	:
> +}
> +
> +do_install() {
> +	oe_runmake 'DEST_DIR=${D}' install
> +}
> +
> +FILES_${PN} = "/lib/firmware/ti-connectivity/*"
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 19:01 ` Gary Thomas
@ 2012-10-05 19:09   ` Enrico
  2012-10-05 19:20     ` Cooper Jr., Franklin
  0 siblings, 1 reply; 10+ messages in thread
From: Enrico @ 2012-10-05 19:09 UTC (permalink / raw)
  To: Gary Thomas; +Cc: meta-ti

On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
>>
>> * Port wl12xx-firmware recipe from arago. This recipe was originally
>>    named linux-firmware in arago.
>> * Wl12xx-firmware provides the firmware files for use with the TI
>>    Wi-Fi + Bluetooth module.
>>
>> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>
>
> Why not just keep the main linux-firmware recipe up to date instead of
> duplicate
> functionality?


I made myself the same question at first, but the answer was there:


>> +# This recipe provides the latest firmware files for wl12xx.
>> +# Therefore, use the contents of this recipe instead of the contents
>> +# of linux-firmware-wl12xx.

>> +SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"


Well one could ask why they are there and not in linux-firmware git
(not polemic, just curious).

Enrico


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 19:09   ` Enrico
@ 2012-10-05 19:20     ` Cooper Jr., Franklin
  2012-10-05 21:57       ` Gary Thomas
  0 siblings, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2012-10-05 19:20 UTC (permalink / raw)
  To: Enrico; +Cc: meta-ti

The custom git tree is wl12xx only not all the different components that linux-firmware provides. My understanding is that the team that works on wl12xx should be pushing it back to linux-firmware. But like I said this will contain the latest changes.

On Oct 5, 2012, at 2:09 PM, "Enrico" <ebutera@users.berlios.de> wrote:

> On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
>>> 
>>> * Port wl12xx-firmware recipe from arago. This recipe was originally
>>>   named linux-firmware in arago.
>>> * Wl12xx-firmware provides the firmware files for use with the TI
>>>   Wi-Fi + Bluetooth module.
>>> 
>>> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>> 
>> 
>> Why not just keep the main linux-firmware recipe up to date instead of
>> duplicate
>> functionality?
> 
> 
> I made myself the same question at first, but the answer was there:
> 
> 
>>> +# This recipe provides the latest firmware files for wl12xx.
>>> +# Therefore, use the contents of this recipe instead of the contents
>>> +# of linux-firmware-wl12xx.
> 
>>> +SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"
> 
> 
> Well one could ask why they are there and not in linux-firmware git
> (not polemic, just curious).
> 
> Enrico
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
@ 2012-10-05 19:24 Franklin S. Cooper Jr
  2012-10-05 19:01 ` Gary Thomas
  2012-10-05 22:08 ` Denys Dmytriyenko
  0 siblings, 2 replies; 10+ messages in thread
From: Franklin S. Cooper Jr @ 2012-10-05 19:24 UTC (permalink / raw)
  To: meta-ti

* Port wl12xx-firmware recipe from arago. This recipe was originally
  named linux-firmware in arago.
* Wl12xx-firmware provides the firmware files for use with the TI
  Wi-Fi + Bluetooth module.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb |   28 ++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
 create mode 100644 recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb

diff --git a/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb b/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
new file mode 100644
index 0000000..3fa9dbb
--- /dev/null
+++ b/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
@@ -0,0 +1,28 @@
+DESCRIPTION = "Firmware files for use with TI wl12xx"
+LICENSE = "TI-TSPA"
+LIC_FILES_CHKSUM = "file://LICENCE;md5=ba590e1d103f891d0151609046aef9e8"
+
+PACKAGE_ARCH = "all"
+
+PR = "r0+gitr${SRCREV}"
+
+# This recipe provides the latest firmware files for wl12xx.
+# Therefore, use the contents of this recipe instead of the contents
+# of linux-firmware-wl12xx.
+RCONFLICTS_${PN} = "linux-firmware-wl12xx"
+RREPLACES_${PN}  = "linux-firmware-wl12xx"
+
+SRCREV = "38e0dd7999b9087e00d1a59306a7c22fd23246cf"
+SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"
+
+S = "${WORKDIR}/git/hw/firmware"
+
+do_compile() {
+	:
+}
+
+do_install() {
+	oe_runmake 'DEST_DIR=${D}' install
+}
+
+FILES_${PN} = "/lib/firmware/ti-connectivity/*"
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 19:20     ` Cooper Jr., Franklin
@ 2012-10-05 21:57       ` Gary Thomas
  2012-10-05 22:03         ` Denys Dmytriyenko
  0 siblings, 1 reply; 10+ messages in thread
From: Gary Thomas @ 2012-10-05 21:57 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-ti

On 2012-10-05 13:20, Cooper Jr., Franklin wrote:
> The custom git tree is wl12xx only not all the different components that linux-firmware provides. My understanding is that the team that works on wl12xx should be pushing it back to linux-firmware. But like I said this will contain the latest changes.

I still don't think it should be separate.  If the upstream (TI) stuff
isn't being properly tracked (there should be an effort to make this so),
just add a .bbappend that fixes things.  I use these packages and I don't
want to have to track the "flavour of the week" to keep current.

>
> On Oct 5, 2012, at 2:09 PM, "Enrico" <ebutera@users.berlios.de> wrote:
>
>> On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>>> On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
>>>>
>>>> * Port wl12xx-firmware recipe from arago. This recipe was originally
>>>>    named linux-firmware in arago.
>>>> * Wl12xx-firmware provides the firmware files for use with the TI
>>>>    Wi-Fi + Bluetooth module.
>>>>
>>>> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>>>
>>>
>>> Why not just keep the main linux-firmware recipe up to date instead of
>>> duplicate
>>> functionality?
>>
>>
>> I made myself the same question at first, but the answer was there:
>>
>>
>>>> +# This recipe provides the latest firmware files for wl12xx.
>>>> +# Therefore, use the contents of this recipe instead of the contents
>>>> +# of linux-firmware-wl12xx.
>>
>>>> +SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"
>>
>>
>> Well one could ask why they are there and not in linux-firmware git
>> (not polemic, just curious).
>>
>> Enrico
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 21:57       ` Gary Thomas
@ 2012-10-05 22:03         ` Denys Dmytriyenko
  2012-10-05 22:09           ` Maupin, Chase
  0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2012-10-05 22:03 UTC (permalink / raw)
  To: Gary Thomas; +Cc: meta-ti

On Fri, Oct 05, 2012 at 03:57:25PM -0600, Gary Thomas wrote:
> On 2012-10-05 13:20, Cooper Jr., Franklin wrote:
> >The custom git tree is wl12xx only not all the different components that linux-firmware provides. My understanding is that the team that works on wl12xx should be pushing it back to linux-firmware. But like I said this will contain the latest changes.
> 
> I still don't think it should be separate.  If the upstream (TI) stuff
> isn't being properly tracked (there should be an effort to make this so),
> just add a .bbappend that fixes things.  I use these packages and I don't
> want to have to track the "flavour of the week" to keep current.

That would require extracting individual commits from the git tree and listing 
them in .bbappend. I would not personally mind that approach, but it may 
require extra work for the wireless team. We need to check with them...

-- 
Denys


> >On Oct 5, 2012, at 2:09 PM, "Enrico" <ebutera@users.berlios.de> wrote:
> >
> >>On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> >>>On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
> >>>>
> >>>>* Port wl12xx-firmware recipe from arago. This recipe was originally
> >>>>   named linux-firmware in arago.
> >>>>* Wl12xx-firmware provides the firmware files for use with the TI
> >>>>   Wi-Fi + Bluetooth module.
> >>>>
> >>>>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> >>>
> >>>
> >>>Why not just keep the main linux-firmware recipe up to date instead of
> >>>duplicate
> >>>functionality?
> >>
> >>
> >>I made myself the same question at first, but the answer was there:
> >>
> >>
> >>>>+# This recipe provides the latest firmware files for wl12xx.
> >>>>+# Therefore, use the contents of this recipe instead of the contents
> >>>>+# of linux-firmware-wl12xx.
> >>
> >>>>+SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"
> >>
> >>
> >>Well one could ask why they are there and not in linux-firmware git
> >>(not polemic, just curious).
> >>
> >>Enrico
> >>_______________________________________________
> >>meta-ti mailing list
> >>meta-ti@yoctoproject.org
> >>https://lists.yoctoproject.org/listinfo/meta-ti
> 
> -- 
> ------------------------------------------------------------
> Gary Thomas                 |  Consulting for the
> MLB Associates              |    Embedded world
> ------------------------------------------------------------
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 19:24 [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe Franklin S. Cooper Jr
  2012-10-05 19:01 ` Gary Thomas
@ 2012-10-05 22:08 ` Denys Dmytriyenko
  1 sibling, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2012-10-05 22:08 UTC (permalink / raw)
  To: Franklin S. Cooper Jr; +Cc: meta-ti

On Fri, Oct 05, 2012 at 02:24:41PM -0500, Franklin S. Cooper Jr wrote:
> * Port wl12xx-firmware recipe from arago. This recipe was originally
>   named linux-firmware in arago.
> * Wl12xx-firmware provides the firmware files for use with the TI
>   Wi-Fi + Bluetooth module.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
>  recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb |   28 ++++++++++++++++++++
>  1 files changed, 28 insertions(+), 0 deletions(-)
>  create mode 100644 recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
> 
> diff --git a/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb b/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
> new file mode 100644
> index 0000000..3fa9dbb
> --- /dev/null
> +++ b/recipes-bsp/wl12xx-firmware/wl12xx-firmware_git.bb
> @@ -0,0 +1,28 @@
> +DESCRIPTION = "Firmware files for use with TI wl12xx"
> +LICENSE = "TI-TSPA"
> +LIC_FILES_CHKSUM = "file://LICENCE;md5=ba590e1d103f891d0151609046aef9e8"
> +
> +PACKAGE_ARCH = "all"
> +
> +PR = "r0+gitr${SRCREV}"
> +
> +# This recipe provides the latest firmware files for wl12xx.
> +# Therefore, use the contents of this recipe instead of the contents
> +# of linux-firmware-wl12xx.
> +RCONFLICTS_${PN} = "linux-firmware-wl12xx"
> +RREPLACES_${PN}  = "linux-firmware-wl12xx"

BTW, the other thing to consider here, is also adding RPROVIDES_${PN} = 
"linux-firmware-wl12xx" as that should prevent mixing both in the same image 
by failing early on...

-- 
Denys


> +SRCREV = "38e0dd7999b9087e00d1a59306a7c22fd23246cf"
> +SRC_URI = "git://github.com/TI-ECS/ti-utils.git;protocol=git"
> +
> +S = "${WORKDIR}/git/hw/firmware"
> +
> +do_compile() {
> +	:
> +}
> +
> +do_install() {
> +	oe_runmake 'DEST_DIR=${D}' install
> +}
> +
> +FILES_${PN} = "/lib/firmware/ti-connectivity/*"
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 22:03         ` Denys Dmytriyenko
@ 2012-10-05 22:09           ` Maupin, Chase
  2012-10-05 22:11             ` Cooper Jr., Franklin
  2012-10-05 22:14             ` Gary Thomas
  0 siblings, 2 replies; 10+ messages in thread
From: Maupin, Chase @ 2012-10-05 22:09 UTC (permalink / raw)
  To: Dmytriyenko, Denys, Gary Thomas; +Cc: meta-ti

> -----Original Message-----
> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> bounces@yoctoproject.org] On Behalf Of Dmytriyenko, Denys
> Sent: Friday, October 05, 2012 5:04 PM
> To: Gary Thomas
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH] wl12xx-firmware: Port wl12xx-
> firmware recipe
> 
> On Fri, Oct 05, 2012 at 03:57:25PM -0600, Gary Thomas wrote:
> > On 2012-10-05 13:20, Cooper Jr., Franklin wrote:
> > >The custom git tree is wl12xx only not all the different
> components that linux-firmware provides. My understanding is that
> the team that works on wl12xx should be pushing it back to linux-
> firmware. But like I said this will contain the latest changes.
> >
> > I still don't think it should be separate.  If the upstream
> (TI) stuff
> > isn't being properly tracked (there should be an effort to make
> this so),
> > just add a .bbappend that fixes things.  I use these packages
> and I don't
> > want to have to track the "flavour of the week" to keep
> current.
> 
> That would require extracting individual commits from the git
> tree and listing
> them in .bbappend. I would not personally mind that approach, but
> it may
> require extra work for the wireless team. We need to check with
> them...

Couldn't you use the bbappend to just change the SRC_URI and SRCREV?  Is the issue the recipe name changing from linux-firmware to wl12xx-firmware?

Wireless team went with their own recipe because of the issues with tracking/maintaining the patch set from their development team.  I know this may not make sense outside of TI but there is a development team in wireless making and pushing changes to mainline and then there is the integration team responsible for providing the validated code drop.  I'm not saying this is a good work flow, but the integration team pushed to get a single repo of the proper sources from the development team because the patch set was un-wieldy.

That's just a little context of what I know about how these recipes were created.  So again my question is what is the particular pain point you want to avoid?  The name of the recipe or something else?

> 
> --
> Denys
> 
> 
> > >On Oct 5, 2012, at 2:09 PM, "Enrico"
> <ebutera@users.berlios.de> wrote:
> > >
> > >>On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas
> <gary@mlbassoc.com> wrote:
> > >>>On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
> > >>>>
> > >>>>* Port wl12xx-firmware recipe from arago. This recipe was
> originally
> > >>>>   named linux-firmware in arago.
> > >>>>* Wl12xx-firmware provides the firmware files for use with
> the TI
> > >>>>   Wi-Fi + Bluetooth module.
> > >>>>
> > >>>>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > >>>
> > >>>
> > >>>Why not just keep the main linux-firmware recipe up to date
> instead of
> > >>>duplicate
> > >>>functionality?
> > >>
> > >>
> > >>I made myself the same question at first, but the answer was
> there:
> > >>
> > >>
> > >>>>+# This recipe provides the latest firmware files for
> wl12xx.
> > >>>>+# Therefore, use the contents of this recipe instead of
> the contents
> > >>>>+# of linux-firmware-wl12xx.
> > >>
> > >>>>+SRC_URI = "git://github.com/TI-ECS/ti-
> utils.git;protocol=git"
> > >>
> > >>
> > >>Well one could ask why they are there and not in linux-
> firmware git
> > >>(not polemic, just curious).
> > >>
> > >>Enrico
> > >>_______________________________________________
> > >>meta-ti mailing list
> > >>meta-ti@yoctoproject.org
> > >>https://lists.yoctoproject.org/listinfo/meta-ti
> >
> > --
> > ------------------------------------------------------------
> > Gary Thomas                 |  Consulting for the
> > MLB Associates              |    Embedded world
> > ------------------------------------------------------------
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> >
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 22:09           ` Maupin, Chase
@ 2012-10-05 22:11             ` Cooper Jr., Franklin
  2012-10-05 22:14             ` Gary Thomas
  1 sibling, 0 replies; 10+ messages in thread
From: Cooper Jr., Franklin @ 2012-10-05 22:11 UTC (permalink / raw)
  To: Maupin, Chase, Dmytriyenko, Denys, Gary Thomas; +Cc: meta-ti

You can't just change the recipe name to linux-firmware because the contents of this repo doesn't contain everything linux-firmware includes. This repo contains only wl2xx related files.

-----Original Message-----
From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-bounces@yoctoproject.org] On Behalf Of Maupin, Chase
Sent: Friday, October 05, 2012 5:10 PM
To: Dmytriyenko, Denys; Gary Thomas
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe

> -----Original Message-----
> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- 
> bounces@yoctoproject.org] On Behalf Of Dmytriyenko, Denys
> Sent: Friday, October 05, 2012 5:04 PM
> To: Gary Thomas
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH] wl12xx-firmware: Port wl12xx- firmware 
> recipe
> 
> On Fri, Oct 05, 2012 at 03:57:25PM -0600, Gary Thomas wrote:
> > On 2012-10-05 13:20, Cooper Jr., Franklin wrote:
> > >The custom git tree is wl12xx only not all the different
> components that linux-firmware provides. My understanding is that the 
> team that works on wl12xx should be pushing it back to linux- 
> firmware. But like I said this will contain the latest changes.
> >
> > I still don't think it should be separate.  If the upstream
> (TI) stuff
> > isn't being properly tracked (there should be an effort to make
> this so),
> > just add a .bbappend that fixes things.  I use these packages
> and I don't
> > want to have to track the "flavour of the week" to keep
> current.
> 
> That would require extracting individual commits from the git tree and 
> listing them in .bbappend. I would not personally mind that approach, 
> but it may require extra work for the wireless team. We need to check 
> with them...

Couldn't you use the bbappend to just change the SRC_URI and SRCREV?  Is the issue the recipe name changing from linux-firmware to wl12xx-firmware?

Wireless team went with their own recipe because of the issues with tracking/maintaining the patch set from their development team.  I know this may not make sense outside of TI but there is a development team in wireless making and pushing changes to mainline and then there is the integration team responsible for providing the validated code drop.  I'm not saying this is a good work flow, but the integration team pushed to get a single repo of the proper sources from the development team because the patch set was un-wieldy.

That's just a little context of what I know about how these recipes were created.  So again my question is what is the particular pain point you want to avoid?  The name of the recipe or something else?

> 
> --
> Denys
> 
> 
> > >On Oct 5, 2012, at 2:09 PM, "Enrico"
> <ebutera@users.berlios.de> wrote:
> > >
> > >>On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas
> <gary@mlbassoc.com> wrote:
> > >>>On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
> > >>>>
> > >>>>* Port wl12xx-firmware recipe from arago. This recipe was
> originally
> > >>>>   named linux-firmware in arago.
> > >>>>* Wl12xx-firmware provides the firmware files for use with
> the TI
> > >>>>   Wi-Fi + Bluetooth module.
> > >>>>
> > >>>>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > >>>
> > >>>
> > >>>Why not just keep the main linux-firmware recipe up to date
> instead of
> > >>>duplicate
> > >>>functionality?
> > >>
> > >>
> > >>I made myself the same question at first, but the answer was
> there:
> > >>
> > >>
> > >>>>+# This recipe provides the latest firmware files for
> wl12xx.
> > >>>>+# Therefore, use the contents of this recipe instead of
> the contents
> > >>>>+# of linux-firmware-wl12xx.
> > >>
> > >>>>+SRC_URI = "git://github.com/TI-ECS/ti-
> utils.git;protocol=git"
> > >>
> > >>
> > >>Well one could ask why they are there and not in linux-
> firmware git
> > >>(not polemic, just curious).
> > >>
> > >>Enrico
> > >>_______________________________________________
> > >>meta-ti mailing list
> > >>meta-ti@yoctoproject.org
> > >>https://lists.yoctoproject.org/listinfo/meta-ti
> >
> > --
> > ------------------------------------------------------------
> > Gary Thomas                 |  Consulting for the
> > MLB Associates              |    Embedded world
> > ------------------------------------------------------------
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> >
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
_______________________________________________
meta-ti mailing list
meta-ti@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe
  2012-10-05 22:09           ` Maupin, Chase
  2012-10-05 22:11             ` Cooper Jr., Franklin
@ 2012-10-05 22:14             ` Gary Thomas
  1 sibling, 0 replies; 10+ messages in thread
From: Gary Thomas @ 2012-10-05 22:14 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-ti

On 2012-10-05 16:09, Maupin, Chase wrote:
>> -----Original Message-----
>> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>> bounces@yoctoproject.org] On Behalf Of Dmytriyenko, Denys
>> Sent: Friday, October 05, 2012 5:04 PM
>> To: Gary Thomas
>> Cc: meta-ti@yoctoproject.org
>> Subject: Re: [meta-ti] [PATCH] wl12xx-firmware: Port wl12xx-
>> firmware recipe
>>
>> On Fri, Oct 05, 2012 at 03:57:25PM -0600, Gary Thomas wrote:
>>> On 2012-10-05 13:20, Cooper Jr., Franklin wrote:
>>>> The custom git tree is wl12xx only not all the different
>> components that linux-firmware provides. My understanding is that
>> the team that works on wl12xx should be pushing it back to linux-
>> firmware. But like I said this will contain the latest changes.
>>>
>>> I still don't think it should be separate.  If the upstream
>> (TI) stuff
>>> isn't being properly tracked (there should be an effort to make
>> this so),
>>> just add a .bbappend that fixes things.  I use these packages
>> and I don't
>>> want to have to track the "flavour of the week" to keep
>> current.
>>
>> That would require extracting individual commits from the git
>> tree and listing
>> them in .bbappend. I would not personally mind that approach, but
>> it may
>> require extra work for the wireless team. We need to check with
>> them...
>
> Couldn't you use the bbappend to just change the SRC_URI and SRCREV?  Is the issue the recipe name changing from linux-firmware to wl12xx-firmware?
>
> Wireless team went with their own recipe because of the issues with tracking/maintaining the patch set from their development team.  I know this may not make sense outside of TI but there is a development team in wireless making and pushing changes to mainline and then there is the integration team responsible for providing the validated code drop.  I'm not saying this is a good work flow, but the integration team pushed to get a single repo of the proper sources from the development team because the patch set was un-wieldy.
>
> That's just a little context of what I know about how these recipes were created.  So again my question is what is the particular pain point you want to avoid?  The name of the recipe or something else?

My biggest concern was that currently my images use 'linux-firmware-wl12xx'
and now, for the same but updated functionality, I need to use 'wl12xx-firmware'
instead.  What will it be next week?  wl12xx-I-like-Maui-better??

Get my point?

>>>> On Oct 5, 2012, at 2:09 PM, "Enrico"
>> <ebutera@users.berlios.de> wrote:
>>>>
>>>>> On Fri, Oct 5, 2012 at 9:01 PM, Gary Thomas
>> <gary@mlbassoc.com> wrote:
>>>>>> On 2012-10-05 13:24, Franklin S. Cooper Jr wrote:
>>>>>>>
>>>>>>> * Port wl12xx-firmware recipe from arago. This recipe was
>> originally
>>>>>>>    named linux-firmware in arago.
>>>>>>> * Wl12xx-firmware provides the firmware files for use with
>> the TI
>>>>>>>    Wi-Fi + Bluetooth module.
>>>>>>>
>>>>>>> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>>>>>>
>>>>>>
>>>>>> Why not just keep the main linux-firmware recipe up to date
>> instead of
>>>>>> duplicate
>>>>>> functionality?
>>>>>
>>>>>
>>>>> I made myself the same question at first, but the answer was
>> there:
>>>>>
>>>>>
>>>>>>> +# This recipe provides the latest firmware files for
>> wl12xx.
>>>>>>> +# Therefore, use the contents of this recipe instead of
>> the contents
>>>>>>> +# of linux-firmware-wl12xx.
>>>>>
>>>>>>> +SRC_URI = "git://github.com/TI-ECS/ti-
>> utils.git;protocol=git"
>>>>>
>>>>>
>>>>> Well one could ask why they are there and not in linux-
>> firmware git
>>>>> (not polemic, just curious).
>>>>>
>>>>> Enrico
>>>>> _______________________________________________
>>>>> meta-ti mailing list
>>>>> meta-ti@yoctoproject.org
>>>>> https://lists.yoctoproject.org/listinfo/meta-ti
>>>
>>> --
>>> ------------------------------------------------------------
>>> Gary Thomas                 |  Consulting for the
>>> MLB Associates              |    Embedded world
>>> ------------------------------------------------------------
>>> _______________________________________________
>>> meta-ti mailing list
>>> meta-ti@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-ti
>>>
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2012-10-05 22:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-05 19:24 [PATCH] wl12xx-firmware: Port wl12xx-firmware recipe Franklin S. Cooper Jr
2012-10-05 19:01 ` Gary Thomas
2012-10-05 19:09   ` Enrico
2012-10-05 19:20     ` Cooper Jr., Franklin
2012-10-05 21:57       ` Gary Thomas
2012-10-05 22:03         ` Denys Dmytriyenko
2012-10-05 22:09           ` Maupin, Chase
2012-10-05 22:11             ` Cooper Jr., Franklin
2012-10-05 22:14             ` Gary Thomas
2012-10-05 22:08 ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.