From: vishwanatha subbanna <vishwa@linux.vnet.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: vishwanatha subbanna <vishwa@linux.vnet.ibm.com>,
Eddie James <eajames@linux.ibm.com>,
Andrew Jeffery <andrew@aj.id.au>,
Brad Bishop <bradleyb@fuzziesquirrel.com>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 6/6] ARM: dts: aspeed: rainier: Add leds that are on optional PCI cable cards
Date: Wed, 10 Feb 2021 16:46:57 +0530 [thread overview]
Message-ID: <6CFB3D8D-CF5A-4E33-8D57-6A4034DDC49E@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACPK8XfttMptuYFsocBaj2v4z1vzNjDUfe18FeDcAbmZjWKjfQ@mail.gmail.com>
> On 16-Nov-2020, at 11:43 AM, Joel Stanley <joel@jms.id.au> wrote:
>
> On Fri, 13 Nov 2020 at 05:59, Vishwanatha Subbanna
> <vishwa@linux.vnet.ibm.com> wrote:
>>
>> These are LEDs on the cable cards that plug into PCIE slots.
>> The LEDs are controlled by PCA9552 I2C expander
>>
>> Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 288 +++++++++++++++++++++++++++
>> 1 file changed, 288 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> index 67c8c40..7de5f76 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> @@ -696,6 +696,70 @@
>> gpios = <&pca4 7 GPIO_ACTIVE_LOW>;
>> };
>> };
>> +
>> + leds-optional-cablecard0 {
>
> Is it necessary to have separate nodes for each of the different GPIO devices?
>
> Would it make sense to combine them, or is it better to be separate?
>
> Andrew, Eddie, Brad: please review this one before I merge it.
I answered this in previous patch set. If I express ‘em all in one node that is “leds {", then if any of the GPIO is not seen because of not having the card, then the current leds-gpio driver knocks off all the ones on which it successfully acquired the GPIOs also, leaving nothing. I did speak to the maintainer and it looked like the behaviour was existing since long time and changing it would break old code.
>
>> + compatible = "gpio-leds";
>> +
>> + cablecard0-cxp-top {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca5 0 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + cablecard0-cxp-bot {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca5 1 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +
>> + leds-optional-cablecard3 {
>> + compatible = "gpio-leds";
>> +
>> + cablecard3-cxp-top {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca6 0 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + cablecard3-cxp-bot {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca6 1 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +
>> + leds-optional-cablecard4 {
>> + compatible = "gpio-leds";
>> +
>> + cablecard4-cxp-top {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca7 0 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + cablecard4-cxp-bot {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca7 1 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +
>> + leds-optional-cablecard10 {
>> + compatible = "gpio-leds";
>> +
>> + cablecard10-cxp-top {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca8 0 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + cablecard10-cxp-bot {
>> + retain-state-shutdown;
>> + default-state = "keep";
>> + gpios = <&pca8 1 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> };
>>
>> &ehci1 {
>> @@ -1212,6 +1276,180 @@
>> compatible = "atmel,24c64";
>> reg = <0x52>;
>> };
>> +
>> + pca5: pca9551@60 {
>> + compatible = "nxp,pca9551";
>> + reg = <0x60>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + gpio@0 {
>> + reg = <0>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@1 {
>> + reg = <1>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@2 {
>> + reg = <2>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@3 {
>> + reg = <3>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@4 {
>> + reg = <4>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@5 {
>> + reg = <5>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@6 {
>> + reg = <6>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@7 {
>> + reg = <7>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> + };
>> +};
>> +
>> +&i2c5 {
>> + status = "okay";
>> +
>> + tmp275@48 {
>> + compatible = "ti,tmp275";
>> + reg = <0x48>;
>> + };
>> +
>> + tmp275@49 {
>> + compatible = "ti,tmp275";
>> + reg = <0x49>;
>> + };
>> +
>> + eeprom@50 {
>> + compatible = "atmel,24c64";
>> + reg = <0x50>;
>> + };
>> +
>> + eeprom@51 {
>> + compatible = "atmel,24c64";
>> + reg = <0x51>;
>> + };
>> +
>> + pca6: pca9551@60 {
>> + compatible = "nxp,pca9551";
>> + reg = <0x60>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + gpio@0 {
>> + reg = <0>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@1 {
>> + reg = <1>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@2 {
>> + reg = <2>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@3 {
>> + reg = <3>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@4 {
>> + reg = <4>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@5 {
>> + reg = <5>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@6 {
>> + reg = <6>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@7 {
>> + reg = <7>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> + };
>> +
>> + pca7: pca9551@61 {
>> + compatible = "nxp,pca9551";
>> + reg = <0x61>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + gpio@0 {
>> + reg = <0>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@1 {
>> + reg = <1>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@2 {
>> + reg = <2>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@3 {
>> + reg = <3>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@4 {
>> + reg = <4>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@5 {
>> + reg = <5>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@6 {
>> + reg = <6>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@7 {
>> + reg = <7>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> + };
>> };
>>
>> &i2c5 {
>> @@ -2028,6 +2266,56 @@
>> compatible = "atmel,24c64";
>> reg = <0x51>;
>> };
>> +
>> + pca8: pca9551@60 {
>> + compatible = "nxp,pca9551";
>> + reg = <0x60>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + gpio@0 {
>> + reg = <0>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@1 {
>> + reg = <1>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@2 {
>> + reg = <2>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@3 {
>> + reg = <3>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@4 {
>> + reg = <4>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@5 {
>> + reg = <5>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@6 {
>> + reg = <6>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> +
>> + gpio@7 {
>> + reg = <7>;
>> + type = <PCA955X_TYPE_GPIO>;
>> + };
>> + };
>> };
>>
>> &i2c12 {
>> --
>> 1.8.3.1
>>
next prev parent reply other threads:[~2021-02-10 11:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 5:59 [PATCH 1/6] ARM: dts: aspeed: rainier: Add Operator Panel LEDs Vishwanatha Subbanna
2020-11-13 5:59 ` [PATCH 2/6] ARM: dts: aspeed: rainier: Add directly controlled LEDs Vishwanatha Subbanna
2020-11-16 6:13 ` Joel Stanley
2020-11-13 5:59 ` [PATCH 3/6] ARM: dts: aspeed: rainier: Add leds that are off PCA9552 Vishwanatha Subbanna
2020-11-16 6:14 ` Joel Stanley
2021-02-10 11:22 ` vishwanatha subbanna
2020-11-13 5:59 ` [PATCH 4/6] ARM: dts: aspeed: rainier: Add leds that are off PIC16F882 Vishwanatha Subbanna
2020-11-16 6:15 ` Joel Stanley
2020-11-13 5:59 ` [PATCH 5/6] ARM: dts: aspeed: rainier: Add leds on optional DASD cards Vishwanatha Subbanna
2020-11-16 6:14 ` Joel Stanley
2020-11-13 5:59 ` [PATCH 6/6] ARM: dts: aspeed: rainier: Add leds that are on optional PCI cable cards Vishwanatha Subbanna
2020-11-16 6:13 ` Joel Stanley
2020-11-30 6:08 ` Andrew Jeffery
2021-02-10 11:14 ` vishwanatha subbanna
2021-02-10 11:16 ` vishwanatha subbanna [this message]
2021-02-14 23:08 ` Andrew Jeffery
[not found] ` <14C0B6E9-0724-42FE-89BA-1FA0262B9BBB@linux.vnet.ibm.com>
2021-02-18 22:45 ` Andrew Jeffery
2020-11-16 6:14 ` [PATCH 1/6] ARM: dts: aspeed: rainier: Add Operator Panel LEDs Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CFB3D8D-CF5A-4E33-8D57-6A4034DDC49E@linux.vnet.ibm.com \
--to=vishwa@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=bradleyb@fuzziesquirrel.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.