All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [PATCH] doc: update softnic doc for flow and qos API support
Date: Thu, 18 Oct 2018 12:24:37 +0000	[thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020382D1@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1539859449-8248-1-git-send-email-reshma.pattan@intel.com>

> Update document with flow and qos api support in softnic PMD.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>  doc/guides/nics/softnic.rst | 119
> ++++++++++++++++++++++++++++++++++++
>  1 file changed, 119 insertions(+)
id 1)
> +
> +QoS API Support:
> +----------------
> +
> +SoftNIC PMD implements ethdev traffic management APIs ``rte_tm.h`` that
> +allow building and committing traffic manager hierarchy, configuring
> +hierarchy nodes of the Quality of Service (QoS) scheduler supported by
> +DPDK librte_sched library. Furthermore, APIs for run-time update to the
> +traffic manager hierarchy are supported by PMD.
> +
> +SoftNIC PMD also implements ethdev traffic metering and policing APIs
> +``rte_mtr.h`` that enables metering and marking of the packets with the
> +appropriate color (green, yellow or red), according to the traffic
> +metering algorithm. For the meter output color, policer actions can be
> +configured which include keep the same packet color (essentially a
> +no-op action), override the color the packet or drop the packet.

The one thing here I notice is the sentence 
" policer actions can be configured which include keep the same packet color "
"which include keep" sounds weird, 
Maybe one of these
" policer actions can be configured which include the same packet color "
" policer actions can be configured which keep the same packet color "

> +.. Note:
> +
> +The SoftNIC does not support the meter object shared by several flows,
> +thus only supports creating meter object private to the flow. Once
> +meter object is successfully created, it can be linked to the specific
> +flow by specifying the ``meter`` flow action in the flow rule.

Your note doesn't come out as a note because you didn't indent your text.

Note:
> +
> +The flow must have one terminating actions i.e. ``JMP or RSS or QUEUE or
> DROP``.
> +For the count and drop actions the underlying PMD doesn't support the
> +functionality yet. So it is not recommended for use.

Same here.

Reviewed-by: Marko Kovacevic <marko.kovacevic@intel.com>

  reply	other threads:[~2018-10-18 12:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 10:44 [PATCH] doc: update softnic doc for flow and qos API support Reshma Pattan
2018-10-18 12:24 ` Kovacevic, Marko [this message]
2018-10-18 14:50 ` [PATCH v2] " Reshma Pattan
2018-10-18 14:54 ` Reshma Pattan
2018-10-26 11:08   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC05C7C5F25994B81B3F2F214251F66020382D1@IRSMSX104.ger.corp.intel.com \
    --to=marko.kovacevic@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.