All of lore.kernel.org
 help / color / mirror / Atom feed
* [master][PATCH] gcc-cross{, -canadian}: remove --with-linker-hash-style
@ 2016-05-02 20:09 Christopher Larson
  2016-05-02 20:34 ` Khem Raj
  2016-05-04 14:01 ` Burton, Ross
  0 siblings, 2 replies; 19+ messages in thread
From: Christopher Larson @ 2016-05-02 20:09 UTC (permalink / raw)
  To: openembedded-core; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

We explicitly set the hash style to gnu in our LDFLAGS. Setting the default to
this in the toolchain, while convenient, actually hides bugs, as a failure to
obey LDFLAGS isn't noticed. By removing this, it's not dissimilar to how we
poison the sysroot -- rather than relying on the default, notice right away if
somoeone isn't obeying the needed flags.

This will result in a failure to obey LDFLAGS causing a GNU_HASH QA failure,
which is what's often seen with external toolchains. This brings us all on the
same page, and makes sure a failure to obey LDFLAGS is seen early.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/recipes-devtools/gcc/gcc-4.9.inc | 1 -
 meta/recipes-devtools/gcc/gcc-5.3.inc | 1 -
 2 files changed, 2 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-4.9.inc b/meta/recipes-devtools/gcc/gcc-4.9.inc
index 7e03f31..c187918 100644
--- a/meta/recipes-devtools/gcc/gcc-4.9.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.9.inc
@@ -111,7 +111,6 @@ EXTRA_OECONF_BASE = "\
     --disable-bootstrap \
     --disable-libmudflap \
     --with-system-zlib \
-    --with-linker-hash-style=${LINKER_HASH_STYLE} \
     --enable-linker-build-id \
     --with-ppl=no \
     --with-cloog=no \
diff --git a/meta/recipes-devtools/gcc/gcc-5.3.inc b/meta/recipes-devtools/gcc/gcc-5.3.inc
index 9808be1..f2eda18 100644
--- a/meta/recipes-devtools/gcc/gcc-5.3.inc
+++ b/meta/recipes-devtools/gcc/gcc-5.3.inc
@@ -112,7 +112,6 @@ EXTRA_OECONF_BASE = "\
     --disable-bootstrap \
     --disable-libmudflap \
     --with-system-zlib \
-    --with-linker-hash-style=${LINKER_HASH_STYLE} \
     --enable-linker-build-id \
     --with-ppl=no \
     --with-cloog=no \
-- 
2.8.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2016-05-09 22:54 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-02 20:09 [master][PATCH] gcc-cross{, -canadian}: remove --with-linker-hash-style Christopher Larson
2016-05-02 20:34 ` Khem Raj
2016-05-02 20:37   ` Christopher Larson
2016-05-02 21:37     ` Khem Raj
2016-05-03  2:53       ` Christopher Larson
2016-05-03  3:01         ` Khem Raj
2016-05-03  3:05           ` Christopher Larson
2016-05-03  8:09       ` Martin Jansa
2016-05-03  9:11         ` Anders Darander
2016-05-03 16:07           ` Christopher Larson
2016-05-03 18:13         ` Denys Dmytriyenko
2016-05-04 14:01 ` Burton, Ross
2016-05-04 19:11   ` Christopher Larson
2016-05-09 16:35     ` Bystricky, Juro
2016-05-09 16:39       ` Christopher Larson
2016-05-09 22:16         ` Richard Purdie
2016-05-09 22:34           ` Christopher Larson
2016-05-09 22:41             ` Christopher Larson
2016-05-09 22:54               ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.