Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

[Pantelis Antoniou <pantelis.antoniou@konsulko.com>]

Hi Alexander,

On Jun 23, 2014, at 7:26 PM, Alexander Sverdlin wrote:

> Hello Pantelis!
> 
> On 22/06/14 11:40, ext Pantelis Antoniou wrote:
>> Introduce helper functions for working with the live DT tree,
>> all of them related to dynamically adding/removing nodes and
>> properties.
>> 
>> __of_copy_property() copies a property dynamically
>> __of_create_empty_node() creates an empty node
>> 
>> Bug fix about prop->len == 0 by Ionut Nicu <ioan.nicu.ext@nsn.com>
> 
> Are you sure about this? (see below...)
> 
>> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>> ---

[snip]
>> +
>> +	if (prop->length > 0) {
>        ^^^^^^^^^^^^^^^^^^^^^
> Seems, that length==0 case will still produce value==NULL results,
> which will brake some checks in the kernel... Or am I missing something in
> the new version?
> 

prop->value will be set to NULL, and length will be set to zero (kzalloc).
This is a normal zero length property.

I don't know of any place in the kernel accessing the value if prop->length==0


> 
>> +		if (of_property_check_flag(propn, OF_ALLOCVALUE)) {
>> +			propn->value = kmalloc(prop->length, allocflags);
>> +			if (propn->value == NULL)
>> +				goto err_fail_value;
>> +	

[snip]

>> +
>> #endif /* _LINUX_OF_H */
>> 
> 
> -- 
> Best regards,
> Alexander Sverdlin.

Regards

-- Pantelis