set power_save_node=0 as default

set power_save_node=0 as default

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi Takashi,

I measured power consumption between power_save_node=1 and power_save_node=0.
It's almost the same.
Codec will enter to runtime suspend and suspend.
That pin also will enter to D3. Don't need to enter to D3 by single pin.
So, Disable power_save_node as default. It will avoid more issues.
Windows Driver also has not this option at runtime PM.

Many Thanks.

BR,
Kailang

[-- Attachment #2: 0000-power-save-node-disable.patch --]
[-- Type: application/octet-stream, Size: 1064 bytes --]

From 408c649e1e6dcab2dff2fc02e191e7ed4a6ae5f4 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 23 May 2019 14:43:04 +0800
Subject: [PATCH] ALSA: hda/realtek - Set default power save node to 0

I measured power consumption between power_save_node=1 and power_save_node=0.
It's almost the same.
Codec will enter to runtime suspend and suspend.
That pin also will enter to D3. Don't need to enter to D3 by single pin.
So, Disable power_save_node as default. It will avoid more issues.
Windows Driver also has not this option at runtime PM.

Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f83f21d64dd4..413fc31d5a8f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7706,7 +7706,7 @@ static int patch_alc269(struct hda_codec *codec)
 
 	spec = codec->spec;
 	spec->gen.shared_mic_vref_pin = 0x18;
-	codec->power_save_node = 1;
+	codec->power_save_node = 0;
 
 #ifdef CONFIG_PM
 	codec->patch_ops.suspend = alc269_suspend;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: set power_save_node=0 as default

[Takashi Iwai]

On Thu, 23 May 2019 08:59:18 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> I measured power consumption between power_save_node=1 and power_save_node=0.
> It's almost the same.
> Codec will enter to runtime suspend and suspend.
> That pin also will enter to D3. Don't need to enter to D3 by single pin.
> So, Disable power_save_node as default. It will avoid more issues.
> Windows Driver also has not this option at runtime PM.

OK, applied now.  Thanks.


Takashi