All of lore.kernel.org
 help / color / mirror / Atom feed
* Dell Headphone Mic can't record after S3
@ 2019-07-04  8:49 Kailang
  2019-07-04 13:09 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Kailang @ 2019-07-04  8:49 UTC (permalink / raw)
  To: Takashi Iwai (tiwai@suse.de); +Cc:  (alsa-devel@alsa-project.org)

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Hi Takashi,

Headphone Mic can't record after S3 on Dell headset mode platform.
The S3 mode was deep. S2idle didn't have this issue.

BR,
Kailang

[-- Attachment #2: 0000-fix-hp-mic-recording-fail.patch --]
[-- Type: application/octet-stream, Size: 1544 bytes --]

From a820cf37e4f0b48fb6a34cb2ff1a5f6a4a7c3983 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 4 Jul 2019 16:02:10 +0800
Subject: [PATCH] ALSA: hda/realtek - Headphone Mic can't record after S3

Dell headset mode platform with ALC236.
It doesn't recording after system resume from S3.
S3 mode was deep. s2idle was not has this issue.
S3 deep will cut of codec power. So, the register will back to default after resume back.
This patch will solve this issue.

Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 48f3c5b8d6e9..0f776444ab86 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3268,6 +3268,7 @@ static void alc256_init(struct hda_codec *codec)
 	alc_update_coefex_idx(codec, 0x57, 0x04, 0x0007, 0x4); /* Hight power */
 	alc_update_coefex_idx(codec, 0x53, 0x02, 0x8000, 1 << 15); /* Clear bit */
 	alc_update_coefex_idx(codec, 0x53, 0x02, 0x8000, 0 << 15);
+	alc_update_coef_idx(codec, 0x36, 1 << 13, 1 << 5); /* Switch pcbeep path to Line in path*/
 }
 
 static void alc256_shutup(struct hda_codec *codec)
@@ -7838,7 +7839,6 @@ static int patch_alc269(struct hda_codec *codec)
 		spec->shutup = alc256_shutup;
 		spec->init_hook = alc256_init;
 		spec->gen.mixer_nid = 0; /* ALC256 does not have any loopback mixer path */
-		alc_update_coef_idx(codec, 0x36, 1 << 13, 1 << 5); /* Switch pcbeep path to Line in path*/
 		break;
 	case 0x10ec0257:
 		spec->codec_variant = ALC269_TYPE_ALC257;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Dell Headphone Mic can't record after S3
  2019-07-04  8:49 Dell Headphone Mic can't record after S3 Kailang
@ 2019-07-04 13:09 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-07-04 13:09 UTC (permalink / raw)
  To: Kailang; +Cc:  (alsa-devel@alsa-project.org)

On Thu, 04 Jul 2019 10:49:18 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> Headphone Mic can't record after S3 on Dell headset mode platform.
> The S3 mode was deep. S2idle didn't have this issue.

Applied now, thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-04 13:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04  8:49 Dell Headphone Mic can't record after S3 Kailang
2019-07-04 13:09 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.