All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biao Huang <biao.huang@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	netdev <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	"moderated list:ARM/STM32 ARCHITECTURE" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Macpaul Lin <macpaul.lin@mediatek.com>, <dkirjanov@suse.de>
Subject: Re: [PATCH net-next v13 5/7] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
Date: Thu, 24 Mar 2022 08:52:08 +0800	[thread overview]
Message-ID: <6a2f52d2a173a9127ea517c81c3c1c5fe7b2b009.camel@mediatek.com> (raw)
In-Reply-To: <CAL_Jsq+6XKvS5RcE6j9vRd3JL-Wbi-O6BrcoGQ5xV0Q2ZG8EMw@mail.gmail.com>

Dear Rob,

	Sorry for the failings.

	"snps,txpbl"/"snps,rxpbl" are limited to enum [2,4,8] in
snps,dwmac.yaml, but the hardware allows 1,2,4,8,16 or 32 according to
datasheet.

	I'll submit another patch to modify enum in snps,dwmac.yaml.

Regards!
Biao

On Wed, 2022-03-23 at 09:00 -0500, Rob Herring wrote:
> On Mon, Mar 14, 2022 at 2:57 AM Biao Huang <biao.huang@mediatek.com>
> wrote:
> > 
> > Convert mediatek-dwmac to DT schema, and delete old mediatek-
> > dwmac.txt.
> > And there are some changes in .yaml than .txt, others almost keep
> > the same:
> >   1. compatible "const: snps,dwmac-4.20".
> >   2. delete "snps,reset-active-low;" in example, since driver
> > remove this
> >      property long ago.
> >   3. add "snps,reset-delay-us = <0 10000 10000>" in example.
> >   4. the example is for rgmii interface, keep related properties
> > only.
> > 
> > Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/net/mediatek-dwmac.txt           |  91 ----------
> >  .../bindings/net/mediatek-dwmac.yaml          | 155
> > ++++++++++++++++++
> >  2 files changed, 155 insertions(+), 91 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> 
> Now failing in linux-next:
> 
> /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb:
> ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8]
>  From schema: /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb:
> ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8]
>  From schema: /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> 
> 
> Rob


WARNING: multiple messages have this Message-ID (diff)
From: Biao Huang <biao.huang@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	netdev <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"moderated list:ARM/STM32 ARCHITECTURE"
	<linux-stm32@st-md-mailman.stormreply.com>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Macpaul Lin <macpaul.lin@mediatek.com>, <dkirjanov@suse.de>
Subject: Re: [PATCH net-next v13 5/7] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
Date: Thu, 24 Mar 2022 08:52:08 +0800	[thread overview]
Message-ID: <6a2f52d2a173a9127ea517c81c3c1c5fe7b2b009.camel@mediatek.com> (raw)
In-Reply-To: <CAL_Jsq+6XKvS5RcE6j9vRd3JL-Wbi-O6BrcoGQ5xV0Q2ZG8EMw@mail.gmail.com>

Dear Rob,

	Sorry for the failings.

	"snps,txpbl"/"snps,rxpbl" are limited to enum [2,4,8] in
snps,dwmac.yaml, but the hardware allows 1,2,4,8,16 or 32 according to
datasheet.

	I'll submit another patch to modify enum in snps,dwmac.yaml.

Regards!
Biao

On Wed, 2022-03-23 at 09:00 -0500, Rob Herring wrote:
> On Mon, Mar 14, 2022 at 2:57 AM Biao Huang <biao.huang@mediatek.com>
> wrote:
> > 
> > Convert mediatek-dwmac to DT schema, and delete old mediatek-
> > dwmac.txt.
> > And there are some changes in .yaml than .txt, others almost keep
> > the same:
> >   1. compatible "const: snps,dwmac-4.20".
> >   2. delete "snps,reset-active-low;" in example, since driver
> > remove this
> >      property long ago.
> >   3. add "snps,reset-delay-us = <0 10000 10000>" in example.
> >   4. the example is for rgmii interface, keep related properties
> > only.
> > 
> > Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/net/mediatek-dwmac.txt           |  91 ----------
> >  .../bindings/net/mediatek-dwmac.yaml          | 155
> > ++++++++++++++++++
> >  2 files changed, 155 insertions(+), 91 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> 
> Now failing in linux-next:
> 
> /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb:
> ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8]
>  From schema: /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb:
> ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8]
>  From schema: /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> 
> 
> Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Biao Huang <biao.huang@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	netdev <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"moderated list:ARM/STM32 ARCHITECTURE"
	<linux-stm32@st-md-mailman.stormreply.com>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Macpaul Lin <macpaul.lin@mediatek.com>, <dkirjanov@suse.de>
Subject: Re: [PATCH net-next v13 5/7] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema
Date: Thu, 24 Mar 2022 08:52:08 +0800	[thread overview]
Message-ID: <6a2f52d2a173a9127ea517c81c3c1c5fe7b2b009.camel@mediatek.com> (raw)
In-Reply-To: <CAL_Jsq+6XKvS5RcE6j9vRd3JL-Wbi-O6BrcoGQ5xV0Q2ZG8EMw@mail.gmail.com>

Dear Rob,

	Sorry for the failings.

	"snps,txpbl"/"snps,rxpbl" are limited to enum [2,4,8] in
snps,dwmac.yaml, but the hardware allows 1,2,4,8,16 or 32 according to
datasheet.

	I'll submit another patch to modify enum in snps,dwmac.yaml.

Regards!
Biao

On Wed, 2022-03-23 at 09:00 -0500, Rob Herring wrote:
> On Mon, Mar 14, 2022 at 2:57 AM Biao Huang <biao.huang@mediatek.com>
> wrote:
> > 
> > Convert mediatek-dwmac to DT schema, and delete old mediatek-
> > dwmac.txt.
> > And there are some changes in .yaml than .txt, others almost keep
> > the same:
> >   1. compatible "const: snps,dwmac-4.20".
> >   2. delete "snps,reset-active-low;" in example, since driver
> > remove this
> >      property long ago.
> >   3. add "snps,reset-delay-us = <0 10000 10000>" in example.
> >   4. the example is for rgmii interface, keep related properties
> > only.
> > 
> > Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/net/mediatek-dwmac.txt           |  91 ----------
> >  .../bindings/net/mediatek-dwmac.yaml          | 155
> > ++++++++++++++++++
> >  2 files changed, 155 insertions(+), 91 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> 
> Now failing in linux-next:
> 
> /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb:
> ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8]
>  From schema: /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb:
> ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8]
>  From schema: /builds/robherring/linux-
> dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> 
> 
> Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-24  0:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14  7:57 [PATCH net-next v13 0/7] MediaTek Ethernet Patches on MT8195 Biao Huang
2022-03-14  7:57 ` Biao Huang
2022-03-14  7:57 ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 1/7] stmmac: dwmac-mediatek: add platform level clocks management Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 2/7] stmmac: dwmac-mediatek: Reuse more common features Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 3/7] stmmac: dwmac-mediatek: re-arrange clock setting Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 4/7] arm64: dts: mt2712: update ethernet device node Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 5/7] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-23 14:00   ` Rob Herring
2022-03-23 14:00     ` Rob Herring
2022-03-23 14:00     ` Rob Herring
2022-03-24  0:52     ` Biao Huang [this message]
2022-03-24  0:52       ` Biao Huang
2022-03-24  0:52       ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 6/7] stmmac: dwmac-mediatek: add support for mt8195 Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57 ` [PATCH net-next v13 7/7] net: dt-bindings: dwmac: " Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-14  7:57   ` Biao Huang
2022-03-16 13:20 ` [PATCH net-next v13 0/7] MediaTek Ethernet Patches on MT8195 patchwork-bot+netdevbpf
2022-03-16 13:20   ` patchwork-bot+netdevbpf
2022-03-16 13:20   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a2f52d2a173a9127ea517c81c3c1c5fe7b2b009.camel@mediatek.com \
    --to=biao.huang@mediatek.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dkirjanov@suse.de \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=macpaul.lin@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.