All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Haiyan Song <haiyanx.song@intel.com>,
	Jin Yao <yao.jin@linux.intel.com>,
	Song Liu <songliubraving@fb.com>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	Leo Yan <leo.yan@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Paul Clarke <pc@us.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kajoljain <kjain@linux.ibm.com>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 12/12] perf test: improve pmu event metric testing
Date: Thu, 30 Apr 2020 12:44:00 +0100	[thread overview]
Message-ID: <6a3d68fd-c489-c0d5-8612-69f15be1bf64@huawei.com> (raw)
In-Reply-To: <20200430075144.132716-13-irogers@google.com>

On 30/04/2020 08:51, Ian Rogers wrote:
> Add a basic floating point number test to expr.
> Break pmu-events test into 2 and add a test to verify that all pmu metric
> expressions simply parse.

Could we add also add something in jevents to ensure this?

Thanks,
John

  Try to parse all metric ids/events, failing if
> metrics for the current architecture fail to parse.
> 

WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Haiyan Song <haiyanx.song@intel.com>,
	Jin Yao <yao.jin@linux.intel.com>,
	Song Liu <songliubraving@fb.com>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	Leo Yan <leo.yan@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Paul Clarke <pc@us.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kajoljain <kjain@linux.ibm.com>,
	linux-perf-user
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 12/12] perf test: improve pmu event metric testing
Date: Thu, 30 Apr 2020 12:44:00 +0100	[thread overview]
Message-ID: <6a3d68fd-c489-c0d5-8612-69f15be1bf64@huawei.com> (raw)
In-Reply-To: <20200430075144.132716-13-irogers@google.com>

On 30/04/2020 08:51, Ian Rogers wrote:
> Add a basic floating point number test to expr.
> Break pmu-events test into 2 and add a test to verify that all pmu metric
> expressions simply parse.

Could we add also add something in jevents to ensure this?

Thanks,
John

  Try to parse all metric ids/events, failing if
> metrics for the current architecture fail to parse.
> 

  reply	other threads:[~2020-04-30 11:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  7:51 [PATCH v3 00/12] perf metric fixes and test Ian Rogers
2020-04-30  7:51 ` [PATCH v3 01/12] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-04-30  7:51 ` [PATCH v3 02/12] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-04-30  7:51 ` [PATCH v3 03/12] perf metrics: fix parse errors in skylake metrics Ian Rogers
2020-04-30  7:51 ` [PATCH v3 04/12] perf expr: allow ',' to be an other token Ian Rogers
2020-04-30  7:51 ` [PATCH v3 05/12] perf expr: increase max other Ian Rogers
2020-04-30  7:51 ` [PATCH v3 06/12] perf expr: parse numbers as doubles Ian Rogers
2020-04-30  7:51 ` [PATCH v3 07/12] perf expr: debug lex if debugging yacc Ian Rogers
2020-04-30  7:51 ` [PATCH v3 08/12] perf metrics: fix parse errors in power8 metrics Ian Rogers
2020-04-30  7:51 ` [PATCH v3 09/12] perf metrics: fix parse errors in power9 metrics Ian Rogers
2020-04-30  7:51 ` [PATCH v3 10/12] perf expr: print a debug message for division by zero Ian Rogers
2020-04-30  7:51 ` [PATCH v3 11/12] perf parse-events: expand add PMU error/verbose messages Ian Rogers
2020-04-30  7:51 ` [PATCH v3 12/12] perf test: improve pmu event metric testing Ian Rogers
2020-04-30 11:44   ` John Garry [this message]
2020-04-30 11:44     ` John Garry
2020-04-30 14:31     ` Ian Rogers
2020-04-30 14:31       ` Ian Rogers
2020-04-30 17:53       ` John Garry
2020-04-30 17:53         ` John Garry
2020-05-01 10:35 ` [PATCH v3 00/12] perf metric fixes and test Jiri Olsa
2020-05-01 17:39   ` Ian Rogers
2020-05-01 17:39     ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3d68fd-c489-c0d5-8612-69f15be1bf64@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=haiyanx.song@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pc@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=songliubraving@fb.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.