From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anand Moon <linux.amoon@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform
Date: Sun, 15 May 2022 11:52:30 +0200 [thread overview]
Message-ID: <6a6ed76a-50fa-2b05-896e-8936d3c3f597@linaro.org> (raw)
In-Reply-To: <20220515064126.1424-2-linux.amoon@gmail.com>
On 15/05/2022 08:41, Anand Moon wrote:
> Use clk_prepare_enable api to enable tmu internal hardware clock
> flag on, use clk_disable_unprepare to disable the clock.
>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Here as well you ignored my first comment:
https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#mbfc57b40a7ed043dd4d4890bedb6bad8240058cd
"This is not valid reason to do a change. What is clk_summary does not
really matter. Your change has negative impact on power consumption as
the clock stays enabled all the time. This is not what we want... so
please explain it more - why you need the clock to be enabled all the
time? What is broken (clk_summary is not broken in this case)?"
This was not addressed, you just resent same code...
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anand Moon <linux.amoon@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform
Date: Sun, 15 May 2022 11:52:30 +0200 [thread overview]
Message-ID: <6a6ed76a-50fa-2b05-896e-8936d3c3f597@linaro.org> (raw)
In-Reply-To: <20220515064126.1424-2-linux.amoon@gmail.com>
On 15/05/2022 08:41, Anand Moon wrote:
> Use clk_prepare_enable api to enable tmu internal hardware clock
> flag on, use clk_disable_unprepare to disable the clock.
>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Here as well you ignored my first comment:
https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#mbfc57b40a7ed043dd4d4890bedb6bad8240058cd
"This is not valid reason to do a change. What is clk_summary does not
really matter. Your change has negative impact on power consumption as
the clock stays enabled all the time. This is not what we want... so
please explain it more - why you need the clock to be enabled all the
time? What is broken (clk_summary is not broken in this case)?"
This was not addressed, you just resent same code...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-15 9:52 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 6:41 [PATCHv2 0/6] Exynos Thermal code inprovement Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 9:39 ` Krzysztof Kozlowski
2022-05-15 9:39 ` Krzysztof Kozlowski
2022-05-15 9:52 ` Krzysztof Kozlowski [this message]
2022-05-15 9:52 ` Krzysztof Kozlowski
2022-05-17 18:42 ` Anand Moon
2022-05-17 18:42 ` Anand Moon
2022-05-18 7:25 ` Krzysztof Kozlowski
2022-05-18 7:25 ` Krzysztof Kozlowski
2022-05-21 9:50 ` Anand Moon
2022-05-21 9:50 ` Anand Moon
2022-05-21 14:15 ` Krzysztof Kozlowski
2022-05-21 14:15 ` Krzysztof Kozlowski
2022-05-15 6:41 ` [PATCHv2 2/6] thermal: exynos: Reorder the gpu clock initialization for exynos5420 SoC Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 9:41 ` Krzysztof Kozlowski
2022-05-15 9:41 ` Krzysztof Kozlowski
2022-05-17 18:43 ` Anand Moon
2022-05-17 18:43 ` Anand Moon
2022-05-18 7:28 ` Krzysztof Kozlowski
2022-05-18 7:28 ` Krzysztof Kozlowski
2022-05-21 9:51 ` Anand Moon
2022-05-21 9:51 ` Anand Moon
2022-05-21 14:20 ` Krzysztof Kozlowski
2022-05-21 14:20 ` Krzysztof Kozlowski
2022-05-15 9:50 ` Krzysztof Kozlowski
2022-05-15 9:50 ` Krzysztof Kozlowski
2022-05-17 18:43 ` Anand Moon
2022-05-17 18:43 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 3/6] thermal: exynos: Check before clk_disable_unprepare() not needed Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 9:43 ` Krzysztof Kozlowski
2022-05-15 9:43 ` Krzysztof Kozlowski
2022-05-17 18:44 ` Anand Moon
2022-05-17 18:44 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422 Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 9:45 ` Krzysztof Kozlowski
2022-05-15 9:45 ` Krzysztof Kozlowski
2022-05-16 10:42 ` kernel test robot
2022-05-16 10:42 ` kernel test robot
2022-05-16 10:44 ` Krzysztof Kozlowski
2022-05-16 10:44 ` Krzysztof Kozlowski
2022-05-16 10:44 ` Krzysztof Kozlowski
2022-05-17 18:44 ` Anand Moon
2022-05-17 18:44 ` Anand Moon
2022-05-17 18:44 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 5/6] thermal: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 9:47 ` Krzysztof Kozlowski
2022-05-15 9:47 ` Krzysztof Kozlowski
2022-05-17 18:44 ` Anand Moon
2022-05-17 18:44 ` Anand Moon
2022-05-15 6:41 ` [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu Anand Moon
2022-05-15 6:41 ` Anand Moon
2022-05-15 9:48 ` Krzysztof Kozlowski
2022-05-15 9:48 ` Krzysztof Kozlowski
2022-05-17 18:45 ` Anand Moon
2022-05-17 18:45 ` Anand Moon
2022-05-18 7:19 ` Krzysztof Kozlowski
2022-05-18 7:19 ` Krzysztof Kozlowski
2022-05-21 9:52 ` Anand Moon
2022-05-21 9:52 ` Anand Moon
2022-05-21 14:11 ` Krzysztof Kozlowski
2022-05-21 14:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6ed76a-50fa-2b05-896e-8936d3c3f597@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.