All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
@ 2018-01-17 11:25 ` Wei Yongjun
  0 siblings, 0 replies; 8+ messages in thread
From: Wei Yongjun @ 2018-01-17 11:25 UTC (permalink / raw)
  To: Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman,
	Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: Wei Yongjun, openipmi-developer, linuxppc-dev, linux-kernel,
	kernel-janitors

Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/char/ipmi/ipmi_powernv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
index c687c8d..bcf493d 100644
--- a/drivers/char/ipmi/ipmi_powernv.c
+++ b/drivers/char/ipmi/ipmi_powernv.c
@@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
 		ipmi->irq = opal_event_request(prop);
 	}
 
-	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
-				"opal-ipmi", ipmi)) {
+	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
+			 "opal-ipmi", ipmi);
+	if (rc) {
 		dev_warn(dev, "Unable to request irq\n");
 		goto err_dispose;
 	}

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
@ 2018-01-17 11:25 ` Wei Yongjun
  0 siblings, 0 replies; 8+ messages in thread
From: Wei Yongjun @ 2018-01-17 11:25 UTC (permalink / raw)
  To: Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman,
	Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: Wei Yongjun, openipmi-developer, linuxppc-dev, linux-kernel,
	kernel-janitors

Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/char/ipmi/ipmi_powernv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
index c687c8d..bcf493d 100644
--- a/drivers/char/ipmi/ipmi_powernv.c
+++ b/drivers/char/ipmi/ipmi_powernv.c
@@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
 		ipmi->irq = opal_event_request(prop);
 	}
 
-	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
-				"opal-ipmi", ipmi)) {
+	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
+			 "opal-ipmi", ipmi);
+	if (rc) {
 		dev_warn(dev, "Unable to request irq\n");
 		goto err_dispose;
 	}


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
  2018-01-17 11:25 ` Wei Yongjun
  (?)
@ 2018-01-17 15:52 ` Corey Minyard
  -1 siblings, 0 replies; 8+ messages in thread
From: Corey Minyard @ 2018-01-17 15:52 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: openipmi-developer, linuxppc-dev, linux-kernel, Jeremy Kerr,
	Michael, Ellerman, Alistair Popple

On 01/17/2018 05:25 AM, Wei Yongjun wrote:
> Fix to return a negative error code from the request_irq() error
> handling case instead of 0, as done elsewhere in this function.

I think you are right here.  However, you had a bunch of people on the email
that probably didn't need to be there, and didn't have a few that should.
I've adjusted in this response.

This was introduced in change dce143c3381c355ef73be3dd97cf3ca1b15359b8,
you should add a "Fixes:" in the commit text.

I'll let the people that did this code comment, just to be sure, and 
wait for
a v2 patch from you after that.

Thanks,

-corey

> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>   drivers/char/ipmi/ipmi_powernv.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
> index c687c8d..bcf493d 100644
> --- a/drivers/char/ipmi/ipmi_powernv.c
> +++ b/drivers/char/ipmi/ipmi_powernv.c
> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
>   		ipmi->irq = opal_event_request(prop);
>   	}
>   
> -	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
> -				"opal-ipmi", ipmi)) {
> +	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
> +			 "opal-ipmi", ipmi);
> +	if (rc) {
>   		dev_warn(dev, "Unable to request irq\n");
>   		goto err_dispose;
>   	}
>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH -next v2] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
  2018-01-17 11:25 ` Wei Yongjun
  (?)
  (?)
@ 2018-01-18  1:43 ` Wei Yongjun
  -1 siblings, 0 replies; 8+ messages in thread
From: Wei Yongjun @ 2018-01-18  1:43 UTC (permalink / raw)
  To: Corey Minyard, Arnd Bergmann, Alistair Popple, Michael Ellerman,
	Jeremy Kerr
  Cc: Wei Yongjun, openipmi-developer, linuxppc-dev, linux-kernel

Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.

Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: add fixes.
---
 drivers/char/ipmi/ipmi_powernv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
index c687c8d..bcf493d 100644
--- a/drivers/char/ipmi/ipmi_powernv.c
+++ b/drivers/char/ipmi/ipmi_powernv.c
@@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
 		ipmi->irq = opal_event_request(prop);
 	}
 
-	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
-				"opal-ipmi", ipmi)) {
+	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
+			 "opal-ipmi", ipmi);
+	if (rc) {
 		dev_warn(dev, "Unable to request irq\n");
 		goto err_dispose;
 	}

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
  2018-01-17 11:25 ` Wei Yongjun
@ 2018-01-18  4:04   ` Alexey Kardashevskiy
  -1 siblings, 0 replies; 8+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-18  4:04 UTC (permalink / raw)
  To: Wei Yongjun, Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman,
	Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: openipmi-developer, linuxppc-dev, linux-kernel, kernel-janitors

On 17/01/18 22:25, Wei Yongjun wrote:
> Fix to return a negative error code from the request_irq() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>


Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>



> ---
>  drivers/char/ipmi/ipmi_powernv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
> index c687c8d..bcf493d 100644
> --- a/drivers/char/ipmi/ipmi_powernv.c
> +++ b/drivers/char/ipmi/ipmi_powernv.c
> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
>  		ipmi->irq = opal_event_request(prop);
>  	}
>  
> -	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
> -				"opal-ipmi", ipmi)) {
> +	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
> +			 "opal-ipmi", ipmi);
> +	if (rc) {
>  		dev_warn(dev, "Unable to request irq\n");
>  		goto err_dispose;
>  	}
> 


-- 
Alexey

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
@ 2018-01-18  4:04   ` Alexey Kardashevskiy
  0 siblings, 0 replies; 8+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-18  4:04 UTC (permalink / raw)
  To: Wei Yongjun, Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman,
	Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: openipmi-developer, linuxppc-dev, linux-kernel, kernel-janitors

On 17/01/18 22:25, Wei Yongjun wrote:
> Fix to return a negative error code from the request_irq() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>


Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>



> ---
>  drivers/char/ipmi/ipmi_powernv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
> index c687c8d..bcf493d 100644
> --- a/drivers/char/ipmi/ipmi_powernv.c
> +++ b/drivers/char/ipmi/ipmi_powernv.c
> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
>  		ipmi->irq = opal_event_request(prop);
>  	}
>  
> -	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
> -				"opal-ipmi", ipmi)) {
> +	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
> +			 "opal-ipmi", ipmi);
> +	if (rc) {
>  		dev_warn(dev, "Unable to request irq\n");
>  		goto err_dispose;
>  	}
> 


-- 
Alexey

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
  2018-01-18  4:04   ` Alexey Kardashevskiy
@ 2018-01-18 14:05     ` Corey Minyard
  -1 siblings, 0 replies; 8+ messages in thread
From: Corey Minyard @ 2018-01-18 14:05 UTC (permalink / raw)
  To: Alexey Kardashevskiy, Wei Yongjun, Corey Minyard, Arnd Bergmann,
	Greg Kroah-Hartman, Benjamin Herrenschmidt, Paul Mackerras,
	Michael Ellerman
  Cc: openipmi-developer, linuxppc-dev, linux-kernel, kernel-janitors

On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote:
> On 17/01/18 22:25, Wei Yongjun wrote:
>> Fix to return a negative error code from the request_irq() error
>> handling case instead of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Queued for next release.  Thanks!

-corey

>
>
>> ---
>>   drivers/char/ipmi/ipmi_powernv.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
>> index c687c8d..bcf493d 100644
>> --- a/drivers/char/ipmi/ipmi_powernv.c
>> +++ b/drivers/char/ipmi/ipmi_powernv.c
>> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
>>   		ipmi->irq = opal_event_request(prop);
>>   	}
>>   
>> -	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
>> -				"opal-ipmi", ipmi)) {
>> +	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
>> +			 "opal-ipmi", ipmi);
>> +	if (rc) {
>>   		dev_warn(dev, "Unable to request irq\n");
>>   		goto err_dispose;
>>   	}
>>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
@ 2018-01-18 14:05     ` Corey Minyard
  0 siblings, 0 replies; 8+ messages in thread
From: Corey Minyard @ 2018-01-18 14:05 UTC (permalink / raw)
  To: Alexey Kardashevskiy, Wei Yongjun, Corey Minyard, Arnd Bergmann,
	Greg Kroah-Hartman, Benjamin Herrenschmidt, Paul Mackerras,
	Michael Ellerman
  Cc: openipmi-developer, linuxppc-dev, linux-kernel, kernel-janitors

On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote:
> On 17/01/18 22:25, Wei Yongjun wrote:
>> Fix to return a negative error code from the request_irq() error
>> handling case instead of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Queued for next release.  Thanks!

-corey

>
>
>> ---
>>   drivers/char/ipmi/ipmi_powernv.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
>> index c687c8d..bcf493d 100644
>> --- a/drivers/char/ipmi/ipmi_powernv.c
>> +++ b/drivers/char/ipmi/ipmi_powernv.c
>> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
>>   		ipmi->irq = opal_event_request(prop);
>>   	}
>>   
>> -	if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
>> -				"opal-ipmi", ipmi)) {
>> +	rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
>> +			 "opal-ipmi", ipmi);
>> +	if (rc) {
>>   		dev_warn(dev, "Unable to request irq\n");
>>   		goto err_dispose;
>>   	}
>>
>

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-01-18 14:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 11:25 [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe() Wei Yongjun
2018-01-17 11:25 ` Wei Yongjun
2018-01-17 15:52 ` Corey Minyard
2018-01-18  1:43 ` [PATCH -next v2] " Wei Yongjun
2018-01-18  4:04 ` [PATCH -next] " Alexey Kardashevskiy
2018-01-18  4:04   ` Alexey Kardashevskiy
2018-01-18 14:05   ` Corey Minyard
2018-01-18 14:05     ` Corey Minyard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.