From: Grygorii Strashko <grygorii.strashko@ti.com> To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>, <davem@davemloft.net> Cc: <linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode Date: Mon, 22 Oct 2018 13:26:35 -0500 [thread overview] Message-ID: <6ac434fa-858b-8395-91e7-442cf18b33f0@ti.com> (raw) In-Reply-To: <20181019202541.10278-1-ivan.khoronzhuk@linaro.org> On 10/19/18 3:25 PM, Ivan Khoronzhuk wrote: > After flushing all mcast entries from the table, the ones contained in > mc list of ndev are not restored when promisc mode is toggled off, > because they are considered as synched with ALE, thus, in order to > restore them after promisc mode - reset syncing info. This fix > touches only switch mode devices, including single port boards > like Beagle Bone. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- So, this is follow up fix for 176b23 net: ethernet: ti: cpsw: fix lost of mcast packets while rx_mode update because I can't reproduce it otherwise. Could you update description and re-send pls.? > > Based on net-nex/master > and is logical continuation of the > https://lore.kernel.org/patchwork/patch/1001633/ > > drivers/net/ethernet/ti/cpsw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 226be2a56c1f..f7753b240ced 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -640,6 +640,7 @@ static void cpsw_set_promiscious(struct net_device *ndev, bool enable) > > /* Clear all mcast from ALE */ > cpsw_ale_flush_multicast(ale, ALE_ALL_PORTS, -1); > + __dev_mc_unsync(ndev, NULL); > > /* Flood All Unicast Packets to Host port */ > cpsw_ale_control_set(ale, 0, ALE_P0_UNI_FLOOD, 1); > -- regards, -grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com> To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>, davem@davemloft.net Cc: linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode Date: Mon, 22 Oct 2018 13:26:35 -0500 [thread overview] Message-ID: <6ac434fa-858b-8395-91e7-442cf18b33f0@ti.com> (raw) In-Reply-To: <20181019202541.10278-1-ivan.khoronzhuk@linaro.org> On 10/19/18 3:25 PM, Ivan Khoronzhuk wrote: > After flushing all mcast entries from the table, the ones contained in > mc list of ndev are not restored when promisc mode is toggled off, > because they are considered as synched with ALE, thus, in order to > restore them after promisc mode - reset syncing info. This fix > touches only switch mode devices, including single port boards > like Beagle Bone. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- So, this is follow up fix for 176b23 net: ethernet: ti: cpsw: fix lost of mcast packets while rx_mode update because I can't reproduce it otherwise. Could you update description and re-send pls.? > > Based on net-nex/master > and is logical continuation of the > https://lore.kernel.org/patchwork/patch/1001633/ > > drivers/net/ethernet/ti/cpsw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 226be2a56c1f..f7753b240ced 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -640,6 +640,7 @@ static void cpsw_set_promiscious(struct net_device *ndev, bool enable) > > /* Clear all mcast from ALE */ > cpsw_ale_flush_multicast(ale, ALE_ALL_PORTS, -1); > + __dev_mc_unsync(ndev, NULL); > > /* Flood All Unicast Packets to Host port */ > cpsw_ale_control_set(ale, 0, ALE_P0_UNI_FLOOD, 1); > -- regards, -grygorii
next prev parent reply other threads:[~2018-10-22 18:26 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-19 20:25 [PATCH net-next] net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode Ivan Khoronzhuk 2018-10-22 18:26 ` Grygorii Strashko [this message] 2018-10-22 18:26 ` Grygorii Strashko 2018-10-22 19:02 ` Ivan Khoronzhuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ac434fa-858b-8395-91e7-442cf18b33f0@ti.com \ --to=grygorii.strashko@ti.com \ --cc=davem@davemloft.net \ --cc=ivan.khoronzhuk@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.