From: Jason Wang <jasowang@redhat.com> To: "Eugenio Pérez" <eperezma@redhat.com>, qemu-devel@nongnu.org Cc: Parav Pandit <parav@mellanox.com>, Juan Quintela <quintela@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, virtualization@lists.linux-foundation.org, Harpreet Singh Anand <hanand@xilinx.com>, Xiao W Wang <xiao.w.wang@intel.com>, Stefan Hajnoczi <stefanha@redhat.com>, Eli Cohen <eli@mellanox.com>, Eric Blake <eblake@redhat.com>, Michael Lilja <ml@napatech.com>, Stefano Garzarella <sgarzare@redhat.com> Subject: Re: [RFC PATCH v4 17/20] vhost: Use VRING_AVAIL_F_NO_INTERRUPT at device call on shadow virtqueue Date: Wed, 13 Oct 2021 12:36:44 +0800 [thread overview] Message-ID: <6ae86e3f-a922-3576-a73a-a6c80ac7dd3f@redhat.com> (raw) In-Reply-To: <20211001070603.307037-18-eperezma@redhat.com> 在 2021/10/1 下午3:06, Eugenio Pérez 写道: > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Commit log please. Thanks > --- > hw/virtio/vhost-shadow-virtqueue.c | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c > index 775f8d36a0..2fd0bab75d 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.c > +++ b/hw/virtio/vhost-shadow-virtqueue.c > @@ -60,6 +60,9 @@ typedef struct VhostShadowVirtqueue { > > /* Next head to consume from device */ > uint16_t used_idx; > + > + /* Cache for the exposed notification flag */ > + bool notification; > } VhostShadowVirtqueue; > > /* If the device is using some of these, SVQ cannot communicate */ > @@ -105,6 +108,24 @@ bool vhost_svq_valid_device_features(uint64_t *dev_features) > return r; > } > > +static void vhost_svq_set_notification(VhostShadowVirtqueue *svq, bool enable) > +{ > + uint16_t notification_flag; > + > + if (svq->notification == enable) { > + return; > + } > + > + notification_flag = cpu_to_le16(VRING_AVAIL_F_NO_INTERRUPT); > + > + svq->notification = enable; > + if (enable) { > + svq->vring.avail->flags &= ~notification_flag; > + } else { > + svq->vring.avail->flags |= notification_flag; > + } > +} > + > static void vhost_vring_write_descs(VhostShadowVirtqueue *svq, > const struct iovec *iovec, > size_t num, bool more_descs, bool write) > @@ -273,7 +294,7 @@ static void vhost_svq_handle_call_no_test(EventNotifier *n) > do { > unsigned i = 0; > > - /* TODO: Use VRING_AVAIL_F_NO_INTERRUPT */ > + vhost_svq_set_notification(svq, false); > while (true) { > g_autofree VirtQueueElement *elem = vhost_svq_get_buf(svq); > if (!elem) { > @@ -286,6 +307,7 @@ static void vhost_svq_handle_call_no_test(EventNotifier *n) > > virtqueue_flush(vq, i); > event_notifier_set(&svq->guest_call_notifier); > + vhost_svq_set_notification(svq, true); > } while (vhost_svq_more_used(svq)); > } >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: "Eugenio Pérez" <eperezma@redhat.com>, qemu-devel@nongnu.org Cc: Parav Pandit <parav@mellanox.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, virtualization@lists.linux-foundation.org, Harpreet Singh Anand <hanand@xilinx.com>, Xiao W Wang <xiao.w.wang@intel.com>, Stefan Hajnoczi <stefanha@redhat.com>, Eli Cohen <eli@mellanox.com>, Eric Blake <eblake@redhat.com>, Michael Lilja <ml@napatech.com> Subject: Re: [RFC PATCH v4 17/20] vhost: Use VRING_AVAIL_F_NO_INTERRUPT at device call on shadow virtqueue Date: Wed, 13 Oct 2021 12:36:44 +0800 [thread overview] Message-ID: <6ae86e3f-a922-3576-a73a-a6c80ac7dd3f@redhat.com> (raw) In-Reply-To: <20211001070603.307037-18-eperezma@redhat.com> 在 2021/10/1 下午3:06, Eugenio Pérez 写道: > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Commit log please. Thanks > --- > hw/virtio/vhost-shadow-virtqueue.c | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c > index 775f8d36a0..2fd0bab75d 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.c > +++ b/hw/virtio/vhost-shadow-virtqueue.c > @@ -60,6 +60,9 @@ typedef struct VhostShadowVirtqueue { > > /* Next head to consume from device */ > uint16_t used_idx; > + > + /* Cache for the exposed notification flag */ > + bool notification; > } VhostShadowVirtqueue; > > /* If the device is using some of these, SVQ cannot communicate */ > @@ -105,6 +108,24 @@ bool vhost_svq_valid_device_features(uint64_t *dev_features) > return r; > } > > +static void vhost_svq_set_notification(VhostShadowVirtqueue *svq, bool enable) > +{ > + uint16_t notification_flag; > + > + if (svq->notification == enable) { > + return; > + } > + > + notification_flag = cpu_to_le16(VRING_AVAIL_F_NO_INTERRUPT); > + > + svq->notification = enable; > + if (enable) { > + svq->vring.avail->flags &= ~notification_flag; > + } else { > + svq->vring.avail->flags |= notification_flag; > + } > +} > + > static void vhost_vring_write_descs(VhostShadowVirtqueue *svq, > const struct iovec *iovec, > size_t num, bool more_descs, bool write) > @@ -273,7 +294,7 @@ static void vhost_svq_handle_call_no_test(EventNotifier *n) > do { > unsigned i = 0; > > - /* TODO: Use VRING_AVAIL_F_NO_INTERRUPT */ > + vhost_svq_set_notification(svq, false); > while (true) { > g_autofree VirtQueueElement *elem = vhost_svq_get_buf(svq); > if (!elem) { > @@ -286,6 +307,7 @@ static void vhost_svq_handle_call_no_test(EventNotifier *n) > > virtqueue_flush(vq, i); > event_notifier_set(&svq->guest_call_notifier); > + vhost_svq_set_notification(svq, true); > } while (vhost_svq_more_used(svq)); > } > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-13 4:37 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-01 7:05 [RFC PATCH v4 00/20] vDPA shadow virtqueue Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 01/20] virtio: Add VIRTIO_F_QUEUE_STATE Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 02/20] virtio-net: Honor VIRTIO_CONFIG_S_DEVICE_STOPPED Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 03/20] virtio: Add virtio_queue_is_host_notifier_enabled Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 04/20] vhost: Make vhost_virtqueue_{start,stop} public Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 05/20] vhost: Add x-vhost-enable-shadow-vq qmp Eugenio Pérez 2021-10-12 5:18 ` Markus Armbruster 2021-10-12 13:08 ` Eugenio Perez Martin 2021-10-12 13:45 ` Markus Armbruster 2021-10-14 12:01 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 06/20] vhost: Add VhostShadowVirtqueue Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 07/20] vdpa: Register vdpa devices in a list Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 08/20] vhost: Route guest->host notification through shadow virtqueue Eugenio Pérez 2021-10-12 5:19 ` Markus Armbruster 2021-10-12 13:09 ` Eugenio Perez Martin 2021-10-13 3:27 ` Jason Wang 2021-10-13 3:27 ` Jason Wang 2021-10-14 12:00 ` Eugenio Perez Martin 2021-10-15 3:45 ` Jason Wang 2021-10-15 3:45 ` Jason Wang 2021-10-15 9:08 ` Eugenio Perez Martin 2021-10-15 18:21 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 09/20] vdpa: Save call_fd in vhost-vdpa Eugenio Pérez 2021-10-13 3:43 ` Jason Wang 2021-10-13 3:43 ` Jason Wang 2021-10-14 12:11 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 10/20] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call Eugenio Pérez 2021-10-13 3:43 ` Jason Wang 2021-10-13 3:43 ` Jason Wang 2021-10-14 12:18 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 11/20] vhost: Route host->guest notification through shadow virtqueue Eugenio Pérez 2021-10-13 3:47 ` Jason Wang 2021-10-13 3:47 ` Jason Wang 2021-10-14 16:39 ` Eugenio Perez Martin 2021-10-15 4:42 ` Jason Wang 2021-10-15 4:42 ` Jason Wang 2021-10-19 8:39 ` Eugenio Perez Martin 2021-10-20 2:01 ` Jason Wang 2021-10-20 2:01 ` Jason Wang 2021-10-20 6:36 ` Eugenio Perez Martin 2021-10-13 3:49 ` Jason Wang 2021-10-13 3:49 ` Jason Wang 2021-10-14 15:58 ` Eugenio Perez Martin 2021-10-15 4:24 ` Jason Wang 2021-10-15 4:24 ` Jason Wang 2021-10-01 7:05 ` [RFC PATCH v4 12/20] virtio: Add vhost_shadow_vq_get_vring_addr Eugenio Pérez 2021-10-13 3:54 ` Jason Wang 2021-10-13 3:54 ` Jason Wang 2021-10-14 14:39 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 13/20] vdpa: Save host and guest features Eugenio Pérez 2021-10-13 3:56 ` Jason Wang 2021-10-13 3:56 ` Jason Wang 2021-10-14 15:03 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 14/20] vhost: Add vhost_svq_valid_device_features to shadow vq Eugenio Pérez 2021-10-01 7:05 ` [RFC PATCH v4 15/20] vhost: Shadow virtqueue buffers forwarding Eugenio Pérez 2021-10-12 5:21 ` Markus Armbruster 2021-10-12 13:28 ` Eugenio Perez Martin 2021-10-12 13:48 ` Markus Armbruster 2021-10-14 15:04 ` Eugenio Perez Martin 2021-10-13 4:31 ` Jason Wang 2021-10-13 4:31 ` Jason Wang 2021-10-14 17:56 ` Eugenio Perez Martin 2021-10-15 4:23 ` Jason Wang 2021-10-15 4:23 ` Jason Wang 2021-10-15 9:33 ` Eugenio Perez Martin 2021-10-01 7:05 ` [RFC PATCH v4 16/20] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick Eugenio Pérez 2021-10-13 4:35 ` Jason Wang 2021-10-13 4:35 ` Jason Wang 2021-10-15 6:17 ` Eugenio Perez Martin 2021-10-01 7:06 ` [RFC PATCH v4 17/20] vhost: Use VRING_AVAIL_F_NO_INTERRUPT at device call on shadow virtqueue Eugenio Pérez 2021-10-13 4:36 ` Jason Wang [this message] 2021-10-13 4:36 ` Jason Wang 2021-10-15 6:22 ` Eugenio Perez Martin 2021-10-01 7:06 ` [RFC PATCH v4 18/20] vhost: Add VhostIOVATree Eugenio Pérez 2021-10-19 8:32 ` Jason Wang 2021-10-19 8:32 ` Jason Wang 2021-10-19 9:22 ` Jason Wang 2021-10-20 7:54 ` Eugenio Perez Martin 2021-10-20 9:01 ` Jason Wang 2021-10-20 12:06 ` Eugenio Perez Martin 2021-10-21 2:34 ` Jason Wang 2021-10-21 7:03 ` Eugenio Perez Martin 2021-10-21 8:12 ` Jason Wang 2021-10-21 14:33 ` Eugenio Perez Martin 2021-10-26 4:29 ` Jason Wang 2021-10-20 7:36 ` Eugenio Perez Martin 2021-10-01 7:06 ` [RFC PATCH v4 19/20] vhost: Use a tree to store memory mappings Eugenio Pérez 2021-10-01 7:06 ` [RFC PATCH v4 20/20] vdpa: Add custom IOTLB translations to SVQ Eugenio Pérez 2021-10-13 5:34 ` Jason Wang 2021-10-13 5:34 ` Jason Wang 2021-10-15 7:27 ` Eugenio Perez Martin 2021-10-15 7:37 ` Jason Wang 2021-10-15 7:37 ` Jason Wang 2021-10-15 8:20 ` Eugenio Perez Martin 2021-10-15 8:37 ` Jason Wang 2021-10-15 8:37 ` Jason Wang 2021-10-15 9:14 ` Eugenio Perez Martin 2021-10-19 9:24 ` Jason Wang 2021-10-19 9:24 ` Jason Wang 2021-10-19 10:28 ` Eugenio Perez Martin 2021-10-20 2:02 ` Jason Wang 2021-10-20 2:02 ` Jason Wang 2021-10-20 2:07 ` Jason Wang 2021-10-20 2:07 ` Jason Wang 2021-10-20 6:51 ` Eugenio Perez Martin 2021-10-20 9:03 ` Jason Wang 2021-10-20 9:03 ` Jason Wang 2021-10-20 11:56 ` Eugenio Perez Martin 2021-10-21 2:38 ` Jason Wang 2021-10-21 2:38 ` Jason Wang 2021-10-26 4:32 ` Jason Wang 2021-10-26 4:32 ` Jason Wang 2021-10-12 3:59 ` [RFC PATCH v4 00/20] vDPA shadow virtqueue Jason Wang 2021-10-12 3:59 ` Jason Wang 2021-10-12 4:06 ` Jason Wang 2021-10-12 4:06 ` Jason Wang 2021-10-12 9:09 ` Eugenio Perez Martin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ae86e3f-a922-3576-a73a-a6c80ac7dd3f@redhat.com \ --to=jasowang@redhat.com \ --cc=armbru@redhat.com \ --cc=eblake@redhat.com \ --cc=eli@mellanox.com \ --cc=eperezma@redhat.com \ --cc=hanand@xilinx.com \ --cc=ml@napatech.com \ --cc=mst@redhat.com \ --cc=parav@mellanox.com \ --cc=qemu-devel@nongnu.org \ --cc=quintela@redhat.com \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiao.w.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.