* [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
@ 2019-11-22 1:10 don.hiatt
2019-11-22 1:54 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: don.hiatt @ 2019-11-22 1:10 UTC (permalink / raw)
To: igt-dev
From: Don Hiatt <don.hiatt@intel.com>
Suspending to disk requires swap space, make sure it exists
before attempting to suspend to disk.
v2: Use igt_skip() [Thanks, Chris!]
v3: Use igt_skip_on_f()
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
lib/igt_aux.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 578f857933f0..a6b114ed7e65 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
igt_require(test == SUSPEND_TEST_NONE ||
faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
+ igt_skip_on_f(state == SUSPEND_STATE_DISK &&
+ !intel_get_total_swap_mb(),
+ "Suspend to disk requires swap space.\n");
+
orig_test = get_suspend_test(power_dir);
set_suspend_test(power_dir, test);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3)
2019-11-22 1:10 [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk don.hiatt
@ 2019-11-22 1:54 ` Patchwork
2019-11-23 8:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-26 0:49 ` [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk Sujaritha
2 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-11-22 1:54 UTC (permalink / raw)
To: don.hiatt; +Cc: igt-dev
== Series Details ==
Series: lib/aux: Ensure swap space prior to suspend to disk (rev3)
URL : https://patchwork.freedesktop.org/series/69859/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7402 -> IGTPW_3745
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/index.html
Known issues
------------
Here are the changes found in IGTPW_3745 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-ilk-650: [PASS][1] -> [DMESG-WARN][2] ([fdo#106387])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-ilk-650/igt@gem_exec_suspend@basic-s0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/fi-ilk-650/igt@gem_exec_suspend@basic-s0.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [PASS][3] -> [INCOMPLETE][4] ([fdo#111700])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [PASS][5] -> [DMESG-FAIL][6] ([fdo#111678])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([fdo#106107])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-icl-u2/igt@kms_busy@basic-flip-pipe-b.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/fi-icl-u2/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#111407])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][11] ([fdo#103167]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111678]: https://bugs.freedesktop.org/show_bug.cgi?id=111678
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
Participating hosts (50 -> 44)
------------------------------
Additional (1): fi-bsw-n3050
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5299 -> IGTPW_3745
CI-20190529: 20190529
CI_DRM_7402: d5f0845c4b92c5826d63b76f89866492e0935c1b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3745: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/index.html
IGT_5299: 65fed6a79adea14f7bef6d55530da47d7731d370 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3)
2019-11-22 1:10 [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk don.hiatt
2019-11-22 1:54 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3) Patchwork
@ 2019-11-23 8:55 ` Patchwork
2019-11-26 0:49 ` [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk Sujaritha
2 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2019-11-23 8:55 UTC (permalink / raw)
To: don.hiatt; +Cc: igt-dev
== Series Details ==
Series: lib/aux: Ensure swap space prior to suspend to disk (rev3)
URL : https://patchwork.freedesktop.org/series/69859/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7402_full -> IGTPW_3745_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/index.html
Known issues
------------
Here are the changes found in IGTPW_3745_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-hostile-preempt:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb6/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb1/igt@gem_exec_balancer@smoke.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb5/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +10 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +12 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-chain-vebox:
- shard-kbl: [PASS][11] -> [INCOMPLETE][12] ([fdo#103665]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl1/igt@gem_exec_schedule@preempt-queue-chain-vebox.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl3/igt@gem_exec_schedule@preempt-queue-chain-vebox.html
* igt@gem_sync@basic-all:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111880])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb2/igt@gem_sync@basic-all.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb6/igt@gem_sync@basic-all.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [PASS][17] -> [DMESG-WARN][18] ([fdo#111870]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-hsw7/igt@gem_userptr_blits@sync-unmap-cycles.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-hsw1/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#111795 ])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb6/igt@i915_pm_dc@dc5-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([fdo#103540])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-hsw6/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-hsw6/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#103232])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
- shard-kbl: [PASS][25] -> [FAIL][26] ([fdo#103232])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: [PASS][31] -> [FAIL][32] ([fdo#103167])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-glk: [PASS][33] -> [FAIL][34] ([fdo#103167])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
- shard-tglb: [PASS][35] -> [FAIL][36] ([fdo#103167]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][37] -> [FAIL][38] ([fdo#103167]) +6 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-iclb: [PASS][39] -> [DMESG-WARN][40] ([fdo#111764])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111832] / [fdo#111850])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb3/igt@kms_frontbuffer_tracking@psr-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb7/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111850])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb6/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][47] -> [DMESG-WARN][48] ([fdo#108566]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [SKIP][49] ([fdo#112080]) -> [PASS][50] +16 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb6/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb4/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][51] ([fdo#109276] / [fdo#112080]) -> [PASS][52] +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb8/igt@gem_ctx_persistence@vcs1-queued.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_shared@q-smoketest-all:
- shard-tglb: [INCOMPLETE][53] ([fdo#111735]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb9/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [INCOMPLETE][55] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb2/igt@gem_eio@in-flight-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb2/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][57] ([fdo#112146]) -> [PASS][58] +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-apl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl4/igt@gem_exec_suspend@basic-s3.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-apl4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-tglb: [INCOMPLETE][61] ([fdo#111998]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb6/igt@gem_pipe_control_store_loop@reused-buffer.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb3/igt@gem_pipe_control_store_loop@reused-buffer.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][63] ([fdo#111870]) -> [PASS][64] +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [DMESG-WARN][65] ([fdo#111870]) -> [PASS][66] +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-hsw5/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_suspend@debugfs-reader:
- shard-tglb: [INCOMPLETE][67] ([fdo#111850]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb7/igt@i915_suspend@debugfs-reader.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb2/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-tglb: [INCOMPLETE][69] ([fdo#111747]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-glk: [FAIL][71] ([fdo#104873]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-glk4/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-glk4/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
* igt@kms_flip@flip-vs-suspend:
- shard-tglb: [INCOMPLETE][73] ([fdo#111850] / [fdo#112031]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb5/igt@kms_flip@flip-vs-suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb9/igt@kms_flip@flip-vs-suspend.html
- shard-hsw: [INCOMPLETE][75] ([fdo#103540]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-iclb: [INCOMPLETE][77] ([fdo#107713] / [fdo#109507]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb3/igt@kms_flip@flip-vs-suspend-interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +6 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: [FAIL][81] ([fdo#103167]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-kbl: [FAIL][83] ([fdo#103167]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
- shard-apl: [FAIL][85] ([fdo#103167]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-apl1/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-apl4/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [FAIL][87] ([fdo#103167]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][89] ([fdo#108566]) -> [PASS][90] +4 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-snb: [INCOMPLETE][91] ([fdo#105411]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-snb4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][93] ([fdo#103166]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][95] ([fdo#109441]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@suspend:
- shard-tglb: [INCOMPLETE][97] ([fdo#111832] / [fdo#111850]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-tglb2/igt@kms_psr@suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-tglb9/igt@kms_psr@suspend.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][99] ([fdo#99912]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-kbl6/igt@kms_setmode@basic.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-kbl7/igt@kms_setmode@basic.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][101] ([fdo#109276]) -> [PASS][102] +23 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-iclb3/igt@prime_busy@hang-bsd2.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][103] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781]) -> [INCOMPLETE][104] ([fdo#105411])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb2/igt@gem_eio@kms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/shard-snb4/igt@gem_eio@kms.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [DMESG-WARN][105] ([fdo#111870]) -> [DMESG-WARN][106] ([fdo#110789] / [fdo#111870])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7402/shard-snb5/igt@gem_userptr_blits@sync-unmap.html
[106]: https://in
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3745/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-22 1:10 [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk don.hiatt
2019-11-22 1:54 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3) Patchwork
2019-11-23 8:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-11-26 0:49 ` Sujaritha
2019-11-26 9:52 ` Petri Latvala
2019-11-28 13:30 ` Petri Latvala
2 siblings, 2 replies; 13+ messages in thread
From: Sujaritha @ 2019-11-26 0:49 UTC (permalink / raw)
To: don.hiatt, igt-dev
On 11/21/19 5:10 PM, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
>
> Suspending to disk requires swap space, make sure it exists
> before attempting to suspend to disk.
>
> v2: Use igt_skip() [Thanks, Chris!]
> v3: Use igt_skip_on_f()
>
> Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
> lib/igt_aux.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index 578f857933f0..a6b114ed7e65 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
> igt_require(test == SUSPEND_TEST_NONE ||
> faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
>
> + igt_skip_on_f(state == SUSPEND_STATE_DISK &&
> + !intel_get_total_swap_mb(),
> + "Suspend to disk requires swap space.\n");
> +
> orig_test = get_suspend_test(power_dir);
> set_suspend_test(power_dir, test);
>
This should help fix part of the reason for the suspend tests failing on CI.
Reviewed-by : Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-26 0:49 ` [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk Sujaritha
@ 2019-11-26 9:52 ` Petri Latvala
2019-11-26 17:05 ` Hiatt, Don
2019-11-28 13:30 ` Petri Latvala
1 sibling, 1 reply; 13+ messages in thread
From: Petri Latvala @ 2019-11-26 9:52 UTC (permalink / raw)
To: Sujaritha; +Cc: igt-dev
On Mon, Nov 25, 2019 at 04:49:47PM -0800, Sujaritha wrote:
>
> On 11/21/19 5:10 PM, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Suspending to disk requires swap space, make sure it exists
> > before attempting to suspend to disk.
> >
> > v2: Use igt_skip() [Thanks, Chris!]
> > v3: Use igt_skip_on_f()
> >
> > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > lib/igt_aux.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > index 578f857933f0..a6b114ed7e65 100644
> > --- a/lib/igt_aux.c
> > +++ b/lib/igt_aux.c
> > @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
> > igt_require(test == SUSPEND_TEST_NONE ||
> > faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
> > + igt_skip_on_f(state == SUSPEND_STATE_DISK &&
> > + !intel_get_total_swap_mb(),
> > + "Suspend to disk requires swap space.\n");
> > +
> > orig_test = get_suspend_test(power_dir);
> > set_suspend_test(power_dir, test);
>
>
> This should help fix part of the reason for the suspend tests failing on CI.
If your goal is to enable s4 tests on CI, you still have quite a bit
of work ahead of you.
CI uses swap _files_. Suspending to swap files does work, if your
system is configured for the location of the swap space within the
block device (the resume_offset command line parameter). That hasn't
been configured at this time.
Possible further complications can arise from CI not using an initrd,
which presumably rules out using uswsusp to automate a lot of the
resume setup.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-26 9:52 ` Petri Latvala
@ 2019-11-26 17:05 ` Hiatt, Don
0 siblings, 0 replies; 13+ messages in thread
From: Hiatt, Don @ 2019-11-26 17:05 UTC (permalink / raw)
To: Latvala, Petri, Sundaresan, Sujaritha; +Cc: igt-dev
> From: Latvala, Petri <petri.latvala@intel.com>
> Sent: Tuesday, November 26, 2019 1:53 AM
> To: Sundaresan, Sujaritha <sujaritha.sundaresan@intel.com>
> Cc: Hiatt, Don <don.hiatt@intel.com>; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend
> to disk
>
> On Mon, Nov 25, 2019 at 04:49:47PM -0800, Sujaritha wrote:
> >
> > On 11/21/19 5:10 PM, don.hiatt@intel.com wrote:
> > > From: Don Hiatt <don.hiatt@intel.com>
> > >
> > > Suspending to disk requires swap space, make sure it exists
> > > before attempting to suspend to disk.
> > >
> > > v2: Use igt_skip() [Thanks, Chris!]
> > > v3: Use igt_skip_on_f()
> > >
> > > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > > ---
> > > lib/igt_aux.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > > index 578f857933f0..a6b114ed7e65 100644
> > > --- a/lib/igt_aux.c
> > > +++ b/lib/igt_aux.c
> > > @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum
> igt_suspend_state state,
> > > igt_require(test == SUSPEND_TEST_NONE ||
> > > faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
> > > + igt_skip_on_f(state == SUSPEND_STATE_DISK &&
> > > + !intel_get_total_swap_mb(),
> > > + "Suspend to disk requires swap space.\n");
> > > +
> > > orig_test = get_suspend_test(power_dir);
> > > set_suspend_test(power_dir, test);
> >
> >
> > This should help fix part of the reason for the suspend tests failing on CI.
>
>
> If your goal is to enable s4 tests on CI, you still have quite a bit
> of work ahead of you.
>
> CI uses swap _files_. Suspending to swap files does work, if your
> system is configured for the location of the swap space within the
> block device (the resume_offset command line parameter). That hasn't
> been configured at this time.
>
> Possible further complications can arise from CI not using an initrd,
> which presumably rules out using uswsusp to automate a lot of the
> resume setup.
>
>
Hi Petri,
That's not the current goal. I mostly want the warning on systems (e.g. RIL) that
don't have any swap at all setup as I keep getting stung by it. 😊
Thanks!
don
> --
> Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-26 0:49 ` [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk Sujaritha
2019-11-26 9:52 ` Petri Latvala
@ 2019-11-28 13:30 ` Petri Latvala
1 sibling, 0 replies; 13+ messages in thread
From: Petri Latvala @ 2019-11-28 13:30 UTC (permalink / raw)
To: Sujaritha; +Cc: igt-dev
On Mon, Nov 25, 2019 at 04:49:47PM -0800, Sujaritha wrote:
>
> On 11/21/19 5:10 PM, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Suspending to disk requires swap space, make sure it exists
> > before attempting to suspend to disk.
> >
> > v2: Use igt_skip() [Thanks, Chris!]
> > v3: Use igt_skip_on_f()
> >
> > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > lib/igt_aux.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > index 578f857933f0..a6b114ed7e65 100644
> > --- a/lib/igt_aux.c
> > +++ b/lib/igt_aux.c
> > @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
> > igt_require(test == SUSPEND_TEST_NONE ||
> > faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
> > + igt_skip_on_f(state == SUSPEND_STATE_DISK &&
> > + !intel_get_total_swap_mb(),
> > + "Suspend to disk requires swap space.\n");
> > +
> > orig_test = get_suspend_test(power_dir);
> > set_suspend_test(power_dir, test);
>
>
> This should help fix part of the reason for the suspend tests failing on CI.
>
> Reviewed-by : Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Almost accidentally dropped this R-b, patchwork didn't automatically add it due to the extra space before :
This patch is merged, thanks.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
@ 2019-11-22 1:08 don.hiatt
0 siblings, 0 replies; 13+ messages in thread
From: don.hiatt @ 2019-11-22 1:08 UTC (permalink / raw)
To: igt-dev
From: Don Hiatt <don.hiatt@intel.com>
Suspending to disk requires swap space, make sure it exists
before attempting to suspend to disk.
v2: Use igt_skip() [Thanks, Chris!]
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
lib/igt_aux.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 578f857933f0..f2a5bd71a110 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
igt_require(test == SUSPEND_TEST_NONE ||
faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
+ igt_skip(state == SUSPEND_STATE_DISK &&
+ !intel_get_total_swap_mb(),
+ "Suspend to disk requires swap space.\n");
+
orig_test = get_suspend_test(power_dir);
set_suspend_test(power_dir, test);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-22 0:52 ` Hiatt, Don
@ 2019-11-22 0:55 ` Chris Wilson
0 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2019-11-22 0:55 UTC (permalink / raw)
To: Hiatt, Don, igt-dev
Quoting Hiatt, Don (2019-11-22 00:52:53)
>
>
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Hiatt, Don
> > Sent: Thursday, November 21, 2019 4:41 PM
> > To: Chris Wilson <chris@chris-wilson.co.uk>; igt-dev@lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend
> > to disk
> >
> > > From: Chris Wilson <chris@chris-wilson.co.uk>
> > > Sent: Thursday, November 21, 2019 4:36 PM
> > > To: Hiatt, Don <don.hiatt@intel.com>; igt-dev@lists.freedesktop.org
> > > Subject: Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend
> > > to disk
> > >
> > > Quoting don.hiatt@intel.com (2019-11-22 00:43:53)
> > > > From: Don Hiatt <don.hiatt@intel.com>
> > > >
> > > > Suspending to disk requires swap space, make sure it exists
> > > > before attempting to suspend to disk.
> > > >
> > > > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > > > ---
> > > > lib/igt_aux.c | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > > > index 578f857933f0..31c01624a651 100644
> > > > --- a/lib/igt_aux.c
> > > > +++ b/lib/igt_aux.c
> > > > @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum
> > > igt_suspend_state state,
> > > > igt_require(test == SUSPEND_TEST_NONE ||
> > > > faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
> > > >
> > > > + if (state == SUSPEND_STATE_DISK)
> > > > + igt_require_f(intel_get_total_swap_mb() > 0,
> > >
> > > igt_skip_f(state == SUSPEND_STATE_DISK &&
> > > !intel_get_total_swap_mb(
> ),
> > >
> > > > + "Suspend to disk requires swap space.\n");
> > > > +
> > > > orig_test = get_suspend_test(power_dir);
> > > > set_suspend_test(power_dir, test);
> > > >
> >
> > Ahh! Thanks, Chris! I'll submit another one. Thank you!
> >
>
> Hi Chris, sorry, I don't see any igt_skip_f(), sorry if I'm missing something.
igt_skip_on_f()
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-22 0:40 ` Hiatt, Don
@ 2019-11-22 0:52 ` Hiatt, Don
2019-11-22 0:55 ` Chris Wilson
0 siblings, 1 reply; 13+ messages in thread
From: Hiatt, Don @ 2019-11-22 0:52 UTC (permalink / raw)
To: Chris Wilson, igt-dev
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Hiatt, Don
> Sent: Thursday, November 21, 2019 4:41 PM
> To: Chris Wilson <chris@chris-wilson.co.uk>; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend
> to disk
>
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> > Sent: Thursday, November 21, 2019 4:36 PM
> > To: Hiatt, Don <don.hiatt@intel.com>; igt-dev@lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend
> > to disk
> >
> > Quoting don.hiatt@intel.com (2019-11-22 00:43:53)
> > > From: Don Hiatt <don.hiatt@intel.com>
> > >
> > > Suspending to disk requires swap space, make sure it exists
> > > before attempting to suspend to disk.
> > >
> > > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > > ---
> > > lib/igt_aux.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > > index 578f857933f0..31c01624a651 100644
> > > --- a/lib/igt_aux.c
> > > +++ b/lib/igt_aux.c
> > > @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum
> > igt_suspend_state state,
> > > igt_require(test == SUSPEND_TEST_NONE ||
> > > faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
> > >
> > > + if (state == SUSPEND_STATE_DISK)
> > > + igt_require_f(intel_get_total_swap_mb() > 0,
> >
> > igt_skip_f(state == SUSPEND_STATE_DISK &&
> > !intel_get_total_swap_mb(
),
> >
> > > + "Suspend to disk requires swap space.\n");
> > > +
> > > orig_test = get_suspend_test(power_dir);
> > > set_suspend_test(power_dir, test);
> > >
>
> Ahh! Thanks, Chris! I'll submit another one. Thank you!
>
Hi Chris, sorry, I don't see any igt_skip_f(), sorry if I'm missing something.
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
@ 2019-11-22 0:43 don.hiatt
2019-11-22 0:36 ` Chris Wilson
0 siblings, 1 reply; 13+ messages in thread
From: don.hiatt @ 2019-11-22 0:43 UTC (permalink / raw)
To: igt-dev
From: Don Hiatt <don.hiatt@intel.com>
Suspending to disk requires swap space, make sure it exists
before attempting to suspend to disk.
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
lib/igt_aux.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 578f857933f0..31c01624a651 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
igt_require(test == SUSPEND_TEST_NONE ||
faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
+ if (state == SUSPEND_STATE_DISK)
+ igt_require_f(intel_get_total_swap_mb() > 0,
+ "Suspend to disk requires swap space.\n");
+
orig_test = get_suspend_test(power_dir);
set_suspend_test(power_dir, test);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-22 0:36 ` Chris Wilson
@ 2019-11-22 0:40 ` Hiatt, Don
2019-11-22 0:52 ` Hiatt, Don
0 siblings, 1 reply; 13+ messages in thread
From: Hiatt, Don @ 2019-11-22 0:40 UTC (permalink / raw)
To: Chris Wilson, igt-dev
> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Thursday, November 21, 2019 4:36 PM
> To: Hiatt, Don <don.hiatt@intel.com>; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend
> to disk
>
> Quoting don.hiatt@intel.com (2019-11-22 00:43:53)
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Suspending to disk requires swap space, make sure it exists
> > before attempting to suspend to disk.
> >
> > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > lib/igt_aux.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > index 578f857933f0..31c01624a651 100644
> > --- a/lib/igt_aux.c
> > +++ b/lib/igt_aux.c
> > @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum
> igt_suspend_state state,
> > igt_require(test == SUSPEND_TEST_NONE ||
> > faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
> >
> > + if (state == SUSPEND_STATE_DISK)
> > + igt_require_f(intel_get_total_swap_mb() > 0,
>
> igt_skip_f(state == SUSPEND_STATE_DISK &&
> !intel_get_total_swap_mb(),
>
> > + "Suspend to disk requires swap space.\n");
> > +
> > orig_test = get_suspend_test(power_dir);
> > set_suspend_test(power_dir, test);
> >
Ahh! Thanks, Chris! I'll submit another one. Thank you!
> > --
> > 2.17.1
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk
2019-11-22 0:43 don.hiatt
@ 2019-11-22 0:36 ` Chris Wilson
2019-11-22 0:40 ` Hiatt, Don
0 siblings, 1 reply; 13+ messages in thread
From: Chris Wilson @ 2019-11-22 0:36 UTC (permalink / raw)
To: don.hiatt, igt-dev
Quoting don.hiatt@intel.com (2019-11-22 00:43:53)
> From: Don Hiatt <don.hiatt@intel.com>
>
> Suspending to disk requires swap space, make sure it exists
> before attempting to suspend to disk.
>
> Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
> lib/igt_aux.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index 578f857933f0..31c01624a651 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -864,6 +864,10 @@ void igt_system_suspend_autoresume(enum igt_suspend_state state,
> igt_require(test == SUSPEND_TEST_NONE ||
> faccessat(power_dir, "pm_test", R_OK | W_OK, 0) == 0);
>
> + if (state == SUSPEND_STATE_DISK)
> + igt_require_f(intel_get_total_swap_mb() > 0,
igt_skip_f(state == SUSPEND_STATE_DISK &&
!intel_get_total_swap_mb(),
> + "Suspend to disk requires swap space.\n");
> +
> orig_test = get_suspend_test(power_dir);
> set_suspend_test(power_dir, test);
>
> --
> 2.17.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-11-28 13:30 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 1:10 [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk don.hiatt
2019-11-22 1:54 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/aux: Ensure swap space prior to suspend to disk (rev3) Patchwork
2019-11-23 8:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-26 0:49 ` [igt-dev] [PATCH i-g-t] lib/aux: Ensure swap space prior to suspend to disk Sujaritha
2019-11-26 9:52 ` Petri Latvala
2019-11-26 17:05 ` Hiatt, Don
2019-11-28 13:30 ` Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 1:08 don.hiatt
2019-11-22 0:43 don.hiatt
2019-11-22 0:36 ` Chris Wilson
2019-11-22 0:40 ` Hiatt, Don
2019-11-22 0:52 ` Hiatt, Don
2019-11-22 0:55 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.