From: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address
Date: Sun, 30 Oct 2016 16:34:18 +0100 [thread overview]
Message-ID: <6b13e96d-78d1-fcab-4273-803310ae4da6@suse.de> (raw)
In-Reply-To: <1477505640-26658-2-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
Hi,
Am 26.10.2016 um 20:14 schrieb Stefan Wahren:
> The address of the mailbox node in the bcm283x.dts has also a typo.
.dts -> .dtsi
"also has" or maybe "has the same typo as in the binding example"?
> So fix it accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> Fixes: 05b682b7a3b2 ("ARM: bcm2835: dt: Add the mailbox to the device tree")
> ---
> arch/arm/boot/dts/bcm283x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index 46d46d8..74dd21b 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -104,7 +104,7 @@
> reg = <0x7e104000 0x10>;
> };
>
> - mailbox: mailbox@7e00b800 {
> + mailbox: mailbox@7e00b880 {
> compatible = "brcm,bcm2835-mbox";
> reg = <0x7e00b880 0x40>;
> interrupts = <0 1>;
Otherwise,
Reviewed-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
At one point in time dtc did complain about such mismatches...
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address
Date: Sun, 30 Oct 2016 16:34:18 +0100 [thread overview]
Message-ID: <6b13e96d-78d1-fcab-4273-803310ae4da6@suse.de> (raw)
In-Reply-To: <1477505640-26658-2-git-send-email-stefan.wahren@i2se.com>
Hi,
Am 26.10.2016 um 20:14 schrieb Stefan Wahren:
> The address of the mailbox node in the bcm283x.dts has also a typo.
.dts -> .dtsi
"also has" or maybe "has the same typo as in the binding example"?
> So fix it accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 05b682b7a3b2 ("ARM: bcm2835: dt: Add the mailbox to the device tree")
> ---
> arch/arm/boot/dts/bcm283x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index 46d46d8..74dd21b 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -104,7 +104,7 @@
> reg = <0x7e104000 0x10>;
> };
>
> - mailbox: mailbox at 7e00b800 {
> + mailbox: mailbox at 7e00b880 {
> compatible = "brcm,bcm2835-mbox";
> reg = <0x7e00b880 0x40>;
> interrupts = <0 1>;
Otherwise,
Reviewed-by: Andreas F?rber <afaerber@suse.de>
At one point in time dtc did complain about such mismatches...
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2016-10-30 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 18:13 [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Stefan Wahren
2016-10-26 18:13 ` Stefan Wahren
[not found] ` <1477505640-26658-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
2016-10-26 18:14 ` Stefan Wahren
[not found] ` <1477505640-26658-2-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-10-27 18:00 ` Eric Anholt
2016-10-27 18:00 ` Eric Anholt
2016-10-30 15:34 ` Andreas Färber [this message]
2016-10-30 15:34 ` Andreas Färber
[not found] ` <6b13e96d-78d1-fcab-4273-803310ae4da6-l3A5Bk7waGM@public.gmane.org>
2016-10-30 17:22 ` [PATCH V2 " Stefan Wahren
2016-10-30 17:22 ` Stefan Wahren
[not found] ` <1477848139-32267-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-10-31 18:06 ` Eric Anholt
2016-10-31 18:06 ` Eric Anholt
2016-10-30 15:26 ` [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Andreas Färber
2016-10-30 15:26 ` Andreas Färber
2016-10-31 4:31 ` Rob Herring
2016-10-31 4:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b13e96d-78d1-fcab-4273-803310ae4da6@suse.de \
--to=afaerber-l3a5bk7wagm@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.