[Qemu-devel] [PATCH] cpu-exec: Move down some declarations in cpu_exec()

[Qemu-devel] [PATCH] cpu-exec: Move down some declarations in cpu_exec()

[Sergey Fedorov]

From: Sergey Fedorov <serge.fdrv@gmail.com>

This will fix a compiler warning with -Wclobbered:

http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg03347.html

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
---
 cpu-exec.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/cpu-exec.c b/cpu-exec.c
index b840e1d2dd41..5d9710a1eaf2 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -608,17 +608,16 @@ int cpu_exec(CPUState *cpu)
     init_delay_params(&sc, cpu);
 
     for(;;) {
-        TranslationBlock *tb, *last_tb;
-        int tb_exit = 0;
-
         /* prepare setjmp context for exception handling */
         if (sigsetjmp(cpu->jmp_env, 0) == 0) {
+            TranslationBlock *tb, *last_tb = NULL;
+            int tb_exit = 0;
+
             /* if an exception is pending, we execute it here */
             if (cpu_handle_exception(cpu, &ret)) {
                 break;
             }
 
-            last_tb = NULL; /* forget the last executed TB after exception */
             cpu->tb_flushed = false; /* reset before first TB lookup */
             for(;;) {
                 cpu_handle_interrupt(cpu, &last_tb);
-- 
2.9.1

Re: [Qemu-devel] [PATCH] cpu-exec: Move down some declarations in cpu_exec()

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]

Am 15.07.2016 um 21:31 schrieb Sergey Fedorov:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
> 
> This will fix a compiler warning with -Wclobbered:
> 
> http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg03347.html
> 
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
>  cpu-exec.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/cpu-exec.c b/cpu-exec.c
> index b840e1d2dd41..5d9710a1eaf2 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -608,17 +608,16 @@ int cpu_exec(CPUState *cpu)
>      init_delay_params(&sc, cpu);
>  
>      for(;;) {
> -        TranslationBlock *tb, *last_tb;
> -        int tb_exit = 0;
> -
>          /* prepare setjmp context for exception handling */
>          if (sigsetjmp(cpu->jmp_env, 0) == 0) {
> +            TranslationBlock *tb, *last_tb = NULL;
> +            int tb_exit = 0;
> +
>              /* if an exception is pending, we execute it here */
>              if (cpu_handle_exception(cpu, &ret)) {
>                  break;
>              }
>  
> -            last_tb = NULL; /* forget the last executed TB after exception */
>              cpu->tb_flushed = false; /* reset before first TB lookup */
>              for(;;) {
>                  cpu_handle_interrupt(cpu, &last_tb);
> 

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Thanks.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]