From: Michael Walle <michael@walle.cc>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: add support for mx77l51250f
Date: Mon, 09 Jan 2023 15:20:23 +0100 [thread overview]
Message-ID: <6b4780f5366de7f0dd59da0ed4f9a948@walle.cc> (raw)
In-Reply-To: <CY5PR11MB636696A89B94C4C659738290EDFE9@CY5PR11MB6366.namprd11.prod.outlook.com>
Am 2023-01-09 15:09, schrieb Usyskin, Alexander:
>> > --- a/drivers/mtd/spi-nor/macronix.c
>> > +++ b/drivers/mtd/spi-nor/macronix.c
>> > @@ -100,6 +100,8 @@ static const struct flash_info macronix_nor_parts[]
>> > = {
>> > { "mx66u2g45g", INFO(0xc2253c, 0, 64 * 1024, 4096)
>> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>> SPI_NOR_QUAD_READ)
>> > FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
>> > + { "mx77l51250f", INFO(0xc2751a, 0, 64 * 1024, 4096)
>> > + PARSE_SFDP },
>>
>> With the newest generic spi nor driver [1] this patch shouldn't
>> be needed at all anymore. Could you verify, that your flash will work
>> without it?
>>
>> -michael
>>
>> [1]
>> https://elixir.bootlin.com/linux/v6.2-rc3/source/drivers/mtd/spi-
>> nor/core.c#L1637
>
> Tested now, the v6.2-rc3 recognizes the chip.
> Does this mean that all SFDP-supporting chips will be recognized
> automatically?
As long as you just want to use the standard features described by SFDP,
yes. There might be lacking support for some SFDP features, though.
These
should then be added to the SFDP parser.
But, there are also features, which aren't supported by SFDP, i.e.
locking
or OTP. If you want to use these, you still need a flash table entry.
-michael
> Tomas, we can abandon upstreaming effort, I'll save the patch if it
> will needed by older kernel versions.
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: add support for mx77l51250f
Date: Mon, 09 Jan 2023 15:20:23 +0100 [thread overview]
Message-ID: <6b4780f5366de7f0dd59da0ed4f9a948@walle.cc> (raw)
In-Reply-To: <CY5PR11MB636696A89B94C4C659738290EDFE9@CY5PR11MB6366.namprd11.prod.outlook.com>
Am 2023-01-09 15:09, schrieb Usyskin, Alexander:
>> > --- a/drivers/mtd/spi-nor/macronix.c
>> > +++ b/drivers/mtd/spi-nor/macronix.c
>> > @@ -100,6 +100,8 @@ static const struct flash_info macronix_nor_parts[]
>> > = {
>> > { "mx66u2g45g", INFO(0xc2253c, 0, 64 * 1024, 4096)
>> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>> SPI_NOR_QUAD_READ)
>> > FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
>> > + { "mx77l51250f", INFO(0xc2751a, 0, 64 * 1024, 4096)
>> > + PARSE_SFDP },
>>
>> With the newest generic spi nor driver [1] this patch shouldn't
>> be needed at all anymore. Could you verify, that your flash will work
>> without it?
>>
>> -michael
>>
>> [1]
>> https://elixir.bootlin.com/linux/v6.2-rc3/source/drivers/mtd/spi-
>> nor/core.c#L1637
>
> Tested now, the v6.2-rc3 recognizes the chip.
> Does this mean that all SFDP-supporting chips will be recognized
> automatically?
As long as you just want to use the standard features described by SFDP,
yes. There might be lacking support for some SFDP features, though.
These
should then be added to the SFDP parser.
But, there are also features, which aren't supported by SFDP, i.e.
locking
or OTP. If you want to use these, you still need a flash table entry.
-michael
> Tomas, we can abandon upstreaming effort, I'll save the patch if it
> will needed by older kernel versions.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-01-09 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 21:43 [PATCH v2] mtd: spi-nor: macronix: add support for mx77l51250f Tomas Winkler
2023-01-07 21:43 ` Tomas Winkler
2023-01-09 5:04 ` Dhruva Gole
2023-01-09 5:04 ` Dhruva Gole
2023-01-09 8:49 ` Michael Walle
2023-01-09 8:49 ` Michael Walle
2023-01-09 14:09 ` Usyskin, Alexander
2023-01-09 14:09 ` Usyskin, Alexander
2023-01-09 14:20 ` Michael Walle [this message]
2023-01-09 14:20 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b4780f5366de7f0dd59da0ed4f9a948@walle.cc \
--to=michael@walle.cc \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tomas.winkler@intel.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.