From: Lyude Paul <lyude@redhat.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Wayne Lin <Wayne.Lin@amd.com>
Subject: Re: [PATCH] drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()
Date: Wed, 16 Jun 2021 15:47:26 -0400 [thread overview]
Message-ID: <6b5b8d478b3ecb33858c3f55f432178c0917ffb4.camel@redhat.com> (raw)
In-Reply-To: <20210616194415.36926-1-jose.souza@intel.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will go ahead and push this to drm-misc-next-fixes, thanks
On Wed, 2021-06-16 at 12:44 -0700, José Roberto de Souza wrote:
> Commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by
> ports in stale topology") added to calls to drm_dbg_kms() but it
> missed the first parameter, the drm device breaking the build.
>
> Fixes: 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in
> stale topology")
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 9ac148efd9e43..ad0795afc21cf 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -3389,7 +3389,9 @@ int drm_dp_update_payload_part1(struct
> drm_dp_mst_topology_mgr *mgr)
> mutex_unlock(&mgr->lock);
>
> if (skip) {
> - drm_dbg_kms("Virtual channel %d is not in
> current topology\n", i);
> + drm_dbg_kms(mgr->dev,
> + "Virtual channel %d is not in
> current topology\n",
> + i);
> continue;
> }
> /* Validated ports don't matter if we're releasing
> @@ -3404,7 +3406,8 @@ int drm_dp_update_payload_part1(struct
> drm_dp_mst_topology_mgr *mgr)
> payload->start_slot =
> req_payload.start_slot;
> continue;
> } else {
> - drm_dbg_kms("Fail:set
> payload to invalid sink");
> + drm_dbg_kms(mgr->dev,
> + "Fail:set
> payload to invalid sink");
> mutex_unlock(&mgr-
> >payload_lock);
> return -EINVAL;
> }
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Wayne Lin <Wayne.Lin@amd.com>
Subject: Re: [Intel-gfx] [PATCH] drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()
Date: Wed, 16 Jun 2021 15:47:26 -0400 [thread overview]
Message-ID: <6b5b8d478b3ecb33858c3f55f432178c0917ffb4.camel@redhat.com> (raw)
In-Reply-To: <20210616194415.36926-1-jose.souza@intel.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will go ahead and push this to drm-misc-next-fixes, thanks
On Wed, 2021-06-16 at 12:44 -0700, José Roberto de Souza wrote:
> Commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by
> ports in stale topology") added to calls to drm_dbg_kms() but it
> missed the first parameter, the drm device breaking the build.
>
> Fixes: 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in
> stale topology")
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 9ac148efd9e43..ad0795afc21cf 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -3389,7 +3389,9 @@ int drm_dp_update_payload_part1(struct
> drm_dp_mst_topology_mgr *mgr)
> mutex_unlock(&mgr->lock);
>
> if (skip) {
> - drm_dbg_kms("Virtual channel %d is not in
> current topology\n", i);
> + drm_dbg_kms(mgr->dev,
> + "Virtual channel %d is not in
> current topology\n",
> + i);
> continue;
> }
> /* Validated ports don't matter if we're releasing
> @@ -3404,7 +3406,8 @@ int drm_dp_update_payload_part1(struct
> drm_dp_mst_topology_mgr *mgr)
> payload->start_slot =
> req_payload.start_slot;
> continue;
> } else {
> - drm_dbg_kms("Fail:set
> payload to invalid sink");
> + drm_dbg_kms(mgr->dev,
> + "Fail:set
> payload to invalid sink");
> mutex_unlock(&mgr-
> >payload_lock);
> return -EINVAL;
> }
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-16 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 19:44 [PATCH] drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms() José Roberto de Souza
2021-06-16 19:44 ` [Intel-gfx] " José Roberto de Souza
2021-06-16 19:47 ` Lyude Paul [this message]
2021-06-16 19:47 ` Lyude Paul
2021-06-17 8:20 ` Lin, Wayne
2021-06-17 8:20 ` [Intel-gfx] " Lin, Wayne
2021-06-18 15:54 ` Lyude Paul
2021-06-18 15:54 ` [Intel-gfx] " Lyude Paul
2021-06-16 20:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b5b8d478b3ecb33858c3f55f432178c0917ffb4.camel@redhat.com \
--to=lyude@redhat.com \
--cc=Wayne.Lin@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.