From: Randy Dunlap <rdunlap@infradead.org> To: LKML <linux-kernel@vger.kernel.org>, Vineet Gupta <vgupta@synopsys.com>, "linux-snps-arc@lists.infradead.org" <linux-snps-arc@lists.infradead.org>, Dan Williams <dan.j.williams@intel.com> Cc: kernel test robot <lkp@intel.com> Subject: [PATCH] fs: dax: fix build error on ARC Date: Tue, 6 Oct 2020 19:54:41 -0700 [thread overview] Message-ID: <6b5c6090-331d-7485-da4a-45e9c7f13be1@infradead.org> (raw) From: Randy Dunlap <rdunlap@infradead.org> fs/dax.c uses copy_user_page() but ARC does not provide that interface, resulting in a build error. Provide copy_user_page() in <asm/page.h> (beside copy_page()) and add <asm/page.h> to fs/dax.c to fix the build error. ../fs/dax.c: In function 'copy_cow_page_dax': ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration] Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Vineet Gupta <vgupta@synopsys.com> Cc: linux-snps-arc@lists.infradead.org Cc: Dan Williams <dan.j.williams@intel.com> --- Vineet, This patch fixes the build error but is it correct for ARC? arch/arc/include/asm/page.h | 1 + fs/dax.c | 1 + 2 files changed, 2 insertions(+) --- lnx-59-rc7.orig/fs/dax.c +++ lnx-59-rc7/fs/dax.c @@ -25,6 +25,7 @@ #include <linux/sizes.h> #include <linux/mmu_notifier.h> #include <linux/iomap.h> +#include <asm/page.h> #include <asm/pgalloc.h> #define CREATE_TRACE_POINTS --- lnx-59-rc7.orig/arch/arc/include/asm/page.h +++ lnx-59-rc7/arch/arc/include/asm/page.h @@ -10,6 +10,7 @@ #ifndef __ASSEMBLY__ #define clear_page(paddr) memset((paddr), 0, PAGE_SIZE) +#define copy_user_page(to, from, vaddr, pg) copy_page(to, from) #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) struct vm_area_struct;
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: LKML <linux-kernel@vger.kernel.org>, Vineet Gupta <vgupta@synopsys.com>, "linux-snps-arc@lists.infradead.org" <linux-snps-arc@lists.infradead.org>, Dan Williams <dan.j.williams@intel.com> Cc: kernel test robot <lkp@intel.com> Subject: [PATCH] fs: dax: fix build error on ARC Date: Tue, 6 Oct 2020 19:54:41 -0700 [thread overview] Message-ID: <6b5c6090-331d-7485-da4a-45e9c7f13be1@infradead.org> (raw) From: Randy Dunlap <rdunlap@infradead.org> fs/dax.c uses copy_user_page() but ARC does not provide that interface, resulting in a build error. Provide copy_user_page() in <asm/page.h> (beside copy_page()) and add <asm/page.h> to fs/dax.c to fix the build error. ../fs/dax.c: In function 'copy_cow_page_dax': ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration] Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Vineet Gupta <vgupta@synopsys.com> Cc: linux-snps-arc@lists.infradead.org Cc: Dan Williams <dan.j.williams@intel.com> --- Vineet, This patch fixes the build error but is it correct for ARC? arch/arc/include/asm/page.h | 1 + fs/dax.c | 1 + 2 files changed, 2 insertions(+) --- lnx-59-rc7.orig/fs/dax.c +++ lnx-59-rc7/fs/dax.c @@ -25,6 +25,7 @@ #include <linux/sizes.h> #include <linux/mmu_notifier.h> #include <linux/iomap.h> +#include <asm/page.h> #include <asm/pgalloc.h> #define CREATE_TRACE_POINTS --- lnx-59-rc7.orig/arch/arc/include/asm/page.h +++ lnx-59-rc7/arch/arc/include/asm/page.h @@ -10,6 +10,7 @@ #ifndef __ASSEMBLY__ #define clear_page(paddr) memset((paddr), 0, PAGE_SIZE) +#define copy_user_page(to, from, vaddr, pg) copy_page(to, from) #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) struct vm_area_struct; _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next reply other threads:[~2020-10-07 2:54 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-07 2:54 Randy Dunlap [this message] 2020-10-07 2:54 ` [PATCH] fs: dax: fix build error on ARC Randy Dunlap 2020-10-07 3:05 ` Vineet Gupta 2020-10-07 3:05 ` Vineet Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6b5c6090-331d-7485-da4a-45e9c7f13be1@infradead.org \ --to=rdunlap@infradead.org \ --cc=dan.j.williams@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-snps-arc@lists.infradead.org \ --cc=lkp@intel.com \ --cc=vgupta@synopsys.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.