All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/tests: Add back seed value information
@ 2022-10-26 21:14 ` Arthur Grillo
  0 siblings, 0 replies; 10+ messages in thread
From: Arthur Grillo @ 2022-10-26 21:14 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Javier Martinez Canillas,
	Maíra Canal, Toke Høiland-Jørgensen,
	Jason A. Donenfeld
  Cc: dri-devel, linux-kernel, David Gow, Daniel Latypov, andrealmeid,
	melissa.srw, Arthur Grillo, Michał Winiarski

As reported by Michał the drm_mm and drm_buddy unit tests lost the
printk with seed value after they being refactored into kunit. This
patch adds back this important information to assure reproducibility
converting them to use the kunit api.

Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
Reported-by: Michał Winiarski <michal.winiarski@intel.com>
---
 drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++
 drivers/gpu/drm/tests/drm_mm_test.c    | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
index 62f69589a72d..83c8863bc643 100644
--- a/drivers/gpu/drm/tests/drm_buddy_test.c
+++ b/drivers/gpu/drm/tests/drm_buddy_test.c
@@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test)
 	while (!random_seed)
 		random_seed = get_random_u32();
 
+	kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
+		random_seed);
+
 	return 0;
 }
 
diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c
index c4b66eeae203..492347069d58 100644
--- a/drivers/gpu/drm/tests/drm_mm_test.c
+++ b/drivers/gpu/drm/tests/drm_mm_test.c
@@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test)
 	while (!random_seed)
 		random_seed = get_random_u32();
 
+	kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
+	random_seed, max_iterations, max_prime);
+
 	return 0;
 }
 
@@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = {
 };
 
 kunit_test_suite(drm_mm_test_suite);
-
 MODULE_AUTHOR("Intel Corporation");
 MODULE_LICENSE("GPL");
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-10-27  8:31 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 21:14 [PATCH] drm/tests: Add back seed value information Arthur Grillo
2022-10-26 21:14 ` Arthur Grillo
2022-10-26 21:34 ` Maíra Canal
2022-10-26 21:34   ` Maíra Canal
2022-10-26 21:38 ` André Almeida
2022-10-26 21:38   ` André Almeida
2022-10-27  0:44 ` kernel test robot
2022-10-27  0:44   ` kernel test robot
2022-10-27  8:29 ` kernel test robot
2022-10-27  8:29   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.