All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>
Cc: Alexandre Bailon <abailon@baylibre.com>,
	Balsam CHIHI <bchihi@baylibre.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Chen-Yu Tsai <wenst@chromium.org>,
	kernel@collabora.com, Amit Kucheria <amitk@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 1/6] thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers
Date: Fri, 7 Jul 2023 15:46:17 +0200	[thread overview]
Message-ID: <6bf8d06a-8c65-4d7a-14a1-13597cd9a2de@baylibre.com> (raw)
In-Reply-To: <20230706153823.201943-2-nfraprado@collabora.com>



On 06/07/2023 17:37, Nícolas F. R. A. Prado wrote:
> There is a single IRQ handler for each LVTS thermal domain, and it is
> supposed to check each of its underlying controllers for the origin of
> the interrupt and clear its status. However due to a typo, only the
> first controller was ever being handled, which resulted in the interrupt
> never being cleared when it happened on the other controllers. Add the
> missing index so interrupts are handled for all controllers.

Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>

-- 
Regards,
Alexandre

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>
Cc: Alexandre Bailon <abailon@baylibre.com>,
	Balsam CHIHI <bchihi@baylibre.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Chen-Yu Tsai <wenst@chromium.org>,
	kernel@collabora.com, Amit Kucheria <amitk@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 1/6] thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers
Date: Fri, 7 Jul 2023 15:46:17 +0200	[thread overview]
Message-ID: <6bf8d06a-8c65-4d7a-14a1-13597cd9a2de@baylibre.com> (raw)
In-Reply-To: <20230706153823.201943-2-nfraprado@collabora.com>



On 06/07/2023 17:37, Nícolas F. R. A. Prado wrote:
> There is a single IRQ handler for each LVTS thermal domain, and it is
> supposed to check each of its underlying controllers for the origin of
> the interrupt and clear its status. However due to a typo, only the
> first controller was ever being handled, which resulted in the interrupt
> never being cleared when it happened on the other controllers. Add the
> missing index so interrupts are handled for all controllers.

Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>

-- 
Regards,
Alexandre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-07-07 13:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 15:37 [PATCH v3 0/6] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling Nícolas F. R. A. Prado
2023-07-06 15:37 ` Nícolas F. R. A. Prado
2023-07-06 15:37 ` [PATCH v3 1/6] thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers Nícolas F. R. A. Prado
2023-07-06 15:37   ` Nícolas F. R. A. Prado
2023-07-07 13:46   ` Alexandre Mergnat [this message]
2023-07-07 13:46     ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 2/6] thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode Nícolas F. R. A. Prado
2023-07-06 15:37   ` Nícolas F. R. A. Prado
2023-07-07 13:50   ` Alexandre Mergnat
2023-07-07 13:50     ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 3/6] thermal/drivers/mediatek/lvts_thermal: Use offset threshold for IRQ Nícolas F. R. A. Prado
2023-07-06 15:37   ` Nícolas F. R. A. Prado
2023-07-07  8:21   ` AngeloGioacchino Del Regno
2023-07-07  8:21     ` AngeloGioacchino Del Regno
2023-07-07 13:54   ` Alexandre Mergnat
2023-07-07 13:54     ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 4/6] thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts Nícolas F. R. A. Prado
2023-07-06 15:37   ` Nícolas F. R. A. Prado
2023-07-07  8:21   ` AngeloGioacchino Del Regno
2023-07-07  8:21     ` AngeloGioacchino Del Regno
2023-07-07 13:58   ` Alexandre Mergnat
2023-07-07 13:58     ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 5/6] thermal/drivers/mediatek/lvts_thermal: Don't leave threshold zeroed Nícolas F. R. A. Prado
2023-07-06 15:37   ` Nícolas F. R. A. Prado
2023-07-07  8:22   ` AngeloGioacchino Del Regno
2023-07-07  8:22     ` AngeloGioacchino Del Regno
2023-07-07 14:05   ` Alexandre Mergnat
2023-07-07 14:05     ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 6/6] thermal/drivers/mediatek/lvts_thermal: Manage threshold between sensors Nícolas F. R. A. Prado
2023-07-06 15:37   ` Nícolas F. R. A. Prado
2023-07-07  8:22   ` AngeloGioacchino Del Regno
2023-07-07  8:22     ` AngeloGioacchino Del Regno
2023-07-07 14:11   ` Alexandre Mergnat
2023-07-07 14:11     ` Alexandre Mergnat
2023-07-13  9:04 ` [PATCH v3 0/6] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling Daniel Lezcano
2023-07-13  9:04   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bf8d06a-8c65-4d7a-14a1-13597cd9a2de@baylibre.com \
    --to=amergnat@baylibre.com \
    --cc=abailon@baylibre.com \
    --cc=amitk@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bchihi@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.