All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc()
@ 2022-01-11 14:58 Heinrich Schuchardt
  2022-01-14 14:26 ` Patrice CHOTARD
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2022-01-11 14:58 UTC (permalink / raw)
  To: Patrick Delaunay, Patrice Chotard
  Cc: uboot-stm32, u-boot, Heinrich Schuchardt

MAX_SEARCH_PARTITIONS is the highest possible partition number.
Do not skip the last partition in board_get_alt_info_mmc().

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 board/st/common/stm32mp_dfu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/st/common/stm32mp_dfu.c b/board/st/common/stm32mp_dfu.c
index a3f0da5b5b..fa48b2a35e 100644
--- a/board/st/common/stm32mp_dfu.c
+++ b/board/st/common/stm32mp_dfu.c
@@ -57,7 +57,7 @@ static void board_get_alt_info_mmc(struct udevice *dev, char *buf)
 		first = false;
 	}
 
-	for (p = 1; p < MAX_SEARCH_PARTITIONS; p++) {
+	for (p = 1; p <= MAX_SEARCH_PARTITIONS; p++) {
 		if (part_get_info(desc, p, &info))
 			continue;
 		if (!first)
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc()
  2022-01-11 14:58 [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc() Heinrich Schuchardt
@ 2022-01-14 14:26 ` Patrice CHOTARD
  2022-01-21  8:43 ` Patrick DELAUNAY
  2022-01-24 12:14 ` Patrice CHOTARD
  2 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2022-01-14 14:26 UTC (permalink / raw)
  To: Heinrich Schuchardt, Patrick Delaunay; +Cc: uboot-stm32, u-boot

Hi Heinrich

On 1/11/22 3:58 PM, Heinrich Schuchardt wrote:
> MAX_SEARCH_PARTITIONS is the highest possible partition number.
> Do not skip the last partition in board_get_alt_info_mmc().
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  board/st/common/stm32mp_dfu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/st/common/stm32mp_dfu.c b/board/st/common/stm32mp_dfu.c
> index a3f0da5b5b..fa48b2a35e 100644
> --- a/board/st/common/stm32mp_dfu.c
> +++ b/board/st/common/stm32mp_dfu.c
> @@ -57,7 +57,7 @@ static void board_get_alt_info_mmc(struct udevice *dev, char *buf)
>  		first = false;
>  	}
>  
> -	for (p = 1; p < MAX_SEARCH_PARTITIONS; p++) {
> +	for (p = 1; p <= MAX_SEARCH_PARTITIONS; p++) {
>  		if (part_get_info(desc, p, &info))
>  			continue;
>  		if (!first)
> 

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc()
  2022-01-11 14:58 [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc() Heinrich Schuchardt
  2022-01-14 14:26 ` Patrice CHOTARD
@ 2022-01-21  8:43 ` Patrick DELAUNAY
  2022-01-24 12:14 ` Patrice CHOTARD
  2 siblings, 0 replies; 4+ messages in thread
From: Patrick DELAUNAY @ 2022-01-21  8:43 UTC (permalink / raw)
  To: Heinrich Schuchardt, Patrice Chotard; +Cc: uboot-stm32, u-boot

Hi,

On 1/11/22 3:58 PM, Heinrich Schuchardt wrote:
> MAX_SEARCH_PARTITIONS is the highest possible partition number.
> Do not skip the last partition in board_get_alt_info_mmc().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>   board/st/common/stm32mp_dfu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/st/common/stm32mp_dfu.c b/board/st/common/stm32mp_dfu.c
> index a3f0da5b5b..fa48b2a35e 100644
> --- a/board/st/common/stm32mp_dfu.c
> +++ b/board/st/common/stm32mp_dfu.c
> @@ -57,7 +57,7 @@ static void board_get_alt_info_mmc(struct udevice *dev, char *buf)
>   		first = false;
>   	}
>   
> -	for (p = 1; p < MAX_SEARCH_PARTITIONS; p++) {
> +	for (p = 1; p <= MAX_SEARCH_PARTITIONS; p++) {
>   		if (part_get_info(desc, p, &info))
>   			continue;
>   		if (!first)




Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick




^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc()
  2022-01-11 14:58 [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc() Heinrich Schuchardt
  2022-01-14 14:26 ` Patrice CHOTARD
  2022-01-21  8:43 ` Patrick DELAUNAY
@ 2022-01-24 12:14 ` Patrice CHOTARD
  2 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2022-01-24 12:14 UTC (permalink / raw)
  To: Heinrich Schuchardt, Patrick Delaunay; +Cc: uboot-stm32, u-boot

Hi Heinrich

On 1/11/22 15:58, Heinrich Schuchardt wrote:
> MAX_SEARCH_PARTITIONS is the highest possible partition number.
> Do not skip the last partition in board_get_alt_info_mmc().
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  board/st/common/stm32mp_dfu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/st/common/stm32mp_dfu.c b/board/st/common/stm32mp_dfu.c
> index a3f0da5b5b..fa48b2a35e 100644
> --- a/board/st/common/stm32mp_dfu.c
> +++ b/board/st/common/stm32mp_dfu.c
> @@ -57,7 +57,7 @@ static void board_get_alt_info_mmc(struct udevice *dev, char *buf)
>  		first = false;
>  	}
>  
> -	for (p = 1; p < MAX_SEARCH_PARTITIONS; p++) {
> +	for (p = 1; p <= MAX_SEARCH_PARTITIONS; p++) {
>  		if (part_get_info(desc, p, &info))
>  			continue;
>  		if (!first)
Applied to u-boot-stm/master

Thanks
Patrice

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-24 12:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 14:58 [PATCH 1/1] stm32mp: fix board_get_alt_info_mmc() Heinrich Schuchardt
2022-01-14 14:26 ` Patrice CHOTARD
2022-01-21  8:43 ` Patrick DELAUNAY
2022-01-24 12:14 ` Patrice CHOTARD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.