* [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
@ 2022-06-29 3:29 ` GONG, Ruiqi
0 siblings, 0 replies; 6+ messages in thread
From: GONG, Ruiqi @ 2022-06-29 3:29 UTC (permalink / raw)
To: Kees Cook, Marco Elver
Cc: Christophe Leroy, Xiu Jianfeng, kernel-hardening, linuxppc-dev,
linux-kernel, Gong Ruiqi
Fix the following Sparse warnings that got noticed when the PPC-dev
patchwork was checking another patch (see the link below):
init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
Which in fact are triggered on all architectures that have
HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
etc).
Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
---
init/main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/init/main.c b/init/main.c
index e2490387db2b..6aa0fb2340cc 100644
--- a/init/main.c
+++ b/init/main.c
@@ -101,6 +101,10 @@
#include <linux/stackdepot.h>
#include <net/net_namespace.h>
+#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
+#include <linux/randomize_kstack.h>
+#endif
+
#include <asm/io.h>
#include <asm/bugs.h>
#include <asm/setup.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
@ 2022-06-29 3:29 ` GONG, Ruiqi
0 siblings, 0 replies; 6+ messages in thread
From: GONG, Ruiqi @ 2022-06-29 3:29 UTC (permalink / raw)
To: Kees Cook, Marco Elver
Cc: Xiu Jianfeng, kernel-hardening, linux-kernel, Gong Ruiqi, linuxppc-dev
Fix the following Sparse warnings that got noticed when the PPC-dev
patchwork was checking another patch (see the link below):
init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
Which in fact are triggered on all architectures that have
HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
etc).
Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
---
init/main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/init/main.c b/init/main.c
index e2490387db2b..6aa0fb2340cc 100644
--- a/init/main.c
+++ b/init/main.c
@@ -101,6 +101,10 @@
#include <linux/stackdepot.h>
#include <net/net_namespace.h>
+#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
+#include <linux/randomize_kstack.h>
+#endif
+
#include <asm/io.h>
#include <asm/bugs.h>
#include <asm/setup.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
2022-06-29 3:29 ` GONG, Ruiqi
@ 2022-06-29 5:10 ` Christophe Leroy
-1 siblings, 0 replies; 6+ messages in thread
From: Christophe Leroy @ 2022-06-29 5:10 UTC (permalink / raw)
To: GONG, Ruiqi, Kees Cook, Marco Elver
Cc: Xiu Jianfeng, kernel-hardening, linuxppc-dev, linux-kernel
Le 29/06/2022 à 05:29, GONG, Ruiqi a écrit :
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
>
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
>
> Which in fact are triggered on all architectures that have
> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
> etc).
>
> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
> ---
> init/main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/init/main.c b/init/main.c
> index e2490387db2b..6aa0fb2340cc 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -101,6 +101,10 @@
> #include <linux/stackdepot.h>
> #include <net/net_namespace.h>
>
> +#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
You don't need this #ifdef, there is already one inside
linux/randomize_kstack.h
> +#include <linux/randomize_kstack.h>
> +#endif
> +
> #include <asm/io.h>
> #include <asm/bugs.h>
> #include <asm/setup.h>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
@ 2022-06-29 5:10 ` Christophe Leroy
0 siblings, 0 replies; 6+ messages in thread
From: Christophe Leroy @ 2022-06-29 5:10 UTC (permalink / raw)
To: GONG, Ruiqi, Kees Cook, Marco Elver
Cc: linuxppc-dev, linux-kernel, Xiu Jianfeng, kernel-hardening
Le 29/06/2022 à 05:29, GONG, Ruiqi a écrit :
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
>
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
>
> Which in fact are triggered on all architectures that have
> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
> etc).
>
> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
> ---
> init/main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/init/main.c b/init/main.c
> index e2490387db2b..6aa0fb2340cc 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -101,6 +101,10 @@
> #include <linux/stackdepot.h>
> #include <net/net_namespace.h>
>
> +#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
You don't need this #ifdef, there is already one inside
linux/randomize_kstack.h
> +#include <linux/randomize_kstack.h>
> +#endif
> +
> #include <asm/io.h>
> #include <asm/bugs.h>
> #include <asm/setup.h>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
2022-06-29 5:10 ` Christophe Leroy
@ 2022-06-29 5:51 ` Gong Ruiqi
-1 siblings, 0 replies; 6+ messages in thread
From: Gong Ruiqi @ 2022-06-29 5:51 UTC (permalink / raw)
To: Christophe Leroy, Kees Cook, Marco Elver
Cc: Xiu Jianfeng, kernel-hardening, linuxppc-dev, linux-kernel
On 2022/06/29 13:10, Christophe Leroy wrote:
>
>
> Le 29/06/2022 à 05:29, GONG, Ruiqi a écrit :
>> Fix the following Sparse warnings that got noticed when the PPC-dev
>> patchwork was checking another patch (see the link below):
>>
>> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
>> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
>>
>> Which in fact are triggered on all architectures that have
>> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
>> etc).
>>
>> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
>> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
>> ---
>> init/main.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/init/main.c b/init/main.c
>> index e2490387db2b..6aa0fb2340cc 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -101,6 +101,10 @@
>> #include <linux/stackdepot.h>
>> #include <net/net_namespace.h>
>>
>> +#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
>
> You don't need this #ifdef, there is already one inside
> linux/randomize_kstack.h
>
Ah yes, I didn't notice the config was there already. I will send a new
version. Thanks for your reminder!
>> +#include <linux/randomize_kstack.h>
>> +#endif
>> +
>> #include <asm/io.h>
>> #include <asm/bugs.h>
>> #include <asm/setup.h>
>> --
>> 2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
@ 2022-06-29 5:51 ` Gong Ruiqi
0 siblings, 0 replies; 6+ messages in thread
From: Gong Ruiqi @ 2022-06-29 5:51 UTC (permalink / raw)
To: Christophe Leroy, Kees Cook, Marco Elver
Cc: linuxppc-dev, linux-kernel, Xiu Jianfeng, kernel-hardening
On 2022/06/29 13:10, Christophe Leroy wrote:
>
>
> Le 29/06/2022 à 05:29, GONG, Ruiqi a écrit :
>> Fix the following Sparse warnings that got noticed when the PPC-dev
>> patchwork was checking another patch (see the link below):
>>
>> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
>> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
>>
>> Which in fact are triggered on all architectures that have
>> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
>> etc).
>>
>> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
>> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
>> ---
>> init/main.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/init/main.c b/init/main.c
>> index e2490387db2b..6aa0fb2340cc 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -101,6 +101,10 @@
>> #include <linux/stackdepot.h>
>> #include <net/net_namespace.h>
>>
>> +#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
>
> You don't need this #ifdef, there is already one inside
> linux/randomize_kstack.h
>
Ah yes, I didn't notice the config was there already. I will send a new
version. Thanks for your reminder!
>> +#include <linux/randomize_kstack.h>
>> +#endif
>> +
>> #include <asm/io.h>
>> #include <asm/bugs.h>
>> #include <asm/setup.h>
>> --
>> 2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-29 10:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 3:29 [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings GONG, Ruiqi
2022-06-29 3:29 ` GONG, Ruiqi
2022-06-29 5:10 ` Christophe Leroy
2022-06-29 5:10 ` Christophe Leroy
2022-06-29 5:51 ` Gong Ruiqi
2022-06-29 5:51 ` Gong Ruiqi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.