All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
@ 2020-12-29 15:41 ` Dylan Van Assche
  0 siblings, 0 replies; 6+ messages in thread
From: Dylan Van Assche @ 2020-12-29 15:41 UTC (permalink / raw)
  To: robh+dt, mripard, wens, jernej.skrabec, devicetree,
	linux-arm-kernel, linux-kernel
  Cc: Dylan Van Assche

All revisions of the PinePhone share most of the hardware.
This patch makes it easier to detect PinePhone hardware without
having to check for each possible revision.

Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
index 3d5a2ae9aa39..fb65319a3bd3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Pine64 PinePhone Developer Batch (1.0)";
-	compatible = "pine64,pinephone-1.0", "allwinner,sun50i-a64";
+	compatible = "pine64,pinephone-1.0", "pine64,pinephone", "allwinner,sun50i-a64";
 };
 
 &sgm3140 {
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
index c9b9f6e9ee8c..5e59d3752178 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Pine64 PinePhone Braveheart (1.1)";
-	compatible = "pine64,pinephone-1.1", "allwinner,sun50i-a64";
+	compatible = "pine64,pinephone-1.1", "pine64,pinephone", "allwinner,sun50i-a64";
 };
 
 &backlight {
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
index acc0ab53b9c1..4e7e237cb46a 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Pine64 PinePhone (1.2)";
-	compatible = "pine64,pinephone-1.2", "allwinner,sun50i-a64";
+	compatible = "pine64,pinephone-1.2", "pine64,pinephone", "allwinner,sun50i-a64";
 
 	wifi_pwrseq: wifi-pwrseq {
 		compatible = "mmc-pwrseq-simple";
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
@ 2020-12-29 15:41 ` Dylan Van Assche
  0 siblings, 0 replies; 6+ messages in thread
From: Dylan Van Assche @ 2020-12-29 15:41 UTC (permalink / raw)
  To: robh+dt, mripard, wens, jernej.skrabec, devicetree,
	linux-arm-kernel, linux-kernel
  Cc: Dylan Van Assche

All revisions of the PinePhone share most of the hardware.
This patch makes it easier to detect PinePhone hardware without
having to check for each possible revision.

Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
index 3d5a2ae9aa39..fb65319a3bd3 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Pine64 PinePhone Developer Batch (1.0)";
-	compatible = "pine64,pinephone-1.0", "allwinner,sun50i-a64";
+	compatible = "pine64,pinephone-1.0", "pine64,pinephone", "allwinner,sun50i-a64";
 };
 
 &sgm3140 {
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
index c9b9f6e9ee8c..5e59d3752178 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Pine64 PinePhone Braveheart (1.1)";
-	compatible = "pine64,pinephone-1.1", "allwinner,sun50i-a64";
+	compatible = "pine64,pinephone-1.1", "pine64,pinephone", "allwinner,sun50i-a64";
 };
 
 &backlight {
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
index acc0ab53b9c1..4e7e237cb46a 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Pine64 PinePhone (1.2)";
-	compatible = "pine64,pinephone-1.2", "allwinner,sun50i-a64";
+	compatible = "pine64,pinephone-1.2", "pine64,pinephone", "allwinner,sun50i-a64";
 
 	wifi_pwrseq: wifi-pwrseq {
 		compatible = "mmc-pwrseq-simple";
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
  2020-12-29 15:41 ` Dylan Van Assche
@ 2020-12-30  9:38   ` Chen-Yu Tsai
  -1 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2020-12-30  9:38 UTC (permalink / raw)
  To: Dylan Van Assche
  Cc: Rob Herring, Maxime Ripard, Jernej Skrabec, devicetree,
	linux-arm-kernel, linux-kernel

On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <me@dylanvanassche.be> wrote:
>
> All revisions of the PinePhone share most of the hardware.
> This patch makes it easier to detect PinePhone hardware without
> having to check for each possible revision.

Sounds good.

> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-

Please also update the DT binding file:

    Documentation/devicetree/bindings/arm/sunxi.yaml

ChenYu

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
@ 2020-12-30  9:38   ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2020-12-30  9:38 UTC (permalink / raw)
  To: Dylan Van Assche
  Cc: devicetree, Jernej Skrabec, linux-kernel, Maxime Ripard,
	Rob Herring, linux-arm-kernel

On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <me@dylanvanassche.be> wrote:
>
> All revisions of the PinePhone share most of the hardware.
> This patch makes it easier to detect PinePhone hardware without
> having to check for each possible revision.

Sounds good.

> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-

Please also update the DT binding file:

    Documentation/devicetree/bindings/arm/sunxi.yaml

ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
  2020-12-30  9:38   ` Chen-Yu Tsai
@ 2020-12-30 10:41     ` Dylan Van Assche
  -1 siblings, 0 replies; 6+ messages in thread
From: Dylan Van Assche @ 2020-12-30 10:41 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Rob Herring, Maxime Ripard, Jernej Skrabec, devicetree,
	linux-arm-kernel, linux-kernel

Hi,

Good point!
I will send a new version of the patch soon.

Kind regards,
Dylan Van Assche

On Wed, 2020-12-30 at 17:38 +0800, Chen-Yu Tsai wrote:
> On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <
> me@dylanvanassche.be> wrote:
> > All revisions of the PinePhone share most of the hardware.
> > This patch makes it easier to detect PinePhone hardware without
> > having to check for each possible revision.
> 
> Sounds good.
> 
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
> 
> Please also update the DT binding file:
> 
>     Documentation/devicetree/bindings/arm/sunxi.yaml
> 
> ChenYu


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
@ 2020-12-30 10:41     ` Dylan Van Assche
  0 siblings, 0 replies; 6+ messages in thread
From: Dylan Van Assche @ 2020-12-30 10:41 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: devicetree, Jernej Skrabec, linux-kernel, Maxime Ripard,
	Rob Herring, linux-arm-kernel

Hi,

Good point!
I will send a new version of the patch soon.

Kind regards,
Dylan Van Assche

On Wed, 2020-12-30 at 17:38 +0800, Chen-Yu Tsai wrote:
> On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <
> me@dylanvanassche.be> wrote:
> > All revisions of the PinePhone share most of the hardware.
> > This patch makes it easier to detect PinePhone hardware without
> > having to check for each possible revision.
> 
> Sounds good.
> 
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
> 
> Please also update the DT binding file:
> 
>     Documentation/devicetree/bindings/arm/sunxi.yaml
> 
> ChenYu


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-30 10:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 15:41 [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list Dylan Van Assche
2020-12-29 15:41 ` Dylan Van Assche
2020-12-30  9:38 ` Chen-Yu Tsai
2020-12-30  9:38   ` Chen-Yu Tsai
2020-12-30 10:41   ` Dylan Van Assche
2020-12-30 10:41     ` Dylan Van Assche

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.