* [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c
@ 2021-10-15 0:02 Phillip Potter
2021-10-15 7:55 ` Michael Straube
2021-10-15 8:32 ` Martin Kaiser
0 siblings, 2 replies; 5+ messages in thread
From: Phillip Potter @ 2021-10-15 0:02 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, straube.linux, martin, linux-staging, linux-kernel
Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
no purpose other than to print the name of the function they are in
(_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
function, which is better accomplished by other means. Also remove
the jiffies assignment at the start of the function, as it is no
longer used.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index f6db5b05e6e7..abbd107ad3c1 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
{
- u32 start = jiffies;
-
- MSG_88E("====> %s\n", __func__);
-
_ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
_ReadPROMContent(Adapter);
- MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
-
return _SUCCESS;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c
2021-10-15 0:02 [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c Phillip Potter
@ 2021-10-15 7:55 ` Michael Straube
2021-10-15 17:45 ` Phillip Potter
2021-10-15 8:32 ` Martin Kaiser
1 sibling, 1 reply; 5+ messages in thread
From: Michael Straube @ 2021-10-15 7:55 UTC (permalink / raw)
To: Phillip Potter, gregkh; +Cc: Larry.Finger, martin, linux-staging, linux-kernel
On 10/15/21 02:02, Phillip Potter wrote:
> Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
> no purpose other than to print the name of the function they are in
> (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
> function, which is better accomplished by other means. Also remove
> the jiffies assignment at the start of the function, as it is no
> longer used.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index f6db5b05e6e7..abbd107ad3c1 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
>
> static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
> {
> - u32 start = jiffies;
> -
> - MSG_88E("====> %s\n", __func__);
> -
> _ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
> _ReadPROMContent(Adapter);
>
> - MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
> -
> return _SUCCESS;
> }
>
>
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks,
Michael
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c
2021-10-15 7:55 ` Michael Straube
@ 2021-10-15 17:45 ` Phillip Potter
0 siblings, 0 replies; 5+ messages in thread
From: Phillip Potter @ 2021-10-15 17:45 UTC (permalink / raw)
To: Michael Straube; +Cc: Larry.Finger, martin, linux-staging, linux-kernel, gregkh
On Fri, Oct 15, 2021 at 09:55:21AM +0200, Michael Straube wrote:
> On 10/15/21 02:02, Phillip Potter wrote:
> > Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
> > no purpose other than to print the name of the function they are in
> > (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
> > function, which is better accomplished by other means. Also remove
> > the jiffies assignment at the start of the function, as it is no
> > longer used.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> > drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> > index f6db5b05e6e7..abbd107ad3c1 100644
> > --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> > @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
> > static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
> > {
> > - u32 start = jiffies;
> > -
> > - MSG_88E("====> %s\n", __func__);
> > -
> > _ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
> > _ReadPROMContent(Adapter);
> > - MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
> > -
> > return _SUCCESS;
> > }
> >
>
> Looks good to me.
>
> Acked-by: Michael Straube <straube.linux@gmail.com>
>
> Thanks,
> Michael
Dear Michael,
Thanks for this, much appreciated.
Regards,
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c
2021-10-15 0:02 [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c Phillip Potter
2021-10-15 7:55 ` Michael Straube
@ 2021-10-15 8:32 ` Martin Kaiser
2021-10-15 17:47 ` Phillip Potter
1 sibling, 1 reply; 5+ messages in thread
From: Martin Kaiser @ 2021-10-15 8:32 UTC (permalink / raw)
To: Phillip Potter
Cc: gregkh, Larry.Finger, straube.linux, linux-staging, linux-kernel
Thus wrote Phillip Potter (phil@philpotter.co.uk):
> Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
> no purpose other than to print the name of the function they are in
> (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
> function, which is better accomplished by other means. Also remove
> the jiffies assignment at the start of the function, as it is no
> longer used.
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
> 1 file changed, 6 deletions(-)
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index f6db5b05e6e7..abbd107ad3c1 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
> static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
> {
> - u32 start = jiffies;
> -
> - MSG_88E("====> %s\n", __func__);
> -
> _ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
> _ReadPROMContent(Adapter);
> - MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
> -
> return _SUCCESS;
> }
Makes sense to me. We should get rid of the prints that show only the
function name.
Acked-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c
2021-10-15 8:32 ` Martin Kaiser
@ 2021-10-15 17:47 ` Phillip Potter
0 siblings, 0 replies; 5+ messages in thread
From: Phillip Potter @ 2021-10-15 17:47 UTC (permalink / raw)
To: Martin Kaiser
Cc: gregkh, Larry.Finger, straube.linux, linux-staging, linux-kernel
On Fri, Oct 15, 2021 at 10:32:11AM +0200, Martin Kaiser wrote:
> Thus wrote Phillip Potter (phil@philpotter.co.uk):
>
> > Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
> > no purpose other than to print the name of the function they are in
> > (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
> > function, which is better accomplished by other means. Also remove
> > the jiffies assignment at the start of the function, as it is no
> > longer used.
>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> > drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
> > 1 file changed, 6 deletions(-)
>
> > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> > index f6db5b05e6e7..abbd107ad3c1 100644
> > --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> > @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
>
> > static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
> > {
> > - u32 start = jiffies;
> > -
> > - MSG_88E("====> %s\n", __func__);
> > -
> > _ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
> > _ReadPROMContent(Adapter);
>
> > - MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
> > -
> > return _SUCCESS;
> > }
>
> Makes sense to me. We should get rid of the prints that show only the
> function name.
>
> Acked-by: Martin Kaiser <martin@kaiser.cx>
Dear Martin,
Many thanks for the Acked-by :-)
Regards,
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-15 17:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 0:02 [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c Phillip Potter
2021-10-15 7:55 ` Michael Straube
2021-10-15 17:45 ` Phillip Potter
2021-10-15 8:32 ` Martin Kaiser
2021-10-15 17:47 ` Phillip Potter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.