* [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
@ 2021-05-17 14:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-17 14:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc, linux-kernel
The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
does not have real effect as the macro is not used in the code.
Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
index fc9250fb3133..4bfd9a210da2 100644
--- a/include/linux/soc/samsung/exynos-regs-pmu.h
+++ b/include/linux/soc/samsung/exynos-regs-pmu.h
@@ -613,7 +613,7 @@
/* For EXYNOS_CENTRAL_SEQ_OPTION */
#define EXYNOS5_USE_STANDBYWFI_ARM_CORE0 BIT(16)
-#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BUT(17)
+#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BIT(17)
#define EXYNOS5_USE_STANDBYWFE_ARM_CORE0 BIT(24)
#define EXYNOS5_USE_STANDBYWFE_ARM_CORE1 BIT(25)
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
@ 2021-05-17 14:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-17 14:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc, linux-kernel
The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
does not have real effect as the macro is not used in the code.
Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
index fc9250fb3133..4bfd9a210da2 100644
--- a/include/linux/soc/samsung/exynos-regs-pmu.h
+++ b/include/linux/soc/samsung/exynos-regs-pmu.h
@@ -613,7 +613,7 @@
/* For EXYNOS_CENTRAL_SEQ_OPTION */
#define EXYNOS5_USE_STANDBYWFI_ARM_CORE0 BIT(16)
-#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BUT(17)
+#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BIT(17)
#define EXYNOS5_USE_STANDBYWFE_ARM_CORE0 BIT(24)
#define EXYNOS5_USE_STANDBYWFE_ARM_CORE1 BIT(25)
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
2021-05-17 14:12 ` Krzysztof Kozlowski
@ 2021-05-19 14:36 ` Alim Akhtar
-1 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2021-05-19 14:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, open list, Alim Akhtar
Hello Krzysztof
On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
> does not have real effect as the macro is not used in the code.
>
Can we consider removing this? As this is not used in code.
> Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index fc9250fb3133..4bfd9a210da2 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -613,7 +613,7 @@
>
> /* For EXYNOS_CENTRAL_SEQ_OPTION */
> #define EXYNOS5_USE_STANDBYWFI_ARM_CORE0 BIT(16)
> -#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BUT(17)
> +#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BIT(17)
> #define EXYNOS5_USE_STANDBYWFE_ARM_CORE0 BIT(24)
> #define EXYNOS5_USE_STANDBYWFE_ARM_CORE1 BIT(25)
>
> --
> 2.27.0
>
--
Regards,
Alim
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
@ 2021-05-19 14:36 ` Alim Akhtar
0 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2021-05-19 14:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, open list, Alim Akhtar
Hello Krzysztof
On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
> does not have real effect as the macro is not used in the code.
>
Can we consider removing this? As this is not used in code.
> Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index fc9250fb3133..4bfd9a210da2 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -613,7 +613,7 @@
>
> /* For EXYNOS_CENTRAL_SEQ_OPTION */
> #define EXYNOS5_USE_STANDBYWFI_ARM_CORE0 BIT(16)
> -#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BUT(17)
> +#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BIT(17)
> #define EXYNOS5_USE_STANDBYWFE_ARM_CORE0 BIT(24)
> #define EXYNOS5_USE_STANDBYWFE_ARM_CORE1 BIT(25)
>
> --
> 2.27.0
>
--
Regards,
Alim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
2021-05-19 14:36 ` Alim Akhtar
@ 2021-05-19 14:47 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-19 14:47 UTC (permalink / raw)
To: Alim Akhtar; +Cc: linux-arm-kernel, linux-samsung-soc, open list, Alim Akhtar
On 19/05/2021 10:36, Alim Akhtar wrote:
> Hello Krzysztof
>
> On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
>> does not have real effect as the macro is not used in the code.
>>
> Can we consider removing this? As this is not used in code.
Sure, I guess, if someone needs this bit, can always check in the
documentation :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
@ 2021-05-19 14:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-19 14:47 UTC (permalink / raw)
To: Alim Akhtar; +Cc: linux-arm-kernel, linux-samsung-soc, open list, Alim Akhtar
On 19/05/2021 10:36, Alim Akhtar wrote:
> Hello Krzysztof
>
> On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
>> does not have real effect as the macro is not used in the code.
>>
> Can we consider removing this? As this is not used in code.
Sure, I guess, if someone needs this bit, can always check in the
documentation :)
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-19 14:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 14:12 [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo Krzysztof Kozlowski
2021-05-17 14:12 ` Krzysztof Kozlowski
2021-05-19 14:36 ` Alim Akhtar
2021-05-19 14:36 ` Alim Akhtar
2021-05-19 14:47 ` Krzysztof Kozlowski
2021-05-19 14:47 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.