All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 4/5] stih-cec: use CEC_CAP_DEFAULTS
Date: Thu, 17 Aug 2017 08:46:41 +0200	[thread overview]
Message-ID: <6c826abc-ea0a-3728-2946-52b72b3aad34@xs4all.nl> (raw)
In-Reply-To: <20170804104155.37386-5-hverkuil@xs4all.nl>

Benjamin,

Can you please review this patch and the stm32-cec patch?

Thanks!

	Hans

On 08/04/2017 12:41 PM, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Use the new CEC_CAP_DEFAULTS define in this driver.
> This also adds the CEC_CAP_RC capability which was missing here
> (and this is also the reason for this new define, to avoid missing
> such capabilities).
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
>  drivers/media/platform/sti/cec/stih-cec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/sti/cec/stih-cec.c b/drivers/media/platform/sti/cec/stih-cec.c
> index ce7964c71b50..dc221527fd05 100644
> --- a/drivers/media/platform/sti/cec/stih-cec.c
> +++ b/drivers/media/platform/sti/cec/stih-cec.c
> @@ -351,9 +351,7 @@ static int stih_cec_probe(struct platform_device *pdev)
>  	}
>  
>  	cec->adap = cec_allocate_adapter(&sti_cec_adap_ops, cec,
> -			CEC_NAME,
> -			CEC_CAP_LOG_ADDRS | CEC_CAP_PASSTHROUGH |
> -			CEC_CAP_TRANSMIT, CEC_MAX_LOG_ADDRS);
> +			CEC_NAME, CEC_CAP_DEFAULTS, CEC_MAX_LOG_ADDRS);
>  	if (IS_ERR(cec->adap))
>  		return PTR_ERR(cec->adap);
>  
> 

  reply	other threads:[~2017-08-17  6:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 10:41 [PATCH 0/5] cec: add CEC_CAP_DEFAULTS define Hans Verkuil
2017-08-04 10:41 ` [PATCH 1/5] media/cec.h: add CEC_CAP_DEFAULTS Hans Verkuil
     [not found]   ` <CGME20170816084045epcas2p435b2d7ef400710156d28a6e6bdf90efd@epcas2p4.samsung.com>
2017-08-16  8:40     ` Sylwester Nawrocki
2017-08-20 13:09       ` Benjamin Gaignard
2017-08-04 10:41 ` [PATCH 2/5] adv*/vivid/pulse8/rainshadow: cec: use CEC_CAP_DEFAULTS Hans Verkuil
2017-08-04 10:41 ` [PATCH 3/5] s5p-cec: " Hans Verkuil
     [not found]   ` <CGME20170816084104epcas1p28b1eba2785ff9d8c62f254a4316786a7@epcas1p2.samsung.com>
2017-08-16  8:40     ` Sylwester Nawrocki
2017-08-04 10:41 ` [PATCH 4/5] stih-cec: " Hans Verkuil
2017-08-17  6:46   ` Hans Verkuil [this message]
2017-08-20 13:11   ` Benjamin Gaignard
2017-08-20 13:18     ` Hans Verkuil
2017-08-04 10:41 ` [PATCH 5/5] stm32-cec: " Hans Verkuil
2017-08-20 13:13   ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c826abc-ea0a-3728-2946-52b72b3aad34@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=benjamin.gaignard@linaro.org \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.